From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 711573644BC for ; Tue, 17 Mar 2026 09:40:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773740412; cv=none; b=kg9YWONoY1sBomjSUF3LrdhihoT4fb4mOxTt0xBRrzZp5AElUidHYvJh1N68ZsPvpbhoNRdfRv01KExUTiFAhshNZhc6TM4KjgSwgOJUqdn7Zds9lsbQhPG00gVm4SvPL+PAGo8yz7E41Vc1fIeyi9e7vTG2r1Y+k84wZVkOtAI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773740412; c=relaxed/simple; bh=JTNbqf8DGAUBGfeMTwQGssgbdVOumIxMZVJ0lAggtwc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GagFaZ6FQF9QO2ZuM+KZ7YBzeA7VmQQfG/cniUgMcYs1OS7jku+yvcw4FHOsICc+WD/lBAa7L/vsZwEcdlNyUvzPkWOanUdomcuOSXjZXcXsQ2TivLghStYNq2MnDzahbF1sSWdki1ycCXg8t3JJzkcQ+HnU9IiAVC26dxHfelM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=MCi5Nk14; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="MCi5Nk14" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3nqXdv5ey4zRFmM5e2Jz+JNLboZ9L63KyK4oXHGekBc=; b=MCi5Nk14kmH/8aqqR/qTMVXJW6 qL5YsGpkEhLt2rpulLUpTE3tLVQFd+oZhZYMKFrND5EgvzToIvPnGj1SXvz0GdWIrfFlA3f7QLcOU 0O8mULzakOJrHaXYRoTpReBcExhehK0/thhqUQnMThreB5nlPzHHBqKqrSme74H4unr4+JY07f7eq O9i33YsXDTV4TsV2X+MByGTakWOa0KB3WY257uZSc2GWxupaUy+Coya16sNC8DktVQJAODPF/J1k7 4pAzmLFBDzx7UOp3VVVnfzZO3L6fiuF5G6hpJr9L+bz3flO031VmTIT+Gb3eU9Y6T+a3TcU1yE+bK dc9xfpiQ==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w2QtO-002n3V-JN; Tue, 17 Mar 2026 09:39:13 +0000 Date: Tue, 17 Mar 2026 02:39:07 -0700 From: Breno Leitao To: Rui Qi Cc: rafael@kernel.org, tony.luck@intel.com, bp@alien8.de, guohanjun@huawei.com, mchehab@kernel.org, xueshuai@linux.alibaba.com, lenb@kernel.org, pjw@kernel.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, jonathan.cameron@huawei.com, fabio.m.de.francesco@linux.intel.com, jason@os.amperecomputing.com, inux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, inux-riscv@lists.infradead.org Subject: Re: [PATCH] ACPI: APEI: ghes: mark ghes_in_nmi_spool_from_list maybe unused Message-ID: References: <20260316082842.84356-1-qirui.001@bytedance.com> <6ccfd504-adfd-473b-9317-0fc536acc939@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ccfd504-adfd-473b-9317-0fc536acc939@bytedance.com> X-Debian-User: leitao On Tue, Mar 17, 2026 at 11:55:52AM +0800, Rui Qi wrote: > On 3/16/26 5:03 PM, Breno Leitao wrote: > > If there is consensus that we should address this via conditional > compilation instead, I can follow up > with another patch that wraps these helpers in something like #if > IS_ENABLED(CONFIG_ACPI_APEI_SEA) || > IS_ENABLED(CONFIG_HAVE_ACPI_APEI_NMI). This approach would be worse, I would say. Your current approach seems cleaner, IMO. Thanks for explaining the reason here. --breno