From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFBAD37C907 for ; Tue, 17 Mar 2026 10:54:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773744849; cv=none; b=ONuM0fmyuVX8k8eVJ3G2sOplntg1sISIb+hP4D/NFXauOKFl+f85kgD70IxufGkvf3XWW0P9OyUOBV190atluPFiPg0QOiSjjO6opKe0OiFnGoFDUztN/TZnrRVA3BjJhhqlVMgEnu1f0efXoIRdQnxk69NUceAGjdUiyM8jJTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773744849; c=relaxed/simple; bh=P9BFaqiVAHISRH1/Ftr1F7bJPDlJE0OkKEIBF/sU00Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QaLyJf47jqgmWLKaAlE6kxiWmOiLngClVU6ubG0nYSa+V9jTRI4EAbPOvpsENoeEAvqZkwl4UZAJ5inRjzc1erd9NmwlFuwPfA6l5TG4p5Rb1joAk3VVLPzGjtqHD7rm6ME2QOZEaBFFoTSjQ2fv/ypSOrOhNVKS2X0ixpsrM98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gJalPmVu; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gJalPmVu" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4856cd3f1ffso14511095e9.3 for ; Tue, 17 Mar 2026 03:54:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773744846; x=1774349646; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZWnPu/gx7qeFux1v3KRj7Gsdw359R9/cx6A/cAlvbPE=; b=gJalPmVutSjdHwj+Btg6YFlJEHlIADkXdOmfpLHmymz+Z6tHy89P68IdUlqI6fEj6h CW8U0EIOxDRG/pjK/zVZ4/0WfpLy4oNeIscaZ2YisLAdKdlUaUbWIugp8OCaIvZR8UfC lrW+bR4BXHYsBSe2v3TEY7E52Cd3DygRFbqdzorqCwVbCD4U4UJHc9/+9hG7G6t43xFx PPypNNdnXbmr3YdJraXXfg1HFQasIyi4/WmJx3r2AUnjrK/XkC9D77R+8zK1igTA1fZb I4KlSCso3tb3unUdf0tJvFeW+8pfKCmYnXJfZHhS53ZB0m9Z/wmXYlEcAyiWluWLUZGf PFVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773744846; x=1774349646; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZWnPu/gx7qeFux1v3KRj7Gsdw359R9/cx6A/cAlvbPE=; b=aSWrF2KXtXjO8CnlODlY+QvwihKLpPOcPvKiVRAS7QfDeWDEO+PovVE7g01jIW4f5w R95zzxfnQEJIW7FdBU4BpzinhzD7oIy/ClCw8wgFJdupftRqITIBcXIwcBUK/9V35tGs zc6Fyxxs2Cvv3W5pd2R48IBG05Kt5KO6KAqQk2jrSWvo2iMUQaHbz+WN/ZGDddKi+nLn Ef6Ye+NDi5abeSK/RJzh8VQjkQsGGDbh9ygQVX5S+KkfFw4AjToFo/E1gXUp7WMqfmtH GMXx0uaqaexfRd4MQoCWzRn22FI1SqAioQw8Ynb1ybYGS8TJLiNYz4CrbuDD45gpl/d0 ZaMA== X-Forwarded-Encrypted: i=1; AJvYcCWjpbrs2mYjD3Snsqc/oTLNfRc1wkcuovAWSLipCelluApPKisQMLJdClt2/LJXvq1fWExtgZJlaLQMMns=@vger.kernel.org X-Gm-Message-State: AOJu0Yx32wtez0Kyg7jGfIhXKmOIOXU7iFgZ+cRLQZ2sEFFlVtxXPtfn EKBCvFLq0C6TsPQRfL+AzTwYRNOYDy7UzWTfd/NgOchEHrYD4D3HSSVF X-Gm-Gg: ATEYQzzkhiVySVkUK/6njbvBiFtaDx7Rw7XZA7XGIf/wDHRnNwn2/kjPVvHRfqswmH4 q+8gz9Z1HFR4OvWKgCh9HbUy82GF3IREahzyRRiZm9sqBZWbXtKGdG0EioV5EF/VbN7x7VxcJEp ybUujoRfDM0+zwY+7syUWnBj2VMhvYHXiEiajjICWQzO1K2+qQIgAGHguTZXvscdtMEkZQZF3bJ KvanpdeSjS1AFZ9M7/d/Jp7GaMJDXPOzrWymXuvgv+uFmC4LSOGszjsnOaHPJKmSqsU+5VY2KPq r+VqD43TlU7jNoQ+yI+m2gZVyO1h4PxWijuErqPz4BzRRDb1ypYxRMbgULJy5cN7/Zts7k/OBRN QgUUm624+XRJFTYlnMAhOChJ42yf2p59Cva7eI58KHmjQ8x64vhVj7MJ/ADV7qYQ7e3h/8lOkTE ZpIcXVNyYMo58Pl2PgIudt8amAQoOvsGiNBBNP9sOPlO/9r465pYw4h4AeQDtrP5WqBpHVHzs9d QGkRIXcRdkZwNsZhWfftJ1fwDkxvmLChNdS1VaOmB3TcxiKlIlQxKKyRFBsurHI9lb397IrZEV8 vM2BkPRowQ== X-Received: by 2002:a05:600c:1d0f:b0:47e:e2eb:bc22 with SMTP id 5b1f17b1804b1-485566ca95cmr267107525e9.5.1773744845991; Tue, 17 Mar 2026 03:54:05 -0700 (PDT) Received: from mail.gmail.com (2a01cb0889497e001bd1b8260f3f46ac.ipv6.abo.wanadoo.fr. [2a01:cb08:8949:7e00:1bd1:b826:f3f:46ac]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4856e850634sm105395885e9.0.2026.03.17.03.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 03:54:05 -0700 (PDT) Date: Tue, 17 Mar 2026 11:54:03 +0100 From: Paul Chaignon To: Sun Jian Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, shuah@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2] selftests/bpf: trampoline_count: use dedicated target function Message-ID: References: <20260315054227.118344-1-sun.jian.kdev@gmail.com> <20260317010209.8779-1-sun.jian.kdev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260317010209.8779-1-sun.jian.kdev@gmail.com> On Tue, Mar 17, 2026 at 09:02:09AM +0800, Sun Jian wrote: > trampoline_count fills all trampoline attachment slots for a single > target function and verifies that one extra attach fails with -E2BIG. > > It currently targets bpf_modify_return_test, which is also used by > modify_return and get_func_ip_test. When those tests run in parallel, > they can contend for the same per-function trampoline quota and > cause unexpected attach failures. This issue is currently masked by > harness serialization. > > Add a dedicated bpf_trampoline_count_test target and switch > trampoline_count to use it. This keeps the test semantics unchanged > while isolating it from other modify_return-based selftests, so it no > longer needs to run in serial mode. Remove the TODO comment as > well. > > Tested: > ./test_progs -t trampoline_count -vv > ./test_progs -t modify_return -vv > ./test_progs -t get_func_ip_test -vv > ./test_progs -j$(nproc) -t trampoline_count -vv > ./test_progs -j$(nproc) -t > trampoline_count,modify_return,get_func_ip_test -vv > > Tested-by: Paul Chaignon > Signed-off-by: Sun Jian > --- > > v2: > - add Paul's Tested-by FYI, in general, unless there are merge conflicts, you don't need to resend just for the tags. Maintainers can apply those when they merge. [...]