From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Richard Weinberger <richard@nod.at>,
Andrew Morton <akpm@linux-foundation.org>,
chengzhihao1 <chengzhihao1@huawei.com>,
jserv <jserv@ccns.ncku.edu.tw>, eleanor15x <eleanor15x@gmail.com>,
marscheng <marscheng@google.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lib/list_sort: introduce list_sort_nonatomic() and remove dummy cmp() calls
Date: Wed, 18 Mar 2026 00:08:52 +0800 [thread overview]
Message-ID: <abl8lJ5_hFSRHu6-@google.com> (raw)
In-Reply-To: <abln0mfbHdueNgtD@infradead.org>
On Tue, Mar 17, 2026 at 07:40:18AM -0700, Christoph Hellwig wrote:
> On Tue, Mar 17, 2026 at 03:38:41PM +0100, Richard Weinberger wrote:
> > ----- Ursprüngliche Mail -----
> > >> For UBIFS, this patch doesn't alter the frequency, timing, or behavior
> > >> of the cond_resched() calls at all, so I am confident that this won't
> > >> introduce any regressions.
> > >
> > > I'd be tempted to drop the workaround and remove the cond_resched
> > > from ubifs given that entirely non-preemptible scheduling models are
> > > on their way out.
> >
> > arm32 still has no preempt-lazy.
> > This is one of the biggest platforms where UBIFS is still used.
>
> Time to fix that if it wants to stay alive.
>
It seems that dropping cond_resched() right now would cause issues for
UBIFS.
Given that, let's stick with current plan for now. If we reach a point
in the future where it's safe to drop these scheduling points, we can
always revisit this and remove then.
Regards,
Kuan-Wei
next prev parent reply other threads:[~2026-03-17 16:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 19:39 [PATCH] lib/list_sort: introduce list_sort_nonatomic() and remove dummy cmp() calls Kuan-Wei Chiu
2026-03-16 7:25 ` Richard Weinberger
2026-03-16 18:04 ` Kuan-Wei Chiu
2026-03-16 21:49 ` Richard Weinberger
2026-03-17 14:22 ` Christoph Hellwig
2026-03-17 14:38 ` Richard Weinberger
2026-03-17 14:40 ` Christoph Hellwig
2026-03-17 16:08 ` Kuan-Wei Chiu [this message]
2026-03-17 4:05 ` Zhihao Cheng
2026-03-17 12:32 ` Kuan-Wei Chiu
2026-03-17 13:22 ` Zhihao Cheng
2026-03-17 14:15 ` Kuan-Wei Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abl8lJ5_hFSRHu6-@google.com \
--to=visitorckw@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chengzhihao1@huawei.com \
--cc=eleanor15x@gmail.com \
--cc=hch@infradead.org \
--cc=jserv@ccns.ncku.edu.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marscheng@google.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox