From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D02F338936 for ; Tue, 17 Mar 2026 14:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773758660; cv=none; b=uVALWezILWQKmR5mT+Fstb/dNeJ4cb6cmmb6wKPuyWnNMZnKSzQT/z7B9V2srJ25/dE2IQu3W1EGX9X4/h+06ElmV4LQ2pKRkC9SUuvf+vMBvdH9WNaO3uIfRI8YEWhcNpkIAT5aTSsnOkrHegYS+6udyafAsrwdOrY+BHopevA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773758660; c=relaxed/simple; bh=/lQKc4RWjClPYwy5GhiuYFdZiaSmsAVh0wNDXmbpJoY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B76nf78P84n2s1F9fhU6yCf+UYZpRUovQxGhorC0JgUoawcIxZbvnwhwM5PALRoUdo4t6PlIVvXnMRVHWntG8Wf5FyfSy9zXcGXaSeF4WcRvEaYoqlmeahe+jcpbE3PAHgqo3AqaRinoBELx1MAfWeUwzCodF0xMCinWogG13Kk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kHpNGVQw; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kHpNGVQw" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-48539d21b76so42224495e9.1 for ; Tue, 17 Mar 2026 07:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1773758657; x=1774363457; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hPmJE/ZDBtcsRuCApMprqj5MgjddWs0EvxZ7lU2ScvU=; b=kHpNGVQw/lo8OK7TUtBudEmGqY3Dl5yiGmsCRVGys2e7GBBigG2JBdUgAsYILveRup MfT1Ux+9cObn3mD1kLnymjWNJ4/1NGf5+MIgBJ2XtIYXJJF8+n+NmVWK3IUnOKjBseH7 wefrEUfpnF4eDZ+kyR47nVhYqALy/mAOwImZHTwF8OLjSCu36c7OEhz3T3Wh10OQj5xW hiQwH4iN9e92i8xtw6JSNO+t2Ma4032JS1gQ9h13VZ8FjUCMu8+ufhBi7tZGb13MEAfp MUHzVxFCdSLX2EtW3/+32DemmGzfM6R8n/HxVhf9LpqZ8GTqxTgincA9NTnum4LKSyC0 cSUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773758657; x=1774363457; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hPmJE/ZDBtcsRuCApMprqj5MgjddWs0EvxZ7lU2ScvU=; b=sEapzjbuZAQX3rS4idFDpDPJavQbSNlPVXKZTKHlpyHZ+QRhdHdwQD7qm9VTp2ZU8E o4KGjTMGMZWZSitYj0fPkBTmOKlxqvWA1MyXDjwaiScLLCHebjMwKU/xLE+G56ethCvg 5miMptOKEELpQuVzjRkRkY2E7WXrKHnuXUtpZXepUKpVDDXDXxw2vuawzOgoe8Eptn1j noTuDu9wFb6OsdV5sl3txc+UWm71ELt+JgG9mu6J7Rs4UJLMsZTcbqwQwlZONp9z4B5e vZ5rqk/y+WjNfYVhr+6jQPBodU2XnuDawDP9gpomZe8m7ts4WMJNR89CleikNXcmE+Kf li1g== X-Forwarded-Encrypted: i=1; AJvYcCUDCSN1C/VPQRx1XeSpeG1sAfYUCI9qqbds4d6qTUy97CCqYi28Sg0yLUgJA9P94Ug1iT82DAagfOtZS0w=@vger.kernel.org X-Gm-Message-State: AOJu0Ywuj1c50yWZs3p93+R/3bFOLzZdFiFffc3VJWv3ligLsFFtSDNE HdkKoBGEn5GlSabqUbClE0esNYgpFweG6OlMEOdFKhffEM3fUAVBrKvM8Ap3QcEaoZR1LCzxclT PG1It X-Gm-Gg: ATEYQzyC8qrvASCXz0/cVKTjdFnqCf/nvAXd7Nsg5mscaP2nEoY/IHVYZTL7DctH1ty OD7+1UjIo7/eaIW0m0t6ZB0lFzH+MhRljcmELEHe3Wg+QCPXJMHGBDL4GRL7tNdS3/U286VjdEA NSd6Sbx5NwNpJ5R2a+uGgyqymvUKUmumoxa2iHKSC4XAeX4MlGqJxEqjMbcV8IDCL/wWJ0hio+d Nu+/Jb+zjb1k0+P6A+XK1eyOPFX+lXXxeLAzCHwLdnMmbkvSa2AXXpNYlb29HG4TbuyJiL7mfIF 789g3AM4dz0bo8781UOAcWCQK/GkvwoamKfmW3pc+fkCxZYi6ezf3WZrEyHc+rXpBgXzWVXGcRO 4asSwbOTpPvVxlNMv2D8owsw8IQvXAeO00HtZz1skKhLkCLN9ax3/22b2YznK83StSCc9cgD3et DwcQuebvcbdyYBfkqBez0cawIrpMHo X-Received: by 2002:a05:600c:a15:b0:485:34a2:919e with SMTP id 5b1f17b1804b1-48556710fd5mr300281185e9.33.1773758656794; Tue, 17 Mar 2026 07:44:16 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4856ea98070sm68882275e9.6.2026.03.17.07.44.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 07:44:16 -0700 (PDT) Date: Tue, 17 Mar 2026 17:44:13 +0300 From: Dan Carpenter To: Teng Liu <27rabbitlt@gmail.com> Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vme_user: add blank line after declarations in fake_driver struct Message-ID: References: <20260317131821.54768-2-27rabbitlt@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260317131821.54768-2-27rabbitlt@gmail.com> On Tue, Mar 17, 2026 at 02:18:22PM +0100, Teng Liu wrote: > Add a blank line between regular field declarations and function pointer > declarations in struct fake_driver to follow the kernel coding style > convention of separating declarations for improved readability. > > This addresses the following checkpatch warning: > WARNING: Missing a blank line after declarations > > Signed-off-by: Teng Liu <27rabbitlt@gmail.com> > --- > drivers/staging/vme_user/vme_fake.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c > index be4ad47ed..eb918a857 100644 > --- a/drivers/staging/vme_user/vme_fake.c > +++ b/drivers/staging/vme_user/vme_fake.c > @@ -67,6 +67,7 @@ struct fake_driver { > unsigned long long lm_base; > u32 lm_aspace; > u32 lm_cycle; > + > void (*lm_callback[4])(void *); This is in a struct, right? It's all declarations... Just ignore checkpatch when it prints nonsense. regards, dan carpenter > void *lm_data[4]; > struct tasklet_struct int_tasklet; > -- > 2.53.0 >