From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f48.google.com (mail-yx1-f48.google.com [74.125.224.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C84A396B63 for ; Tue, 17 Mar 2026 21:41:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773783665; cv=none; b=O2l/kTa0Wmh42en6ra+ifHQqODP4MzFStEQ0lF2YDw5JeZKs3S4MTkOnEyQrRgE7527/FEq27yhx7kt0Vz+dCBIslYiV3WI09EmobIkrOZwoHPKG1ddlJabvw705vxOIRhojZyXCbFLJJIAq8inQVMF2u39LG+s5e7O+x+pY03I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773783665; c=relaxed/simple; bh=09hOL83tVBr/LihHmyAvXs8Awpdqkkb+fou4oZHmcko=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=We09NZ+9CHhjwhmQiXFrtKqL3RrWXahbdN8IK7lQ74bX4N6DIvQGrTVCgon5ucefv4878DjfD4kDvkU/etshOih5OaKBA20W+Ii9ILfUK9mlL2WDNibuIT+BSHdReByTKYsB9ToW65C++FULz008z2Rdiqhc2Lnh4fsgQS6nduA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y6A5qf3Z; arc=none smtp.client-ip=74.125.224.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y6A5qf3Z" Received: by mail-yx1-f48.google.com with SMTP id 956f58d0204a3-64ca9ec3ee7so7570911d50.3 for ; Tue, 17 Mar 2026 14:41:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773783663; x=1774388463; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fdMk8K9gKZoM6sms8pJWkdJXlxOeTpf/a44ocaiQWz4=; b=Y6A5qf3ZET9WUMmFsT3KrH7uWoy7W+V0xkCZ0YI3VZWDtimiHkkvj4jM2m2R/558DT mEwIhce5MIZrYsXwlXungJGLA7l9XHVoPIU9Zt4zruR52v1ekl4+4PeuX09bSHzHjFpm 6ncwtCA1MiTsti+5cmrRZglQhogIxSzRwxQS9VGWNL4Q78UU0ZYoRVMmWlwojvxalMnf iD4UuJzfZlxzQ01xbUxgAaWLWW8I1fai8PX9aRy9M2VJ5qb4i7zZLjIAJN6eHfoE7XGv 3OCyFD2RY0WBiF4v3niA9K2DJ5qLRdhkdpaqZfuEmrGSitmf1ReYK57SAS7nYwlSBvT2 lKOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773783663; x=1774388463; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fdMk8K9gKZoM6sms8pJWkdJXlxOeTpf/a44ocaiQWz4=; b=EQYn1NGwZGKfHgzHxfXR4TN8+ulWakhdQelMAG1/Ix3RIEY1uwULjkZohhGC+XH3KX Uo6DEewM4x4BpQ//Mg2tLrBidspzyFNmTXD9vYXAlbfb0f3b0r4EC4mchBh2AYRk51C9 GNyxI/MvrtY/jAflF5gacdxKK7RmhCKVV9VDx1kC8WEo0woLiRMgjHUMCT9oSRWnU9R/ r81woEsWZtYpuurWPaKHlggDfD4LXMDANEPE0K4eA9MsN/v9NlA5F1RJtudsOMv1Ja3e ZiB3/SdlhC0Qx21N/oFI8L3oFp2QJsJnjIwC0bQ8RGdzkK1DdC/jwl/jlkSWtN1DZcOT O1iQ== X-Forwarded-Encrypted: i=1; AJvYcCXBtguhxXZG3yn+SasT3ujpU56FHGyyMIEzFyI7Iy+omg3aNmhw0IAvf1sLxdQ9+DMmXrqj5HvU8iPK4ms=@vger.kernel.org X-Gm-Message-State: AOJu0YxXwRzM+Qhe9ve7w9tupNZEUZtxADu6AKUNLSL/fxeByuIkxjcf EtAjjO2VqmHrTgS7aWGOC4mux7gJRcljcnclE103FqNPbAuqUBhadtZb X-Gm-Gg: ATEYQzzY74Rnr4ktMDbc9Q57cA5wXy7lWWj9infvsjIqwwuzFOM/sd44ge/m8Ws7cdf 6mEvqlII1iNn/jXcZ9EjiIKTq2nhIbuMPA4qkWZZZHUO/TZY8JgazjpiYYmoFUFQzcgjHMCrR0e T6Gb7duDeZFIQqieJBzAJ+3ukqFzcuIHO5nf2KQdhDp6VS2rNgiSgMuybSpO18+HbdX5VVLS9QW PBLM95PkIr8DcxVKhfkrwsJeHvmcvldL1ijBYfRHtFpR4zh35a3dioMn4n35FR7KVefp1FwL33s yBWqfXBEUwAZwZWnY0PQVAfPFRTNb9h0xmwkV3eU7hPnQ2Oj/YQNn0RM0aBFLcN42BHbqZbXBkg NVfgF8fN76BCIxbghMhC3POZvQmITgST95buVk32mudk43UD2J2c1ZFkCfGO+6ctxlD8a0EIEAc ml1d7wOKKP6t63G2nJNSIPBeDrMicjd4DdUMcm2OBInEhCdKX0voszxYZgbQ== X-Received: by 2002:a05:690e:1a1f:b0:64c:2581:eed9 with SMTP id 956f58d0204a3-64e916057d2mr1018690d50.70.1773783663011; Tue, 17 Mar 2026 14:41:03 -0700 (PDT) Received: from devvm11784.nha0.facebook.com ([2a03:2880:25ff:58::]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64e91c2b32fsm509608d50.18.2026.03.17.14.41.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 14:41:02 -0700 (PDT) Date: Tue, 17 Mar 2026 14:41:01 -0700 From: Bobby Eshleman To: Paolo Abeni Cc: Stefano Garzarella , Shuah Khan , virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Jakub Kicinski , Bobby Eshleman Subject: Re: [PATCH net-next 1/2] selftests/vsock: fix vmtest.sh for read-only nested VM runners Message-ID: References: <20260313-vsock-vmtest-nested-fixes-v1-0-d0e6274c3193@meta.com> <20260313-vsock-vmtest-nested-fixes-v1-1-d0e6274c3193@meta.com> <302d1a45-dd5d-4d50-a99c-ce73de196d0c@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <302d1a45-dd5d-4d50-a99c-ce73de196d0c@redhat.com> On Tue, Mar 17, 2026 at 03:46:35PM +0100, Paolo Abeni wrote: > On 3/14/26 1:00 AM, Bobby Eshleman wrote: > > tools/testing/selftests/vsock/vmtest.sh | 21 +++++++++++++++++++-- > > 1 file changed, 19 insertions(+), 2 deletions(-) > > > > diff --git a/tools/testing/selftests/vsock/vmtest.sh b/tools/testing/selftests/vsock/vmtest.sh > > index 86e338886b33..c2cfcdf05d99 100755 > > --- a/tools/testing/selftests/vsock/vmtest.sh > > +++ b/tools/testing/selftests/vsock/vmtest.sh > > @@ -42,6 +42,8 @@ readonly KERNEL_CMDLINE="\ > > virtme.ssh virtme_ssh_channel=tcp virtme_ssh_user=$USER \ > > " > > readonly LOG=$(mktemp /tmp/vsock_vmtest_XXXX.log) > > +readonly TEST_HOME=$(mktemp -d /tmp/vmtest_home_XXXX) > > shellcheck complains: > > In vmtest.sh line 45: > readonly TEST_HOME=$(mktemp -d /tmp/vmtest_home_XXXX) > ^-------^ SC2155 (warning): Declare and assign separately to > avoid masking return values. > > > @@ -451,11 +464,14 @@ vm_start() { > > --run \ > > ${kernel_opt} \ > > ${verbose_opt} \ > > + --rwdir=/root=${TEST_HOME} \ > > And here, too: > > In vmtest.sh line 467: > --rwdir=/root=${TEST_HOME} \ > ^----------^ SC2086 (info): Double quote > to prevent globbing and word splitting. > > Did you mean: > --rwdir=/root="${TEST_HOME}" \ > > The first occurrence could possibly be explicitly silenced explicitly, > but it's probably better to really address the latter. > > /P > > That makes sense, fixing both and resending now. Thanks, Bobby