From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 325B2322B88 for ; Wed, 18 Mar 2026 10:21:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773829315; cv=none; b=b2Y0h/Scm98weSoUcUCWkjLaXJv9utOaaXIhbpa7MC19+16wsYk5UmapDiXab3q43qTTlmbVTK5g3IJBOPoVMWWx1CEccZRcUn/tBN7IeRGDPS9DPSTTx4ME8Rb0jyWOxgzxKJlOl3GN8shL1cEOEQOtICq8NEh+FluJnOKNKog= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773829315; c=relaxed/simple; bh=f4fwKcrrdJQtXSwhDD2JrNNwMmMIJooYagAutI0FRX8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=c/wLUP8XwOWoAA6bP2+f3MNyC4R02j0kSXDPPYkHpiyCHbg/AyjFID6ilnMEuF2idL28X9lndQeZvXUBjulYf2+mFrF3Zb4c6WjqqvlhGw7KyVXLdaYmnPgy0q+OegWFECLmLJ7aZlzHbsViFQeyAD1yYvyh05EXjh4iKU6UaSE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=mRO2kadJ; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="mRO2kadJ" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-35ba2ae4df3so2099388a91.2 for ; Wed, 18 Mar 2026 03:21:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1773829313; x=1774434113; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qW/HtjzV8WdcLRBcHrmOTY12iTWbgQKE1pQl0yEikjc=; b=mRO2kadJqEjubomILI4JW9UOaku9+TirWmnMeTXy+qYip1bwLmQMITMUObGsc1eiNS jJCJYmRO4WreD4qQ9jdowHK4yuke8Mi9LFfiHl8t6E7sMw/dPMzkZmYEzQ5pKPqacpsO VbBiJvOYd3H4kncP1r+NXWsal/YL9+51LNpy8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829313; x=1774434113; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qW/HtjzV8WdcLRBcHrmOTY12iTWbgQKE1pQl0yEikjc=; b=NLKMNGd+ooQfa/9gLvq5sb/dhWfnLtJ8k298W0r3TxyeMu8Q6r9kA56emm2v5RGFF/ aUzWlOGuveuydKH9HIMGEjjQ2iD5WgHJbEMlP6EFVYtTcGSz8xRUxLvtBGp1R718TaGD igNrjhSPYQKVR16HSjG3qC+VTSA706Zt1EqwhfUn1K8qgrhy4sZ54vAa07JQDoWdIM51 KYTMuYAOV49GXGsr1nhfiIc0Fh1jFbmbUFpRmHz7Hrk/UChpoUZvCduyOQSiI6xDfE2M ghOJvv7rkHZXMdmzzWnMLKcnTYfvVLJDZB8pasvYSZ9TfBWLtE0conZOSj9Ut4HYXsWp nvgA== X-Forwarded-Encrypted: i=1; AJvYcCWPuvUdndexSj2xhBpec7O98P9ZBpD7IfUINkPOS6LA2M8dD7bZYfiXiWOtraZmXFxydFNzQWQrDrwQ+hY=@vger.kernel.org X-Gm-Message-State: AOJu0YzZX3SGTCXwnKx6byhjkZd2ei9nw/kpF2Y9YtX4KFGyKI1UqoH7 gt0+aINYSdyhNvReP54UP1ub96cbQzPelepUROEUQGYQ4VRXgj6mPdi4PWEA5UTunQ== X-Gm-Gg: ATEYQzxTDLDSf9asPEdK6ZdL1/IrmtZSW/BC6/mgYfT5/Fm3st/hkBZhJw5+e57Yy1l O5lIb4OX8yeiTSdWRmgIDqSg2gW8ucLBodhsrMQf2uftWYLMgGlyzmt9WkxovUrawq8lPYLNh1I 3rjFEVBq3VhRSuZFfvK5WqM2xGSaHbvEzrcLTdF/wsiA3wF96YYxvOeX/ZJNYlD4eC992U1uLXk CHDEct+XPRFXjj4TeRYOyQ78r4t2qcD1iYmiuPcH91ruBWVyp7bxiZuOUVAqbrv+ROmUhRK6QVD uiiPyRECEAoMXxZfNdL9pTCIiIHeixB8WKniUdw1YFPewvCKwvwZZKolcXVC6MueurDTTgc+nvd 6KXJoVNiz36azYSF2cDBqlZqwR1D0VZv5cBGAp21MpcdC9OI1UKxb9xzx17He15De2COrCEy+gL iREd68rnhRQPGXdAehFsKRjQI7PtBK3/zqksbivBZ3/C/zcVltgLnN7qKJkN1+LaCbWyciqQ== X-Received: by 2002:a17:90b:3c85:b0:359:fd9a:c513 with SMTP id 98e67ed59e1d1-35bb9f0f6b8mr2541663a91.24.1773829313412; Wed, 18 Mar 2026 03:21:53 -0700 (PDT) Received: from google.com ([2a00:79e0:2031:6:2eae:ed87:1d:8a5]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c741e545d38sm2039576a12.19.2026.03.18.03.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 03:21:52 -0700 (PDT) Date: Wed, 18 Mar 2026 19:21:48 +0900 From: Sergey Senozhatsky To: Hui Zhu Cc: Minchan Kim , Sergey Senozhatsky , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, teawater Subject: Re: [PATCH] zsmalloc: return -EAGAIN for zspage migration lock contention Message-ID: References: <20260318073114.34858-1-hui.zhu@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260318073114.34858-1-hui.zhu@linux.dev> On (26/03/18 15:31), Hui Zhu wrote: > movable_operations::migrate_page() should return -EAGAIN for temporary > migration failures so the migration core can retry. Other negative > errors are treated as permanent failures. > > zs_page_migrate() currently returns -EINVAL when zspage_write_trylock() > fails. That path reflects transient lock contention, not invalid input. > Returning -EINVAL misclassifies the failure and can reduce migration > success under contention. The zspage's reader-lock owner can be preempted for unknown duration, so I don't know if returning -EAGAIN is safe. On one hand, migration attempts are limited by NR_MAX_MIGRATE_PAGES_RETRY, on the other hand, those attempts are performed basically immediately (?), I'm not sure if we have good chances for preempted reader-lock owner to get scheduled and release the lock in time.