From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9CB4D3D34AE for ; Wed, 18 Mar 2026 11:58:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=63.228.1.57 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773835106; cv=none; b=g448t1ye8G/QxJ1khkmfjzinAsxwtl5qJFZuh1UcBoxA7nmMYVlzfs4hbEkKnIvZvRVyrcn1Av2k5rGdct9Kbfy6vmy3CFDaQZ5Kn1fnU5iPBc7FZqHpLHhYYMdDJ8nUA2DdF1v6P0XndxXMfB0BaDK4BZF2b/8md+HkLXbODc0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773835106; c=relaxed/simple; bh=yoooEs//GPJ/PF++t092q8wkbjRyD1lfx/6xw0QEA2o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XSGpHO1fV39HHekPP0tV6Pn51sr4AN/bLI14R6+eNWftWWE51x+NaKuvRYL6F/Uilizv0XLB+scAJxyFeRV8y7kQb/1k6cM4qW9ZbRBcxrCuyZT48MgXd3Y2JZEmZHTv22wEt9FBRuuYOf45gCWHgOaMgJ+eoG5nKaCZRgPMO98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org; spf=pass smtp.mailfrom=kernel.crashing.org; arc=none smtp.client-ip=63.228.1.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost [127.0.0.1]) by gate.crashing.org (8.18.1/8.18.1/Debian-2) with ESMTP id 62IBw0VZ966706; Wed, 18 Mar 2026 06:58:00 -0500 Received: (from segher@localhost) by gate.crashing.org (8.18.1/8.18.1/Submit) id 62IBw0G0966705; Wed, 18 Mar 2026 06:58:00 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Wed, 18 Mar 2026 06:58:00 -0500 From: Segher Boessenkool To: Krzysztof Kozlowski Cc: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Geoff Levand , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment Message-ID: References: <20260317130823.240279-3-krzysztof.kozlowski@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 18, 2026 at 12:54:30PM +0100, Krzysztof Kozlowski wrote: > On 18/03/2026 12:51, Segher Boessenkool wrote: > > On Tue, Mar 17, 2026 at 02:08:24PM +0100, Krzysztof Kozlowski wrote: > >> Return value of ps3_start_probe_thread() is not used, so code can be > >> simplified to fix W=1 clang warnings: > >> > >> arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable] > > > > And this is exactly why -Werror is harmful. A boring harmless warning > > turned into a build break :-( > > -Werror does not matter here. We do not want warnings either, assuming > of course they are correct. > > So if this warning is correct, then patch should be applied and WERROR > is irrelevant. The build is broken. -Werror is positively harmful. Yes, you want the warnings fixed, but maybe something else has priority right now? Segher