From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 89E5136B058 for ; Wed, 18 Mar 2026 12:13:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=63.228.1.57 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773835989; cv=none; b=SYU0p9rd+E5wSFT7G+1VTtjhf1Roh+oUAr57CYuN4Zbb//GWziqmT3oaKWVPHhayhjlZ0oumP5nj9pRg8kGSM5O76HSqDM6r/6BQzhpOvxJ8ta3r4vk/MWTmNOPN43laswoAeH6g+BkRWbOWtXFRMamgHjXBP5ZwD0xXsfW5mZk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773835989; c=relaxed/simple; bh=vMM965T9bjJMAbkNXqh/aVOZLqcM/99LzQNb+7dO4l4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UbqXwL426Pogms+3CAjY8X1bGow4wg1uXsDJtMmroH5vOgvxeY2aRPO7Tem4spHx8AW8IUIsq9QAy/Hz2m8fySLLpmvjgQ8Rkaf/PMCee1xph6d4lmVzRLkxHKg3p+rjpA6B+u0RUIFuU5300YaAvFlY9NkwGiekCjWBbVWfsDM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org; spf=pass smtp.mailfrom=kernel.crashing.org; arc=none smtp.client-ip=63.228.1.57 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.crashing.org Received: from gate.crashing.org (localhost [127.0.0.1]) by gate.crashing.org (8.18.1/8.18.1/Debian-2) with ESMTP id 62ICCjZ6969638; Wed, 18 Mar 2026 07:12:45 -0500 Received: (from segher@localhost) by gate.crashing.org (8.18.1/8.18.1/Submit) id 62ICCi6v969637; Wed, 18 Mar 2026 07:12:44 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Wed, 18 Mar 2026 07:12:44 -0500 From: Segher Boessenkool To: Krzysztof Kozlowski Cc: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Geoff Levand , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment Message-ID: References: <20260317130823.240279-3-krzysztof.kozlowski@oss.qualcomm.com> <42b99f91-02bc-4062-93ad-02db3fe81b49@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42b99f91-02bc-4062-93ad-02db3fe81b49@oss.qualcomm.com> On Wed, Mar 18, 2026 at 01:03:03PM +0100, Krzysztof Kozlowski wrote: > On 18/03/2026 12:58, Segher Boessenkool wrote: > > On Wed, Mar 18, 2026 at 12:54:30PM +0100, Krzysztof Kozlowski wrote: > >> On 18/03/2026 12:51, Segher Boessenkool wrote: > >>> On Tue, Mar 17, 2026 at 02:08:24PM +0100, Krzysztof Kozlowski wrote: > >>>> Return value of ps3_start_probe_thread() is not used, so code can be > >>>> simplified to fix W=1 clang warnings: > >>>> > >>>> arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable] > >>> > >>> And this is exactly why -Werror is harmful. A boring harmless warning > >>> turned into a build break :-( > >> > >> -Werror does not matter here. We do not want warnings either, assuming > >> of course they are correct. > >> > >> So if this warning is correct, then patch should be applied and WERROR > >> is irrelevant. > > > > The build is broken. -Werror is positively harmful. > > > > Yes, you want the warnings fixed, but maybe something else has priority > > right now? > > What do you mean? This is waiting on the list for long time - note that > it is a resend - so if warning is correct, for how long it should wait > to get to the "priority" box? > > And why anything needs even the priority here? Why priority has to be > discussed, especially for some legacy (I think?) code? Why correct > patches cannot be simply applied after some time/review? It is totally simple: without -Werror, you can build a kernel. With it, you cannot. The ***warning*** is correct, there is something in the code that can be improved. That is why such things are warnings: the compiler can produce useful output, there is no reason to scream bloody murder. The main reason some people like -Werror is because they are too lazy to look at the warning messages they get from normal builds. Such developers need potty training, this is not a reason to punish all more reasonable people! Segher