From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D228A33121E for ; Wed, 18 Mar 2026 17:06:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773853567; cv=none; b=RmxLzR2izo9URb0EJ3T5j8qXWi1VeZaoA2UDtAuanryI1n9Uy9mNZctD1cTpCTSoPeXmofCcGvnu0HDBJvQYlp1mzpoewFTsvMV+TMmfDbk1j9MN+7enbEKDrLtNEVFwMRUNA+K5VDW5sWQtknH4Eo+RajaXOgeIm84LDT6DTjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773853567; c=relaxed/simple; bh=/aXcXwHYVIx08CpLNNgdY9gTrGn3SvSSy/SIGzOPCrM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dz9oy9ihaGciOYLEzvwiLAgRX8vlsJQ8qynCLB7mTQSDD6xeoy48+m21bUVo5yJUR6vu6z1O2OOxpnsIxSBQ5V2mX86aTOWRtO23wcJzw+5OntOfBIcIR49lGji/0uN5f0cr7Am1chNPQv3vKlP61zb0yoQPP7e2ar+ysOfXsB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=NvK93zHK; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=SUEhWyop; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NvK93zHK"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="SUEhWyop" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773853565; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6hq+sfehTUwcDaYBmOxEPMrx/kSMTzZMUDBJYS3i4YM=; b=NvK93zHK04bN/z1DgmGLQvJG/v/B8o1Ipe4C4Sftnz1jLYkUCt9hfpzkwv0fjYvxfQB8Dv EhOkAntmPW1SQGwWHvaMrJUV30eq907Ja1uEML5wMSQZL8jH4ET/NrEYy1sXG24JwEd+LA pEtETTxIaQMTngL2cmcYPBDS6xT8nUM= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-255-KTxkTe6SMHiYufOM1WNWzQ-1; Wed, 18 Mar 2026 13:06:02 -0400 X-MC-Unique: KTxkTe6SMHiYufOM1WNWzQ-1 X-Mimecast-MFC-AGG-ID: KTxkTe6SMHiYufOM1WNWzQ_1773853562 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd773dd39bso76972185a.2 for ; Wed, 18 Mar 2026 10:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773853562; x=1774458362; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=6hq+sfehTUwcDaYBmOxEPMrx/kSMTzZMUDBJYS3i4YM=; b=SUEhWyopf6EBoPLLeoihJ+YoAOxPQ81aoxeU5+ydX+umbxGuD0PsMUPRAf6NnMqloh kstXkbMqzOFLcmuVCQkMaTbnYfmxvGs+n8Ud8JC5eIudBq7uRETT/dRkbfNiP6XHGrK2 xGLm+6+NdHpH92s20wiJzhO3g98DFGt98LjN64aoaYKQR8Gu4XCtAXsfvA008cjM+LRA 9foepCthRopflQFZc1tPWZdswZxPPKUmb1eVZx7RebfR4xuhUHYUU4LznBtgPqqmaHNa sfjJk++aacEeKQ29l7K0SBgBEG4CGFG4nb8rrg1bMUuF6FaCp98KNcr+BoFke8tU0aGA T6Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773853562; x=1774458362; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6hq+sfehTUwcDaYBmOxEPMrx/kSMTzZMUDBJYS3i4YM=; b=rX/5+wsoCQ5QNNDF2MyxzDVYvlKMMfCR/03wpGI8fAtoSaVADhs2rx/PAygLp2XBQS c/svTU4QvEpvMCfoqrPwBAnv/2Z5ssq16rwIHrT+tD6Eo38fVcRXZsJnoFXZQOmnUI5S 4B372VASfz++S4eyLiPvRbswL/uWuWnwgzgfmkP1jMk5idFquiU10UJl6nlgzUpsKjrA Ije4orANWxvJYmR9d4R/VbplGFK76RtPolLFsjPTD1DMkU1zuCUV29W8g9VEiKi8Tyqp e+x7OFowLrxHIbEc+NjjEruiIAeK1xLObEKBSF5Mt7QS0BAOHU/J41OZAZb8McJQ5RKX E9kw== X-Forwarded-Encrypted: i=1; AJvYcCXk+7yTEKK+Q5BMTqoXqBUSN9lksQvQkwre+g9z6aEG2zckB2wp2Bn0kH//ruMw7svNyZjHd1NUA6U159A=@vger.kernel.org X-Gm-Message-State: AOJu0YwDX75NJOwTC8UldGfntZ9SNCDeYOFN5RS15YY8kieMgppF1Odp GD0dAU6PECARke7cvsBQx1MQ478tGMcwycoYAnxrEs3l5RyN3rM1JQz5kGGn4z/0ZsHHHH7+bXU 6cZquE4yxA0gtxRKV++P5YXClWYayYr1orXOykvFZfXpWAbl1rW7EzhJvyZ2fqDvU/Q== X-Gm-Gg: ATEYQzyHJHE6iKIKTaFhY9MMh9HfIachxz+q1xGVggNHgtWM5mwVQ3pLjpo8mnAjuB8 oaNmfkPBdEksZK6rBlCcBFVS5EI6y2OjeiIgBkyLujPrTwB6atXkUC5FqiRV33fqd4hL+CIuXdP ZIxYhblYfRTsgO/d/llnqC6GyOq/dHagzuDjzor8/GWSiE/o8gpGnZ4fJuCuhf2HfzP1m+Ur8tj /nayq7DN2Ge/LqS6QHY35ZYurpc7qqxv2Fff19iZBJxZAm1s7RJ3LKY4otQUV7EXyNrK9FFDNzm 0Gx+HhbhOpuUpOX7SQRwqt9hRGDxYB0l+NUoyiBYAmoJTXcIb0PIFckslOabO05Xby68rstbLR9 DAq1mnTu1CAFO6aI= X-Received: by 2002:a05:620a:c4e:b0:8cd:b5f2:3b4e with SMTP id af79cd13be357-8cfad319e43mr605999485a.44.1773853562062; Wed, 18 Mar 2026 10:06:02 -0700 (PDT) X-Received: by 2002:a05:620a:c4e:b0:8cd:b5f2:3b4e with SMTP id af79cd13be357-8cfad319e43mr605991385a.44.1773853561446; Wed, 18 Mar 2026 10:06:01 -0700 (PDT) Received: from redhat.com ([23.25.77.22]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cfad167ee1sm261115785a.28.2026.03.18.10.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 10:06:00 -0700 (PDT) Date: Wed, 18 Mar 2026 13:05:59 -0400 From: Brian Masney To: Anas Iqbal Cc: mturquette@baylibre.com, sboyd@kernel.org, linux-clk@vger.kernel.org, hayashi.kunihiko@socionext.com, mhiramat@kernel.org, yamada.masahiro@socionext.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: uniphier: mux: fix signedness bug in get_parent Message-ID: References: <20260318110251.2412-1-mohd.abd.6602@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260318110251.2412-1-mohd.abd.6602@gmail.com> User-Agent: Mutt/2.3.0 (2026-01-25) On Wed, Mar 18, 2026 at 11:02:51AM +0000, Anas Iqbal wrote: > The uniphier_clk_mux_get_parent() function returns a u8, but > propagates negative error codes such as -EINVAL and regmap_read() > failures. These values are implicitly converted to large unsigned > integers, resulting in invalid parent indices. > > The clk_ops.get_parent() callback is expected to return a valid > parent index and does not support error codes. Fix this by returning > 0 as a safe fallback in error cases. > > Fixes: 734d82f4a678 ("clk: uniphier: add core support code for UniPhier clock driver") > Signed-off-by: Anas Iqbal Reviewed-by: Brian Masney