From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA502355F2E for ; Wed, 18 Mar 2026 17:49:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773856166; cv=none; b=lz4coeKdJWlY8um8DKjNPTxZ9tQfU53r3azXoGd3fTwBCfCuamXEZuw2Ko7NzkqpcRHGgK/wDhK0L56bZz7rPiSJaPjG2xQI4l850My/TnPy21b/m7yj6zDMlFzG9kQbIiQG0mkTsByA8BbPN96kc/wWs8RibUtZVnY6wArxYfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773856166; c=relaxed/simple; bh=Y2/o/ebxsdPQbPCrZDWTV82JL/XtU45w5Gvly4ZT4qk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nFGWEezfZLJ28hGitHv+01BGWzsUWn6qaJSzZPtuqdZcL3rcJTnpuwIKGeUIpjCA8mts3sJ1tpIR1MekGBUgX+OzyTI1wtti/N+ghhRdQK8eYXYweEiU1bxp+RBSbfPbcuT9taPIEARu3JFHUHWyIdFBt+jUYs7PWuoxjcJvbGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Xnz98Nui; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Xnz98Nui" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2b052562254so7935ad.0 for ; Wed, 18 Mar 2026 10:49:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1773856165; x=1774460965; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Y2/o/ebxsdPQbPCrZDWTV82JL/XtU45w5Gvly4ZT4qk=; b=Xnz98NuiMHg/pmlDDcEM8Bw+P6M2Wb1pTyk2leV7ytvTOE/hd4kac2zJGA5TM2NTLo QAYzaS4hhwo3WUr30EERqA9U7W7AVimarqr66EThps6b7cvkXTvi6o2uKwYPNo4fQdPc 2ovdtQSzO/jPciiIhDzO/rmUFbQBMWrfwF3JOuhCuXx/VB4IvA+NnDWXsDqgbXIi4YJB Nup6lyK1cJpoWFAh0odagm+D8Abvg8DyEMwfausFDGkF8CzNmwYsmFxG+YMZ81Hv44xS dMR7/wAmEBHbfFI8rlLRWNucwJoG8T/QjkZkImK3dZt9XncdL5lBZMhv8rtlHrezqBm2 nrfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773856165; x=1774460965; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y2/o/ebxsdPQbPCrZDWTV82JL/XtU45w5Gvly4ZT4qk=; b=QNZDgncTIDl/ExFQHG6isq3W4tO35P1NwMu5sLA5J5Z/xph3TLzaEOcDmyzckKQ86a DIZQZP2KdLe5NbMoDVIDFb5efJkp3NyJt38eVV+FM12NWBHQGAoI69/lbcGsbr/GI/lz 62vihxKCSVwicnc4wZnrhzmeGH1y+LHXeNdz2p1/o9X5l9CPXoEsWMxH78L7EZUxSBxx dNi5MCmk/E7RK+hcxy8emKRHAR9Ec2Z/wf+s/1JEjfCAcvZR23lZJH2wxjl3DCH2HIg+ Bh3ApAHM6xmY99cSfrBrDDLo6FZc/1liYPrMZDfHhyG34RsU1cWdN2PxOHL2dcSsgBmM LKbQ== X-Forwarded-Encrypted: i=1; AJvYcCVP4B44Jl4KS8lebPfuwuJH+Os/yTl3XuaGfoiW8l64KZPBlLK9+9NHKgrnmGtdzgl6f31682FF3YVKdmA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/XIiOoT3KI/E2HJSIGPGfvJsMFm/Wed+EDmXyPQmUM3pIB7Pl P/RrfyLX+TWpXAcf+YDz6xZLKm51fBVf/oDrBo53eSWx2t9Pe59opXs7jQUT+c+bWQ== X-Gm-Gg: ATEYQzyurmlxJyO0rG7f6GDnghrxVB1gjvV+6BEHSsUP6sHfjB6xmCc7g7l9eSQOGVI p/8kwhUyNVHi2OrTjki21PkjAjmiohu/Zc+tIHDAoD20ej39n023UHtG3KHQpHSkJUaXWgUI3Gu v3sN4qIjjqvfduxekfY8LNXjBQsAWzyJ9SKrAIFqhB760eBaJYQ8Q7GZiWTcBdz7heAoVXOs1C+ hrUVekWU4jILjzNjoTTomXfK282v6F+R3mJbUe/Sgj6UmN/YvrQX5bWiqjtBj8HQYOTzci0xm23 r3TFVNOfaPCsFG/S73E6JEcHPXXxvZxQTZKc4xAWGtsA59e9pujQrVzRfnGHq0rlN8tYmdUe+i/ 8EZJgjSeJO+h5Y1gs1KvVRkR2P/I3M6ghLChFLWk7zbM8Llb1JB5P3tHUcz4N5+b9sfjM7h3T8y qr9W+NUrhONqbLkNHk7Dix9H1GSBm0znqc2/y3BEOjVP8LzpyvBFB5sZxXr2z3tg== X-Received: by 2002:a17:902:f544:b0:2ae:575f:3755 with SMTP id d9443c01a7336-2b077df8c89mr179905ad.20.1773856164572; Wed, 18 Mar 2026 10:49:24 -0700 (PDT) Received: from google.com (168.136.83.34.bc.googleusercontent.com. [34.83.136.168]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a6bbe6162sm3180791b3a.42.2026.03.18.10.49.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 10:49:23 -0700 (PDT) Date: Wed, 18 Mar 2026 17:49:20 +0000 From: Samiullah Khawaja To: Pranjal Shrivastava Cc: David Woodhouse , Lu Baolu , Joerg Roedel , Will Deacon , Jason Gunthorpe , Robin Murphy , Kevin Tian , Alex Williamson , Shuah Khan , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Saeed Mahameed , Adithya Jayachandran , Parav Pandit , Leon Romanovsky , William Tu , Pratyush Yadav , Pasha Tatashin , David Matlack , Andrew Morton , Chris Li , Vipin Sharma , YiFei Zhu Subject: Re: [PATCH 02/14] iommu: Implement IOMMU core liveupdate skeleton Message-ID: References: <20260203220948.2176157-1-skhawaja@google.com> <20260203220948.2176157-3-skhawaja@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Tue, Mar 17, 2026 at 08:23:38PM +0000, Pranjal Shrivastava wrote: >On Tue, Mar 17, 2026 at 08:13:47PM +0000, Samiullah Khawaja wrote: >> On Tue, Mar 17, 2026 at 08:09:26PM +0000, Pranjal Shrivastava wrote: >> > On Fri, Mar 13, 2026 at 06:42:05PM +0000, Samiullah Khawaja wrote: >> > > On Thu, Mar 12, 2026 at 11:10:36PM +0000, Pranjal Shrivastava wrote: >> > > > On Tue, Feb 03, 2026 at 10:09:36PM +0000, Samiullah Khawaja wrote: >> > > > > +EXPORT_SYMBOL(iommu_get_preserved_data); >> > > > > + >> > >> > Also, I don't see these helpers being used anywhere in this series yet? >> > Should we add them with the phase-2 series? When we actually "Restore" >> > the domain? >> >> Phase 1 does restore the iommu and domains during boot. But the >> iommufd/hwpt state is not restored or re-associated with the restored >> domains. >> >> These helpers are used to fetch the preserved state during boot. >> >> Thanks, >> Sami > >I see these are used in PATCH 8, should we introduce these helpers in >PATCH 8 where we actually use them? As we introduce iommu_restore_domain >in PATCH 8? Agreed. I will move the helper for getting the device state into PATCH 8. But the one that is used to fetch the iommu state is used by the vt-d driver in the PATCH 7. I will add a new patch before PATCH 7 to add that helper. Thanks, Sami > >Thanks, >Praan >