From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30D11191F91 for ; Thu, 19 Mar 2026 01:21:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773883272; cv=none; b=O4UQ75HPv8lD/W1yEvMwGuv4vv97FdYmOfDpzLmSjZswtI2vEGaQLGMJP5Tpu0MkfWUqQG0Izk6UPcoPUO56e3GfO/mUp1ds8kuseqvV7VIEc/1VzvYPWrv7XfXfxxFZ/vudARbjSY9PFdTdTU0GqRsfL44yRuezpLaFA2R3pzM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773883272; c=relaxed/simple; bh=84gYW/Uo5HlFoOmIHeuzWnN+iJV2oC3EBw9QC6bn0BI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FvhfbDlXLXgI/9l06qOBPUxTVlTqpwoHI2FygrVSzFdr7z+Vueg8Ei36yFDlBQMJrXP/SzkcY2v78vclXcJh4XTRT9NpNPodoZEkuQUkJ35xh+Cl85YqwJvhw6dhHrWzWf/x9eRpe8T7qmR/r1ERZEyADvh6JdojGxKO7NS4A+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Qwi20qmM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qwi20qmM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C049C19421; Thu, 19 Mar 2026 01:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773883271; bh=84gYW/Uo5HlFoOmIHeuzWnN+iJV2oC3EBw9QC6bn0BI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qwi20qmM0QoxwjK35gojbtRd+bhEZG2KvQ9CQ4jqbRsvVM0Ook51XQ8rEp0G/Qr3x G/VeeZjTyNLsphPHxRhvcblGhPMiQUaDDuzockL3Jl0D6ikBW41Izei90cVDYE8wXE NjIkYqgvTFKhs6NumJTUD0vQoKM+xd8lxR7ZGS+6om+G7EsAnWPk/kS2eH4FxJZbLI fKdrjECzv65p75IQQ4D0ClwvdzP/vLjTDU9VEK9tmO5RXqZTyflj3N/S9z5GtBkMqj S/rvU7KrPcWQqBBYj2kgEAAR9pGHlxcy0gU47hZFgsyQ5ZQIKBB5T+CTHvUEI/Qj2m uUkHtSaHmdgxA== Date: Wed, 18 Mar 2026 15:21:10 -1000 From: Tejun Heo To: Xuewen Yan Cc: peterz@infradead.org, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, lukasz.luba@arm.com, linux-kernel@vger.kernel.org, rui.zhang@intel.com, di.shen@unisoc.com, ke.wang@unisoc.com, xuewen.yan94@gmail.com Subject: Re: [RFC PATCH] sched: Add scx_cpuperf_target in sched_cpu_util() Message-ID: References: <20260318121755.16354-1-xuewen.yan@unisoc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260318121755.16354-1-xuewen.yan@unisoc.com> On Wed, Mar 18, 2026 at 08:17:55PM +0800, Xuewen Yan wrote: > Recently, while enabling sched-ext debugging, we observed abnormal behavior > in our thermal power_allocator’s temperature control. > Through debugging, we found that the CPU util was too low, causing > the CPU frequency to remain unrestricted. > > This issue stems from the fact that in the sched_cpu_util() function, > when scx is enabled, cpu_util_cfs becomes zero. As a result, > the thermal subsystem perceives an extremely low CPU utilization, > which degrades the effectiveness of the power_allocator’s control. > > To address this, we propose adding scx_cpuperf_target in the sched_cpu_util() > as a replacement for cpu_util_cfs, ensuring that the thermal subsystem receives > accurate load information and restores proper control behavior. > > Reported-by: Di Shen > Signed-off-by: Xuewen Yan Yeah, I missed that path. In either this or Peter's suggested form: Acked-by: Tejun Heo Thanks. -- tejun