From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 928F1481DD for ; Thu, 19 Mar 2026 02:03:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773885784; cv=none; b=ua44+0pWrQQo6p5CpcXcKu5g8MIWe4OZ4vl7QCSi8oWMZvdlnBrt8qBXpZjfUALMk/ecgwCE3idKvkx8T2xCV5/jJBr6zXreX4fjFIP58VIiWfNN8OMxGbMZyUDfUe1L5ORF+AvM5U4s8oBBZSplklWutmfY8NW/wmUCgJvRtgY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773885784; c=relaxed/simple; bh=mKWLwc26UHp0QckseNliuojMeOSjfywUsmMLAQ3UG5A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XyaeL+F6q9Eba8YQA/5FZ6PJfUNFyl5fp4+CZPD94Na5NHSK0LhBGuXXgOW2B+7KBDW7Y5Z+8cOGoIularmXYk7yGAsEUlfJ4llHXdkv/vci6e+kA76duMcxT/KRc+uAd/GC/iPZ1RZ1UKdwG03V1s5+mLX6rIy6kAPUCESNGLI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kYPNylgt; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kYPNylgt" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-8298fad2063so96502b3a.3 for ; Wed, 18 Mar 2026 19:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773885783; x=1774490583; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ScNRNBIvzfApbX9SKu6wfVyGsSnrc3rMHZZR+kMrCFg=; b=kYPNylgt5whfitfGXzKtRHMm6LAwJxEgkurW+2kprjTnfLLaFez8AHq+f5UQHXPBKL E7/tGxbZWUoeR1s5pfE5P5cql37y/i6IPATX7qU1HBjBZimWdWetKRLCIFnqAR7xIzZA OMerkdsJjs38GT2ij5WyN7gWN7dqSCDYmIFIIeQ5G/h8oEciwCA8XWFv4FhyflXkI6b3 akjQGRL/X8Mb8ubOUHoeJ3AtJa1WD+eiPbxh5M2PRMnorFa2/+kmjuw3PL50rN9KIfTA ib8dWcmBkdnjFsiQ5MOWHoYbIsVrJBDmW8XMEHTRyw/YUHwzay1SegbJ9vd2CiEsui8D 3TkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773885783; x=1774490583; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ScNRNBIvzfApbX9SKu6wfVyGsSnrc3rMHZZR+kMrCFg=; b=c2mjsffSOM4ok9F+W1fiIa9/ONoLfuNiBMnnV9LsS9J1NVCzTcnGMV7X9uu3gKo2zt wzAh2Hrlh8VbVfR/B/sziB3voXir/jqTWBmxoNJ4/Pe4KiywO5U6zPdrL2IND+Q0/wJz RbPfTuVI3SybzxCLelyffBh+l3UjHrHNSxz7BPItmAMOQhqMUisDPVUGfvywHhdQRm5W 4cYwawJywMWtur8rwoT/9F5DDYEh7E9V0K3NZnpvyLZ5HQfHuNKfQnp4oSaND0m27Jfh 2Gh3BES6UoenHe5eDAeYCnPMy/DEb9PwgyBrBshmrzQf9YPWdrKeXSZJN1wsNkDX/owo IhYQ== X-Forwarded-Encrypted: i=1; AJvYcCVL8CZlIL3+u7xnLqNfFSgtT6SCi39ONG2WdFtGk65owVm5/I6B/rWdLhfNq5jzc4XbnOLTn8LRe0uzMk0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzx99wwECl2gaEUHQGP92zYXKWm/kOipUgU4MO23WhT5+dbJVEs oiUy4IrGCosmrwD0FVYpAzPLLjBowFst+hVRkWtPEb16tvi7mBOD2a9P X-Gm-Gg: ATEYQzyzfGgYKH9UWTtxW+XFUxjbFgleM4F7+DU/ZpofwwBudOUZV80QTTMVdYZ3UOZ FWj78+IbOZyqmgCdciizjG/GLGOJWk7KopSPqmX+Jih7jSyGxgIR0FGTIjwbZEzy4ORsM80nyKT PkE1QJtjxFnX6F554dlI8lpV6Q8XtBSjPyBDLEKXGBLE6vgnu9ODpxfyqnycC7d1Y0bzYqUomsg DuJUmtg5vRdwLkI8psXZSR5h7SVDxm5Yo30odo65samHHeWcIX/rFGh6Rhx60ClvBB9ACGqmy1/ s9TXsRXSCgHq5qPsbe0gz5Uq3DkjLWpeuUb/bkjpTWYeJN0aP0uTvcamAKEJjO3pczmeZ4LnDVm yV83Dnu42wzGXVlsG60XciGxK79Bb7F2sXVoRggQ6gkfcgmWZzLOmM3Zoh1+mzAKQ08SCt89LnB YY4wY0IBjlMfQu+YAPw2hKOlnNu0Q= X-Received: by 2002:a05:6a00:17a4:b0:824:36f8:346f with SMTP id d2e1a72fcca58-82a6ae213f7mr5040966b3a.25.1773885782857; Wed, 18 Mar 2026 19:03:02 -0700 (PDT) Received: from fedora ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a6bbe1ffbsm5577164b3a.43.2026.03.18.19.02.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2026 19:03:02 -0700 (PDT) Date: Thu, 19 Mar 2026 02:02:53 +0000 From: Hangbin Liu To: Sabrina Dubroca Cc: Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jiri Pirko , Nikolay Aleksandrov , Ido Schimmel , Simon Horman , Sridhar Samudrala , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bridge@lists.linux.dev Subject: Re: [PATCH net-next v3 1/5] net: add ndo_update_offloads for offload computation Message-ID: References: <20260316-offload_compute-v3-0-a5d4a07d86d3@gmail.com> <20260316-offload_compute-v3-1-a5d4a07d86d3@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Mar 19, 2026 at 12:29:25AM +0100, Sabrina Dubroca wrote: > 2026-03-18, 01:15:20 +0000, Hangbin Liu wrote: > > On Tue, Mar 17, 2026 at 04:14:35PM +0100, Sabrina Dubroca wrote: > > > 2026-03-16, 12:26:09 +0800, Hangbin Liu wrote: > > > > Add a new ndo_update_offloads callback to net_device_ops that allows > > > > devices to compute and update their offload features during feature > > > > updates. > > > > > > > > This callback enables master devices to recompute their features > > > > based on current slave device configuration. This is particularly > > > > useful for bonding, bridging, team, and failover devices that need > > > > to aggregate features from their lower devices. > > > > > > > > The callback is optional and only implemented by devices that need > > > > dynamic offload feature computation. > > > > > > Maybe a dumb idea (and sorry to suggest this quite late in your > > > submissions): since all implementations of this callback are only > > > calling netdev_compute_master_upper_features(), does this need to be a > > > new ndo, or could this be some kind of flag within struct net_device > > > > Ideally all dev with IFF_MASTER should re-compute the offload. But at present > > some master devices do have this flag, or have their own offload > > implementation. > > > > Do you mean add a new private flag, like IFF_RECOMPUTE_OFFLOAD? For the second > > parameter, maybe we can pass false for bridge specifically. > > I hadn't thought specifically about where to store that flag. As a > private flag, why not (this should be internal to the kernel, so not a > uapi flag like IFF_MASTER), but priv_flags is marked as "hotpath" now, > so maybe something similar to needs_free_netdev or > netns_immutable. Either way, then devices are free to do their own > magic, or request the core to call > netdev_compute_master_upper_features() for them in some common > locations. Does that makes sense? This looks better than private flags. I just feel this magic hide a little deep for a common master feature. Thanks Hangbin