Re: [PATCH 2/2] selftests/sched_ext: Return non-zero exit code on test failure

[Andrea Righi <arighi@nvidia.com>]

On Thu, Mar 19, 2026 at 01:30:26PM +0800, zhidao su wrote:
> runner.c always returned 0 regardless of test results.  The kselftest
> framework (tools/testing/selftests/kselftest/runner.sh) invokes the runner
> binary and treats a non-zero exit code as a test failure; with the old
> code, failed sched_ext tests were silently hidden from the parent harness
> even though individual "not ok" TAP lines were emitted.
> 
> Return 1 when at least one test failed, 0 when all tests passed or were
> skipped.
> 
> Signed-off-by: zhidao su <suzhidao@xiaomi.com>

Makes sense.

Acked-by: Andrea Righi <arighi@nvidia.com>

Thanks,
-Andrea

> ---
>  tools/testing/selftests/sched_ext/runner.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/sched_ext/runner.c b/tools/testing/selftests/sched_ext/runner.c
> index 37ad56c3eb29..4c68efa1512a 100644
> --- a/tools/testing/selftests/sched_ext/runner.c
> +++ b/tools/testing/selftests/sched_ext/runner.c
> @@ -217,7 +217,7 @@ int main(int argc, char **argv)
>  			printf("  - %s\n", failed_tests[i]);
>  	}
>  
> -	return 0;
> +	return failed > 0 ? 1 : 0;
>  }
>  
>  void scx_test_register(struct scx_test *test)
> -- 
> 2.43.0
>