From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF3062D640D for ; Thu, 19 Mar 2026 07:11:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773904286; cv=none; b=ZvyVfd1v95Yjv/awc4auw3aornf/KPxmU1EkkZQH4jDRduNka82PcDB38rlz0ngcyIPLH4YGhLB7Ppl5cq50PnGZf3o02okVDnTUpK64ERJV/WHxkMGel6s8KVq5p+tV6yfokj+MOSewp4ruvqPtfse8+2HQCZerjFAuzAVwpKs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773904286; c=relaxed/simple; bh=lofvlVyYDf5X+iBCyNB4BHXd2e12gzy13jWbaSTyehc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EtlyEhao/egFxrhHgdxBlH/tKFGoqT24WVQruzwRs4LuCLiiDLssG5VNPR01mDgsmdUhGulk3vIyeQRi9WwEpOmsgOp0PociPGw2e3c2WY3Pd3Hpmhr8/x5zHI7ItRnqkyI+qn6weTJnBhuK1xDXgEVIYpZ4+w6ZbgqIU9WNbW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=K2j0HfRm; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="K2j0HfRm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773904286; x=1805440286; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=lofvlVyYDf5X+iBCyNB4BHXd2e12gzy13jWbaSTyehc=; b=K2j0HfRm/zVPR4wFqhjlq6/9uYPab3nQZxaAiirmcmJn0vSgZoXT4gjX O9bwdQIUScB0y23ZJwQwwVj3JgR/9maxmIeYOGzpLGfL5Ti+Vzfkip74e RrH76L9So14OTP2/qsqWC+YNmpahqtH0Jl7xiHzsfaJkF/OT2mWaEa1Np ScTHOaYqzdoLw7Vs8g+q/8D06utxmY8EGtPJ6pMRGIZmtsv+YxSShCQ6L 7aAMVI6W0ZLQ+eMb70V7dFQWE18oKuC+DYHsi8pUew+3gKfeJFWN9IMjh Kp99SxvjQ1yVCPVXgYomNejP41vMCq2mb/Mhim1T/4kH9znjz2geBDFmP g==; X-CSE-ConnectionGUID: J6WaBSt5Qu2t69AwyJ2PJw== X-CSE-MsgGUID: I2IeGqyfS2OflD/SZoQ9nw== X-IronPort-AV: E=McAfee;i="6800,10657,11733"; a="85287421" X-IronPort-AV: E=Sophos;i="6.23,128,1770624000"; d="scan'208";a="85287421" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2026 00:11:25 -0700 X-CSE-ConnectionGUID: UECQpvcbSYOvFRo13KKtbg== X-CSE-MsgGUID: SMS6KTnDSYehArTUb2BoLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,128,1770624000"; d="scan'208";a="260773841" Received: from klitkey1-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.120]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2026 00:11:23 -0700 Date: Thu, 19 Mar 2026 09:11:21 +0200 From: Andy Shevchenko To: "Masami Hiramatsu (Google)" Cc: Petr Mladek , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib/vsprintf: Fix to check field_width and precision Message-ID: References: <177388001976.19951.3455192731084870216.stgit@devnote2> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <177388001976.19951.3455192731084870216.stgit@devnote2> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Mar 19, 2026 at 09:26:59AM +0900, Masami Hiramatsu (Google) wrote: > Check the field_width and presition correctly. Previously it depends > on the bitfield conversion from int to check out-of-range error. > However, commit 938df695e98d ("vsprintf: associate the format state > with the format pointer") changed those fields to int. > We need to check the out-of-range correctly without bitfield > conversion. ... > spec->field_width = width; > - if (WARN_ONCE(spec->field_width != width, "field width %d too large", width)) { > + if (WARN_ONCE(spec->field_width > FIELD_WIDTH_MAX || > + spec->field_width < -FIELD_WIDTH_MAX, "field width %d too large", width)) { Also use logical split as below: if (WARN_ONCE(spec->field_width > FIELD_WIDTH_MAX || spec->field_width < -FIELD_WIDTH_MAX, "field width %d too large", width)) { > spec->field_width = clamp(width, -FIELD_WIDTH_MAX, FIELD_WIDTH_MAX); > } > } ... > spec->precision = prec; > - if (WARN_ONCE(spec->precision != prec, "precision %d too large", prec)) { > + if (WARN_ONCE(spec->precision > PRECISION_MAX || spec->precision < 0, > + "precision %d too large", prec)) { > spec->precision = clamp(prec, 0, PRECISION_MAX); > } -- With Best Regards, Andy Shevchenko