From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 147E32E7161 for ; Thu, 19 Mar 2026 18:01:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773943310; cv=none; b=qsSEP+cdBiIYTGHIi6ogiIz8WDOXQo571brTvS0I02XDwBAMElIBRhWftSI17VEpJ8JxFpSEG1yDu5NiVw6PuNVUtXHxLjK+U+pJ2RO2XAFkIkAVv7YTWH6JQu3mamU9R0OgJTNrHE70bZ6kT9knyqhsVLvY8mcJpsRvfQXfn6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773943310; c=relaxed/simple; bh=d8Ua+A/ZmT7ca7E47NnupRZI3JWgVY4ZVGJGbFjL6pM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qcchIlNcPyc+WxmUh50LxQDOgGZl0e9kIOlfj+ANbBBkJSc81X/OrjOYv8rqCrY3g4O/wEINkafRNE/hOZlV/M7BzXGfqdQKXE0p9I/MOHE4RQxgkq7MDQgkvRJV2EJ+qLfPF8QxM3aAbvr5oSgj6rqFroLg8hST3x+TbliAvCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vC8ZbpRC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vC8ZbpRC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19108C19424; Thu, 19 Mar 2026 18:01:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773943309; bh=d8Ua+A/ZmT7ca7E47NnupRZI3JWgVY4ZVGJGbFjL6pM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vC8ZbpRCDasLUGHIy/bphnAPICpvqYVhHZnYtFWNW8grGwKzNgU6HZxuwWk43FoKd O0cegRoluqUInzy3D69im9C70FBrZUu5fhRjy/YDU2gcuEbYTqVadnoyI+0IJwf2sH tMOtJ7Dkrql095BjESNqPG+PBzFOBLZ99lDEBZL/bwzk14UEZ9buqFpOxEdmOQZUCd j5S/UkZNemidFsCodBlc4GWhydx+AnH+gLLrCKKP1fRka9bgiu91qortzioS2wpkll lmYjCkbfKI+vZQS3T9p6+M0puLhw2EmI4pYQfGvsitc2Xyk4eIpvmHONcB2FBwwPxh v5/RLVbLIFmeA== Date: Thu, 19 Mar 2026 20:01:43 +0200 From: Mike Rapoport To: "Guilherme G. Piccoli" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com, kernel@gpiccoli.net, Andrew Morton , Steven Rostedt , SeongJae Park Subject: Re: [PATCH v3 2/2] mm/memblock: Add reserve_mem debugfs info Message-ID: References: <20260318190816.1811325-1-gpiccoli@igalia.com> <20260318190816.1811325-3-gpiccoli@igalia.com> <9066d011-7dd6-4d2e-26b0-72f83d3e5862@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9066d011-7dd6-4d2e-26b0-72f83d3e5862@igalia.com> On Thu, Mar 19, 2026 at 02:14:00PM -0300, Guilherme G. Piccoli wrote: > On 19/03/2026 13:34, Mike Rapoport wrote: > > [...] > >> { > >> - struct dentry *root = debugfs_create_dir("memblock", NULL); > >> - > >> - debugfs_create_file("memory", 0444, root, > >> - &memblock.memory, &memblock_debug_fops); > >> - debugfs_create_file("reserved", 0444, root, > >> - &memblock.reserved, &memblock_debug_fops); > >> #ifdef CONFIG_HAVE_MEMBLOCK_PHYS_MAP > >> debugfs_create_file("physmem", 0444, root, &physmem, > >> &memblock_debug_fops); > >> #endif > >> + debugfs_create_file("memory", 0444, root, > >> + &memblock.memory, &memblock_debug_fops); > >> + debugfs_create_file("reserved", 0444, root, > >> + &memblock.reserved, &memblock_debug_fops); > > > > No need to move these after PHYS_MAP attribute > > > > OK, your call, will change it in the respin as well. > Thanks, That's actually more of a rule in the kernel: don't introduce unnecessary changes :) > Guilherme > -- Sincerely yours, Mike.