From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B94B22C21C1 for ; Thu, 19 Mar 2026 14:06:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773929200; cv=none; b=UFgZf+kgP9SQpnm6tC5TbbBS4xrqowYXB/w/yzkpe1oGYFx9HxZhD65oe39huxXaUTAgebIuMQejVCVLGHhNQvijPQBKCoSMKFOKoVZRRIqRXslWifzthVEA0/FyWYft7K7u4XGAd1QC6+74IKAVJvEydduJiyebhes+I0AaRMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773929200; c=relaxed/simple; bh=LeYbxgchomL/v7yBIeu+qbW+oFzjbgmbldcN8JSrBR0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VG+ionfWQO32jrNu9mtJuXCQnKKmOoiZddb6fdmOOPBkaUnGkVgv23Gb8x9iGpqsNkrsYLzJQDhiI2/K+2mmrF7Rs59qi44JnFGYvlaSwp/TTd0S01Bxu+FMxdpP4ZPZObVLt+O+Wb22ODlgMfal7lnkxsz/NRCcAnyorrjr1+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Yn22sdbI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Yn22sdbI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D203DC4AF0B; Thu, 19 Mar 2026 14:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773929200; bh=LeYbxgchomL/v7yBIeu+qbW+oFzjbgmbldcN8JSrBR0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Yn22sdbIkDRmWlY3l+EaPExzYlQEkouKkvgpHuIWTcySETcjKgUAaeXpJqUnnYLCn C3dhlQ55qo3gejaPek169+1jeNKQ0ofSiP31TV5i5d8bslcYzXxFkg1vnGBnYfn2Dh zP2KIzOo5q6fLN7oQAoypPRrUskDUgfuj5ivhvEmqPy49Lu/ZWVQyr5tURtREQV3p+ G0uGdLIi3yeKt66UwsQXR9foCkJSVkkLg/6rCwk913zD9j2EEu89gLeKTvXO/ci+bz /YOeHugl9uFGYW4/ZroYv6o8WYwRZqReW42ppycbb5TtrsIepFGPEEJclYvw+6EpUk AznWmoRv2ER7Q== Received: from phl-compute-11.internal (phl-compute-11.internal [10.202.2.51]) by mailfauth.phl.internal (Postfix) with ESMTP id 9BD79F40068; Thu, 19 Mar 2026 10:06:38 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Thu, 19 Mar 2026 10:06:38 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeftdejvdduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepmfhirhihlhcu ufhhuhhtshgvmhgruhcuoehkrghssehkvghrnhgvlhdrohhrgheqnecuggftrfgrthhtvg hrnhepueeijeeiffekheeffffftdekleefleehhfefhfduheejhedvffeluedvudefgfek necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepkhhirh hilhhlodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdduieduudeivdeiheeh qddvkeeggeegjedvkedqkhgrsheppehkvghrnhgvlhdrohhrghesshhhuhhtvghmohhvrd hnrghmvgdpnhgspghrtghpthhtohephedtpdhmohguvgepshhmthhpohhuthdprhgtphht thhopegthhgrohdrghgrohesihhnthgvlhdrtghomhdprhgtphhtthhopehlihhnuhigqd hkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihhnuhig qdgtohgtoheslhhishhtshdrlhhinhhugidruggvvhdprhgtphhtthhopehkvhhmsehvgh gvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepsghinhgsihhnrdifuheslhhinhhu gidrihhnthgvlhdrtghomhdprhgtphhtthhopegurghnrdhjrdifihhllhhirghmshesih hnthgvlhdrtghomhdprhgtphhtthhopegurghvvgdrhhgrnhhsvghnsehlihhnuhigrdhi nhhtvghlrdgtohhmpdhrtghpthhtohepihhrrgdrfigvihhnhiesihhnthgvlhdrtghomh dprhgtphhtthhopehkrghirdhhuhgrnhhgsehinhhtvghlrdgtohhm X-ME-Proxy: Feedback-ID: i10464835:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 Mar 2026 10:06:37 -0400 (EDT) Date: Thu, 19 Mar 2026 14:06:36 +0000 From: Kiryl Shutsemau To: Chao Gao Cc: linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, kvm@vger.kernel.org, binbin.wu@linux.intel.com, dan.j.williams@intel.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, kai.huang@intel.com, nik.borisov@suse.com, paulmck@kernel.org, pbonzini@redhat.com, reinette.chatre@intel.com, rick.p.edgecombe@intel.com, sagis@google.com, seanjc@google.com, tony.lindgren@linux.intel.com, vannapurve@google.com, vishal.l.verma@intel.com, yilun.xu@linux.intel.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v5 22/22] x86/virt/seamldr: Log TDX module update failures Message-ID: References: <20260315135920.354657-1-chao.gao@intel.com> <20260315135920.354657-23-chao.gao@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260315135920.354657-23-chao.gao@intel.com> On Sun, Mar 15, 2026 at 06:58:42AM -0700, Chao Gao wrote: > diff --git a/arch/x86/virt/vmx/tdx/seamldr.c b/arch/x86/virt/vmx/tdx/seamldr.c > index e6b7af410c54..4e1ad06506cc 100644 > --- a/arch/x86/virt/vmx/tdx/seamldr.c > +++ b/arch/x86/virt/vmx/tdx/seamldr.c > @@ -222,6 +222,11 @@ static void ack_state(void) > set_target_state(update_data.state + 1); > } > > +static void print_update_failure_message(void) > +{ > + pr_err_once("update failed, SEAMCALLs will report failure until TDs killed\n"); Is it useful to indicate which step has failed? > -- Kiryl Shutsemau / Kirill A. Shutemov