From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b6-smtp.messagingengine.com (fhigh-b6-smtp.messagingengine.com [202.12.124.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D3D73D904B for ; Thu, 19 Mar 2026 16:52:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939165; cv=none; b=A0RxwAJI6NMbLFHGsLOcdzvkNqmT8ruIe9/ao0nuiyuVeanTMY4hy2JcsE8ZGLhht7NOIfh71gNqcEcUaNzBo8YhISC1w6tlXcYHUlXQbNAI63nOZIWGfwl7x+itH/GEu9GuGChNaymg72giwXXF0F5aLf1prIHC2lTuAYVZe1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773939165; c=relaxed/simple; bh=MfM1El4MfmNpnFAxr0PUSwXrupaQmrb3GcbTqjhqu0k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fUBBg+5Val5BiI6Wlfe47AWM5VCTlmqSG4zFikC3JrEhse4MCPbOPQ7Yzqmc1MLftju0R/7NdRAQ5gZO2gp6lCOJZlnYop12X2Obl/73dxv+mrhqfnHjx4dTs5Rw7BPUdAfQky+igktuuG4U1WJg6ZBWxFAqsgnjOnsURDJLpMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name; spf=pass smtp.mailfrom=shutemov.name; dkim=pass (2048-bit key) header.d=shutemov.name header.i=@shutemov.name header.b=pZMPNeZm; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=p5ZGcl5i; arc=none smtp.client-ip=202.12.124.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shutemov.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=shutemov.name header.i=@shutemov.name header.b="pZMPNeZm"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="p5ZGcl5i" Received: from phl-compute-12.internal (phl-compute-12.internal [10.202.2.52]) by mailfhigh.stl.internal (Postfix) with ESMTP id E95C67A0023; Thu, 19 Mar 2026 12:52:39 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-12.internal (MEProxy); Thu, 19 Mar 2026 12:52:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1773939159; x= 1774025559; bh=NiY88PiTkAC1sq3eRtNxrpg4KxKs+Hr6MzSOzgCjoJM=; b=p ZMPNeZmnV90bEtC6oitocToIkV4IIZ/dROfM/0KJPQXZZcjiK/Ut/sIt2LetOsVe gg3YcpJjUvDUr50nZEmQAxzPOVmi05ocUAsgvA6fngkkNrBWPCTfoOJDpizIrDu5 Lvh6SZA5sb5BWztQqKbgRJtFiKVpoqsgwnWOD+XmcdR/cawS5tYD98AAbMYIAZY0 D3hD/6QnbCvAQdl/+dd/1W3x4lAdQ5gqUpfUT0eIEMMMhXVmVZRtvb9UlZwxCW+g DzEnMGPJLwCGQXEtJ+1R8xTF10Lml2OSPlPJm4aXlso5mDwr88H0qqKU6Grqlb45 wL5Jok9LqlAO7/7xakRjA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1773939159; x=1774025559; bh=NiY88PiTkAC1sq3eRtNxrpg4KxKs+Hr6MzS OzgCjoJM=; b=p5ZGcl5i5s0qGdFJSzKRCqdSkG+0r86q71emte4hVwMHE9kga32 YgJM1FY8xEOfpH03WDpxDSKEDiEiCXyTk11V14VMn9Bh95sfndXOeDyCa161HL+M 0Kfsg2gFwj9d6nIdllCRomdGnTSgpoU4qLw2oyjDct8bZWGIkoHlHcrIYPgyGy0m le/v7fdlkTujWknTLC5d4yKtlirokiJwur9tlkbvO6lFCjcczseC6pGIevfU4lKV o0gVLe56M2K1IZzFao0BhJgMXnydODTczPPV9L1r2TQh8Vvi0Hzmo5UmgsdMv/+P SChijFgeF1X6O0Tc2ZC4k93s5lxo91lq5iA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeftdejheegucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepmfhirhihlhcu ufhhuhhtshgvmhgruhcuoehkihhrihhllhesshhhuhhtvghmohhvrdhnrghmvgeqnecugg ftrfgrthhtvghrnhepfeetheejudeujeeikeetudelvdevkeefuddtkedvtdehtdetieeu ieetjeeugedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepkhhirhhilhhlsehshhhuthgvmhhovhdrnhgrmhgvpdhnsggprhgtphhtthhopeef gedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheplhhjsheskhgvrhhnvghlrdhorh hgpdhrtghpthhtoheprghkphhmsehlihhnuhigqdhfohhunhgurghtihhonhdrohhrghdp rhgtphhtthhopegurghvihgusehkvghrnhgvlhdrohhrghdprhgtphhtthhopeiiihihse hnvhhiughirgdrtghomhdprhgtphhtthhopegsrgholhhinhdrfigrnhhgsehlihhnuhig rdgrlhhisggrsggrrdgtohhmpdhrtghpthhtoheplhhirghmrdhhohiflhgvthhtsehorh grtghlvgdrtghomhdprhgtphhtthhopehnphgrtghhvgesrhgvughhrghtrdgtohhmpdhr tghpthhtoheprhihrghnrdhrohgsvghrthhssegrrhhmrdgtohhmpdhrtghpthhtohepug gvvhdrjhgrihhnsegrrhhmrdgtohhm X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 Mar 2026 12:52:36 -0400 (EDT) Date: Thu, 19 Mar 2026 16:52:31 +0000 From: Kiryl Shutsemau To: "Lorenzo Stoakes (Oracle)" Cc: Andrew Morton , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/9] mm/huge_memory: simplify vma_is_specal_huge() Message-ID: References: <613669b1b2082d34f5632907003ae3874eff2ed9.1773924928.git.ljs@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <613669b1b2082d34f5632907003ae3874eff2ed9.1773924928.git.ljs@kernel.org> On Thu, Mar 19, 2026 at 01:00:07PM +0000, Lorenzo Stoakes (Oracle) wrote: > This function is confused - it overloads the term 'special' yet again, > checks for DAX but in many cases the code explicitly excludes DAX before > invoking the predicate. > > It also unnecessarily checks for vma->vm_file - this has to be present for > a driver to have set VMA_MIXEDMAP_BIT or VMA_PFNMAP_BIT. What enforces this? -- Kiryl Shutsemau / Kirill A. Shutemov