From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 273A1318EF6 for ; Thu, 19 Mar 2026 17:12:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773940333; cv=none; b=H2H8QMYUvShn2y0jgruOPDSwwBZ2Mskp7tpLO7eGG9mAP1MaUy1FfUu6QlggWve4O+hHlDkAleNW6yJYPUiybf0C7t/4eLogZ59Qk9QabULTP+iIcJA/8QbLTupGQeXpT4j+mGa9jAKXn4JTmcVEnOIMLbnUJ5+MV/fi/jcWems= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773940333; c=relaxed/simple; bh=IR7aGQP6H1FkNuTxwHCiSTpeXnyxBpufz3KqtwJQe/Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pNfpuWZCFwRqep1TiehrPZhuEL+a992f811d6Vqy1JCO25q8Z1jiTZDtGXoHUZrqHh/4BXYRCBg/+h54aSlPZPSkJ5pvpwFI2NYdV7bAIJE602DGnRbXuDloGDx1YiZchPpv3/HU2/nqXt+IR2u+m3njhIXzYgxYr1BFRx2rSfc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=zWWlDmgs; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="zWWlDmgs" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c06cb8004e8so390552a12.0 for ; Thu, 19 Mar 2026 10:12:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1773940331; x=1774545131; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=CsJ0AYkPM8aVbL469BrHhoEE4ftXbii6Ku5SbAJ3B2M=; b=zWWlDmgsKkWX4pFGwjOCspH8I6eTa8lIrr1xj3nINPw4RiMwirHI9zbT+PT1YG1aza HdhNZKI9ONB4TvDeSl3wS182OmeS31nQOEP9CLAH4F1ScQ/EOOO108W0E+kNuS0W8l+n 1r8tG36et45S6wVTHI0lAdpfBwbkiXjLi/1Hz8CUhDHQ1ASlKB2awaK2bht3MkHMwqzF J5jvelKc0X0jy9WShVY1UMPC36KL9C4g7z65QkY/zq+VKMPTzzk6doORfP2WwCit6UKg r4cqZGCnT9cjyMS2NPXr/azbyC68+PYXsLeY06+IvuhSO0VgfpMeuynNvhc+6oMvW7Hn toaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773940331; x=1774545131; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CsJ0AYkPM8aVbL469BrHhoEE4ftXbii6Ku5SbAJ3B2M=; b=HK5tfRIPQsdbPJZa+IDrrjesBRlPq37+vUF2nVp2Cy1Cl5xSMEj0zKN8wCkNannEqy kGHD2SbKPLkOGXzupQ4fNS9JF7nF+0EtiV6leaEkZ7dhqkgeGv+PwaK9mNmTaPgJr1Ps pDah4dBMolk18WiIrHGwZW27r406Dh9xs0lH23TPPw39wcV+6bu5oMN8s+9a9bVRWovL /SlbdInJi5fj0HSj55LK/TFsMoETaEPU2K9/LuWH6QpErQhFn+2+NCp6uxARreKuJNQd NyReyOsW9UyATKBjb62Y3SchdDQ5ruIOFUBuA4J6c4UUPXcybYH40BU9plmMwaG6D0oV /Sng== X-Forwarded-Encrypted: i=1; AJvYcCWpw6Woe1+porUH0dAmjj4DzWePLA9yEY6R/QsY0eOpIbRmQdBSbQuD8nTMDZBh6GKajpw7RKbKST6z3UM=@vger.kernel.org X-Gm-Message-State: AOJu0YzDoYqgzcQYJz1qYRf4vBKRkKlxJ/6qUsgMckbnJvzTazVwZHWj 032qvfV4MTInee1BiWrjteUCXz+05e8o+r5q3ync+8uiqVAvelfq8H/eau/qlkLA9E8= X-Gm-Gg: ATEYQzyrObvuwHTtgGmqaxUwbefb46Mxlw4tgFpgORQGqPW5Ry6MF/xRSpDT4WksLMZ hKtlwvvlsq0rdgMMUKlO0afuxTO3UU27u4GvLJ0OjImA7C0dhIsOZNeYQ1CdEX9+E36RUTsHUuh gw2QUz4L8ot/qPv8PIuyB/TWVAI+18sXMIme5UGqJ2I6F8tBvyQNQ3PvAr4hALFmHnBow9Y4Abw VFgVDOQQlIboCI9j/wytrERz0dqgW6GHz2TYkxWBz9ss2vEmA/bYgM+yWU28vQOqeouCOSn9Hvu DrxqRU9H8lPZhx3cfRhy/+gSa8+xeQDvEbEEWJBuN0hw76/GIINWuGl5153hg+D+GtTOsJuGbrl AMiLX/ZHARlSvtwE90Hmhh+DBqSPiKLRa7UvhLdEqTUj/59l7ffDmFw79QeCTjZ3RmJ1Fw/xcs/ CCtOfJ X-Received: by 2002:a05:6a20:3c90:b0:39b:87f0:758e with SMTP id adf61e73a8af0-39bce9b4f21mr174045637.8.1773940331489; Thu, 19 Mar 2026 10:12:11 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:72::]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c74443cc2ddsm2326a12.24.2026.03.19.10.12.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 10:12:11 -0700 (PDT) Date: Thu, 19 Mar 2026 10:12:10 -0700 From: Joe Damato To: Pavan Chebbi Cc: netdev@vger.kernel.org, Michael Chan , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , horms@kernel.org, linux-kernel@vger.kernel.org, leon@kernel.org Subject: Re: [net-next v3 08/12] net: bnxt: Implement software USO Message-ID: Mail-Followup-To: Joe Damato , Pavan Chebbi , netdev@vger.kernel.org, Michael Chan , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , horms@kernel.org, linux-kernel@vger.kernel.org, leon@kernel.org References: <20260318191325.1819881-1-joe@dama.to> <20260318191325.1819881-9-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Mar 19, 2026 at 05:11:03PM +0530, Pavan Chebbi wrote: > <...> > > > + > > + hdr_len = tso_start(skb, &tso); > > + mss = skb_shinfo(skb)->gso_size; > > + total_payload = skb->len - hdr_len; > > + num_segs = DIV_ROUND_UP(total_payload, mss); > > + > > + /* Zero the csum fields so tso_build_hdr will propagate zeroes into > > + * every segment header. HW csum offload will recompute from scratch. > > + */ > > + udp_hdr(skb)->check = 0; > > + if (!tso.ipv6) > > + ip_hdr(skb)->check = 0; > > + > > + if (unlikely(num_segs <= 1)) > > + return NETDEV_TX_OK; > > goto drop would be more appropriate? Yes, you are right. Good catch. Will fix it in the v4; thanks for reviewing!