From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b5-smtp.messagingengine.com (fout-b5-smtp.messagingengine.com [202.12.124.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BCE93B0AE3 for ; Thu, 19 Mar 2026 21:57:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773957426; cv=none; b=Sx2AdBzqSLHJGjPrxS3iyqvgs1CRQxVk2aBHcS1wMRJlH9hkyZbcXln9/8hcs8o1kpehHMDOKNoD2dBeg4IZokNPW+ft0o69g7ds/2BCPPBzATdIN53bVlJmr01g7tWPvrEK6K87f4BPVXTNA/j+XEOiN2zcxMlD6qQFkenY+NE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773957426; c=relaxed/simple; bh=De4SEDXtg4zzVj7FnphOFC+1jilQymH/iprvmIwKvPQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DGtEd5tgkiUaF2CknVkzcMDvCbekoyOqI2CdR2X/ZkCKi4251QoARLUHGU8Cq/aawSTWWSnSVAYsnZwBm+JbZcGA5Bgdffm5qcsfbRx+di8Qg1uLqxJWgnse0HnpDvsWPJ+W4G95z5uDy5qzuJBjvDV1mYrASvWNsiGSGzvwpmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name; spf=pass smtp.mailfrom=shutemov.name; dkim=pass (2048-bit key) header.d=shutemov.name header.i=@shutemov.name header.b=llcQSop5; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Bjg+dmZT; arc=none smtp.client-ip=202.12.124.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shutemov.name Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=shutemov.name header.i=@shutemov.name header.b="llcQSop5"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Bjg+dmZT" Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id 5BAB71D001DC; Thu, 19 Mar 2026 17:57:02 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Thu, 19 Mar 2026 17:57:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1773957422; x= 1774043822; bh=5cYUbHVZqxGsZ9RWAyJj31WCuW6l1bi98Wnse7Kjgeo=; b=l lcQSop5bgUOI9AdErI7RQ9An3FwOlx+fb7WYh7aB1hRDuBo9tp3ARgFNA50ewihd Nco4dV/ddTpw/Hn6nkgMT+r87/3QZUqRabYin07bR2iVXOFFfiA0nkdxxDrc/fAV SZv5Kp38xwu24WalYGgRmKx/RN2rOcO+vQx11nFL6vuZEz8DcDB97hKjApu2csaq pLF0/AVWsmSxHgwyyA2fEY318ULtwSpdXrDPZj7H00ACKIgSn2r7B+qpV8u37zZx fXugW2S3qw6Uhk+N45zPmpgSSlalRxMexrUZ0vSNhCGuQ0OvHa1nJwpVrY4WvGY5 U1mmr74WRMOuALHPT+wlA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1773957422; x=1774043822; bh=5cYUbHVZqxGsZ9RWAyJj31WCuW6l1bi98Wn se7Kjgeo=; b=Bjg+dmZT4UTrFGxYYOPWtgtvjy0f0tL/8v5+CBNF4gFniqqlInM NaLSC05dw+M/WRkOLN0IwlJcPIEaakcTusDEGAlSi61sQMzdQJN1oEWxd7m/GCIT pBfxqyvQRibP2neAtlTKnXf9/Wev9izuTSxJE2ofe9KTroESLaGuDAGaIQHn28rA Wi8ANekCL5YqdNg3ngHOQgSM5zCWWHdwG771Ry+4Cu2luBo79ojFlhQrLv+nRkY8 0MyhhA28FARkDod+M/uhZWKB1lXl364xZnpywQOv8XDi1nt44daJ8iNz+ZZ1q8OY 84C4twYece6jDJqPKKf9tJ0JVpx2JfSgbBA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeftdekudehucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepmfhirhihlhcu ufhhuhhtshgvmhgruhcuoehkihhrihhllhesshhhuhhtvghmohhvrdhnrghmvgeqnecugg ftrfgrthhtvghrnhepfeetheejudeujeeikeetudelvdevkeefuddtkedvtdehtdetieeu ieetjeeugedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepkhhirhhilhhlsehshhhuthgvmhhovhdrnhgrmhgvpdhnsggprhgtphhtthhopeef gedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheplhhjsheskhgvrhhnvghlrdhorh hgpdhrtghpthhtoheprghkphhmsehlihhnuhigqdhfohhunhgurghtihhonhdrohhrghdp rhgtphhtthhopegurghvihgusehkvghrnhgvlhdrohhrghdprhgtphhtthhopeiiihihse hnvhhiughirgdrtghomhdprhgtphhtthhopegsrgholhhinhdrfigrnhhgsehlihhnuhig rdgrlhhisggrsggrrdgtohhmpdhrtghpthhtoheplhhirghmrdhhohiflhgvthhtsehorh grtghlvgdrtghomhdprhgtphhtthhopehnphgrtghhvgesrhgvughhrghtrdgtohhmpdhr tghpthhtoheprhihrghnrdhrohgsvghrthhssegrrhhmrdgtohhmpdhrtghpthhtohepug gvvhdrjhgrihhnsegrrhhmrdgtohhm X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 19 Mar 2026 17:56:58 -0400 (EDT) Date: Thu, 19 Mar 2026 21:56:53 +0000 From: Kiryl Shutsemau To: "Lorenzo Stoakes (Oracle)" Cc: Andrew Morton , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 7/9] mm/huge_memory: deduplicate zap deposited table call Message-ID: References: <29fa4129cd560681c67433b4c344b2c9a027d1b4.1773924928.git.ljs@kernel.org> <420f1b11-3b62-46dc-be33-58fbd5a4c8b3@lucifer.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <420f1b11-3b62-46dc-be33-58fbd5a4c8b3@lucifer.local> On Thu, Mar 19, 2026 at 05:18:11PM +0000, Lorenzo Stoakes (Oracle) wrote: > On Thu, Mar 19, 2026 at 05:03:10PM +0000, Kiryl Shutsemau wrote: > > On Thu, Mar 19, 2026 at 01:00:13PM +0000, Lorenzo Stoakes (Oracle) wrote: > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > > index 499c31bf8f83..c4e00c645e58 100644 > > > --- a/mm/huge_memory.c > > > +++ b/mm/huge_memory.c > > > @@ -2431,6 +2431,7 @@ bool zap_huge_pmd(struct mmu_gather *tlb, struct vm_area_struct *vma, > > > pmd_t *pmd, unsigned long addr) > > > { > > > struct folio *folio = NULL; > > > + bool needs_deposit = false; > > > > I think 'has_deposit' is a better name here. > > That's fine, can rename. > > > > > And initialize it to arch_needs_pgtable_deposit(). > > Yeah I considered that, but then you have to do logic like: > > has_deposit = has_deposit || ; > > Which is a bit ugly. You are overthinking it. Just do if (!vma_is_dax(vma)) has_deposit = true; No need in squeezing it into single line. -- Kiryl Shutsemau / Kirill A. Shutemov