From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FEE82C3255 for ; Fri, 3 Apr 2026 17:02:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775235743; cv=none; b=gGI2aU/VjeUA07xi3otjPNd8QOG1KGMy8Iz1HQTusj+uaD+JWgUQEdsYwDBm0Atpx7juykeXPM4llr/HKWMitQO4R+ecnw9a3qOS2+RnnwLV2/Ckbm8sFADKSG13FXsaL1ay28f2/H6CLnMvsdR/psDJutP6uHaucFTTS4qoMqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775235743; c=relaxed/simple; bh=fjWWSKtr1jihoXzExgBgCJYTURbpDQDzI0eptamNsyI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ndzdZmWHveC8s/kxOyuXUchm9+VwcbAXwoVY1a7DTNOJvSXmbJ7O8WqP7H8m9izbs40ORE1AXiRFfNUh1H8LS5envjc+KpPQ109D5RuHMaujs8xZLwVJ7/xY74TFpxKNbVQgNJosOh6l9SAdN9i6C6mzIimbav44+bPzzSKsFMo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=Ca+0lN8a; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="Ca+0lN8a" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-82c70e4654eso972762b3a.2 for ; Fri, 03 Apr 2026 10:02:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1775235742; x=1775840542; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=J9eHpYvA3tq0xgSZlAcNsaH335YcgPNXfqBqXXJlhfs=; b=Ca+0lN8aIKSPFBZ8zqARj058oGp7WNHqe1oP/UOPX5w/cP7Cr0p3Tt9s6a4UrMIemA HtlO/ctdmAXlvsR6G0Epgep0Dzjz46c2O9xiDfmBOeKtEmHBzPR5vTuigy0S+a1WepPd Wvr0QKILm4R8DC3N07wWkLJslQoN7Q5BTtIGUMlBGMwg+mSN+3RnvFhK72ilYMkjFXTu zaVOg0j654INcISzE3RnjcYfqNreARGlCDALKDnE+rOGMsdtozT4aEHcEkXPed5TyPnM JTZtfXilJM+g9Acyjh6m/83D8pAXOj1aW0i9Dj4wtdCtafDRwb78M00fn+cYKExooC88 7kWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775235742; x=1775840542; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J9eHpYvA3tq0xgSZlAcNsaH335YcgPNXfqBqXXJlhfs=; b=AV44rDTXoBLgcyr5/IR16/DeKq9+NtaF1ojKyfncRVjjOnyhJQUOUpYAs0dx6DfTMJ rEKH5fYZwXYGm8Mm2TlWRLz5OWr8mv6j3hKj5cq2Plx/+qXYhD8TqBS+Oduq8Q20SZEa FKRf85EptIVDmEUob/SzrjMMaES8oYw7DG9AXri5ItgIza9XtBxyPgydses0cibsm1lw BiSL7R6Ut/qdt/mj39GYUjmYzmltG4lYWIW6uZb+yjuHRlWYSZpUm1pwCfa19v9il1sU oSQezdC1B+pDtI9WeJk5NqaQXv+S7zXOG80kCHrGhEGs2Niu4BROWUed6Q8FhPr+KZnZ aiUg== X-Forwarded-Encrypted: i=1; AJvYcCWPKsUnI4pVpwY6p96TUSJwoT2P3q1Zux6CzgZ55NLtd+5vevUnxXzG0JC86ojocuSd3NOgxyLk2uEKOPQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwDuzKApnumAIs9rI5uy1ABt14LN353ELpo3PbMbFs9T+Q0Fzds 9VVtpzR7YrYKOiNLM4TG+IpN4n/Ee1dnVJwiIjksa/qM3r1uSK8sMJ8cTQylhvJFbaQ= X-Gm-Gg: AeBDiesxKnplPBDQUIdA8cVKNtw6BDsQUqHF3O3ops9HuSHtBT5VY/i2K5rmRxj2eZU UQfRj6nMufB+ryZxMk9Y7Yo05sfIY4soMWVlrFWaT44IBJRAj4EyPJid9bRtsu3Nr1Lm1TiD85s DFrkREFU9cCVoqkLSb0tVhVbhjHgDJ+VLJ6XY0n5+Ghgo3ElOcdAiAGGqTyusoVBSrvCCVvZSiR jhSxODvOkO/Ee2r9i/dFFZwFoo4bcslEs7OxFk487bnAnFvUJqgpeThVy2xEn4txxpGqZEMr3+h xh+vPpNlJYq7jI3CdK30T4kuTLARueQN5n4QUKo6Sr8m4m0d7KwGROcpLjhOHsF8o9MgPUDXAXm u//SuHrkLCEWD7g37gbUUXllO8ggcZO4cUujcv4Suvta360CJNMC/j0h/gOllYid4EekMAOcpq+ Bj6cPDH/Q058XrNs0= X-Received: by 2002:a05:6a00:2d15:b0:82a:780f:a187 with SMTP id d2e1a72fcca58-82d0db6c414mr3532103b3a.36.1775235741468; Fri, 03 Apr 2026 10:02:21 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:5b::]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9b76c0fsm5956785b3a.15.2026.04.03.10.02.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 10:02:21 -0700 (PDT) Date: Fri, 3 Apr 2026 10:02:20 -0700 From: Joe Damato To: Willem de Bruijn Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , andrew+netdev@lunn.ch, linux-kernel@vger.kernel.org, willemb@google.com, linux-kselftest@vger.kernel.org Subject: Re: [net-next 2/3] selftests/net: Test PACKET_STATISTICS drops Message-ID: Mail-Followup-To: Joe Damato , Willem de Bruijn , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , andrew+netdev@lunn.ch, linux-kernel@vger.kernel.org, willemb@google.com, linux-kselftest@vger.kernel.org References: <20260402232203.2004496-1-joe@dama.to> <20260402232203.2004496-3-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Apr 03, 2026 at 11:26:01AM -0400, Willem de Bruijn wrote: [...] > > + > > + if (cfg_drop) { > > + check_packet_stats(fds); > > + goto out; > > + } > > can this not use the check_packet_stats added in the previous patch > right below? IIRC: no it can't because when I tested this the do_rx hits the error path in the drop case which makes sense because of the tiny receive buffer.