From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AE4D1F1304 for ; Fri, 3 Apr 2026 08:57:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775206681; cv=none; b=LYe3QDhQ3GS9rdr+dMDibGLui4ZtduYDe23+NgtB4fzZhIekS7xfhWp/Cjz8S4BmzfyUDnW1hXSboSQg4R6TRUkmMqMTMrcwIo/TOpJqi2nm/bIyCeyNhExfAlh1dL7+EHrEqpu9nuWy+L6QMhKNIpTPpiYsxlNwSBQZFk0XsQw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775206681; c=relaxed/simple; bh=UUsZF2RTkbHP8qOi4OtnUD3lJ240sZg2HgpZ93PPb7I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oDuNKMNxrwg2GStL00E0lvHyi6HCVVZOk0Ij3YFDYdn8SSGx14ceNIMj2hvd6282N8pyI/DjG0BzfpjMPzjGq09Iv0PZfZhNBY5jKhfr+hXVhACXg4vRGYI8YcvOlwKhadniM9RdFDp4obELDG1rtgLHZfz+t8FWYA69h6v0SfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QT+EmKYU; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QT+EmKYU" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-82ce2e2880cso1259949b3a.0 for ; Fri, 03 Apr 2026 01:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775206679; x=1775811479; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KxQFvqelXHDHyvDQl7EWq8XKSqTOS9+kkTkwsuSR9EM=; b=QT+EmKYU85hI1FkThIlaZrXAsLvepg+Xa2vwqsojqpQvu0EtigTfgafDWPKHkaK9/A fmZHvcwiP237A6HiQP0zTG/BCRubBO6yd8Z2tNE2j5fMyx7E+BIRkwrs2M+joksKfW9a OkZSz3YtNmSKaul9oQg/DP/eiwA+pW4WDWkNud2lyGXNWxHKy/AJEaMdZ4EiNfui0IGE v8FE11QVTCUMCJkqSpV6NrT5F2jy8iJKS+bg1UoJGOn9eI0OvD5Ag8y3+68xAhVrlI5X dwY2tIxhsw+mTFBkXKW5ZAeVp3ZZlaIRj8C80FHreSfJUxjiVtGNifs2c1fXTkMoNqlP 3vYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775206679; x=1775811479; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KxQFvqelXHDHyvDQl7EWq8XKSqTOS9+kkTkwsuSR9EM=; b=ehMbIPHNSkSbEb8h/Q/wi70OEXL9c131RuqZ4aIbvNn2Lk6FBZRQOA1+x7+9TQ3yhN o/IELskamymuUs/J7rJ0L8PhGRY1QKqYc73Iv/FSyLNUoJncTpkzKeqLUDYM5ZrDwF4V 3Ht08yMbGP34G28Y5njuG1et38sJ74sHUjpBKm+HQIN2ifdY2cZ3EyV37EZ5RMEaQKDc 9ilMqAv5LuFtMAmTEvGtpm422por9OmMZZTEwqn6Mo5VWEwMPPBgveW06AmUZWa4hj2S 4urCErDpEjAPaxdBcgMJW9ICmZPRom87GLvuUUgF9UCeUK1JIb/A4yKhNarwsorn3EnR pscg== X-Forwarded-Encrypted: i=1; AJvYcCUeVkCB8fj/a44a/tqCOomDYM9/7zigOPDgKIkPDzMJ6qKQeUHj0ax18j3PkCYHZLFxB5gdfHmD6U7gtJ4=@vger.kernel.org X-Gm-Message-State: AOJu0YyFoJQZuFkQExgIH0IhQmqpQ6axaWAprToatcxluPSOhb9URKvn SCZM0hCMHZ4uKGGsH5BYVWkJoq/1F1p+Uy25Ecfr8aYnk+sBOxvI8Prw X-Gm-Gg: AeBDievrx+x+gFeVVg5di03uoysf//J7GFB8+iBUtiP2I2w62awom5HSd2B4CzVl8l5 3Ddw2qrrMSgVV3ntJPXyotoAgyYdPvdclh9NoASRJDPsDvyfTcPkMCuTLvg0mxi2VcRXJzVTAl7 J10T9b87HpTx8qw1Y+vWtx/xTqp8kp2ImiZqLqIDiprhWGHmNly1F3VHlU9C+gt47WumDK8mH7l KpDpMCoG5CHZIr+2NFi3RSbVXyX8RsszvDpzKyaYh52VdbG+09QDW9cqVirVydEuaesbtOYrrMy yGvy9RSpjQMr9SBGhIcL9wqE2wjCATi9iSZ5yRfDbw9vY9FghUdHIqxnXmc8e1gNQ3TmosYQGd5 mGAvtgXH0YHgTNLiQVLLHjn3NAZ02Q5ho1KNLRuLcc0mrj6Xl6ChQVXuCQPd/mdDc3Ui6hU/uYl MV4RnVzCjTv6SovWdOP8nvDipZA0P2N6ZO+jCkvDzCIJANuYQ= X-Received: by 2002:a05:6a00:3027:b0:824:93e4:2ddf with SMTP id d2e1a72fcca58-82d0da3f8afmr2250267b3a.13.1775206679416; Fri, 03 Apr 2026 01:57:59 -0700 (PDT) Received: from google.com ([2402:7500:477:c367:541d:a40c:7624:4482]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9c68273sm7096151b3a.41.2026.04.03.01.57.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 01:57:58 -0700 (PDT) Date: Fri, 3 Apr 2026 16:57:53 +0800 From: Kuan-Wei Chiu To: Suzuki K Poulose Cc: James Clark , mike.leach@linaro.org, alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org, mathieu.poirier@linaro.org, leo.yan@arm.com, Al.Grant@arm.com, jserv@ccns.ncku.edu.tw, marscheng@google.com, ericchancf@google.com, milesjiang@google.com, nickpan@google.com, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] coresight: etm3x: Fix cntr_val_show() to match cntr_val_store() behavior Message-ID: References: <20251202082613.3265761-1-visitorckw@gmail.com> <3bec7ceb-61a8-4b38-a794-02ee2fc9e68c@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Suzuki, On Mon, Feb 02, 2026 at 09:33:59AM +0000, Suzuki K Poulose wrote: > Hello > > On 02/02/2026 05:09, Kuan-Wei Chiu wrote: > > On Tue, Dec 02, 2025 at 09:26:19AM +0000, James Clark wrote: > > > > > > > > > On 02/12/2025 8:26 am, Kuan-Wei Chiu wrote: > > > > The cntr_val_show() function was intended to print the values of all > > > > counters using a loop. However, due to a buffer overwrite issue with > > > > sprintf(), it effectively only displayed the value of the last counter. > > > > > > > > The companion function, cntr_val_store(), allows users to modify a > > > > specific counter selected by 'cntr_idx'. To maintain consistency > > > > between read and write operations and to align with the ETM4x driver > > > > behavior, modify cntr_val_show() to report only the value of the > > > > currently selected counter. > > > > > > > > This change removes the loop and the "counter %d:" prefix, printing > > > > only the hexadecimal value. It also adopts sysfs_emit() for standard > > > > sysfs output formatting. > > > > > > > > Fixes: a939fc5a71ad ("coresight-etm: add CoreSight ETM/PTM driver") > > > > Cc: stable@vger.kernel.org > > > > Signed-off-by: Kuan-Wei Chiu > > > > --- > > > > Build test only. > > > > > > > > Changes in v3: > > > > - Switch format specifier to %#x to include the 0x prefix. > > > > - Add Cc stable > > > > > > > > v2: https://lore.kernel.org/lkml/20251201095228.1905489-1-visitorckw@gmail.com/ > > > > > > > > .../hwtracing/coresight/coresight-etm3x-sysfs.c | 15 ++++----------- > > > > 1 file changed, 4 insertions(+), 11 deletions(-) > > > > > > > > diff --git a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c > > > > index 762109307b86..b3c67e96a82a 100644 > > > > --- a/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c > > > > +++ b/drivers/hwtracing/coresight/coresight-etm3x-sysfs.c > > > > @@ -717,26 +717,19 @@ static DEVICE_ATTR_RW(cntr_rld_event); > > > > static ssize_t cntr_val_show(struct device *dev, > > > > struct device_attribute *attr, char *buf) > > > > { > > > > - int i, ret = 0; > > > > u32 val; > > > > struct etm_drvdata *drvdata = dev_get_drvdata(dev->parent); > > > > struct etm_config *config = &drvdata->config; > > > > if (!coresight_get_mode(drvdata->csdev)) { > > > > spin_lock(&drvdata->spinlock); > > > > - for (i = 0; i < drvdata->nr_cntr; i++) > > > > - ret += sprintf(buf, "counter %d: %x\n", > > > > - i, config->cntr_val[i]); > > > > + val = config->cntr_val[config->cntr_idx]; > > > > spin_unlock(&drvdata->spinlock); > > > > - return ret; > > > > - } > > > > - > > > > - for (i = 0; i < drvdata->nr_cntr; i++) { > > > > - val = etm_readl(drvdata, ETMCNTVRn(i)); > > > > - ret += sprintf(buf, "counter %d: %x\n", i, val); > > > > + } else { > > > > + val = etm_readl(drvdata, ETMCNTVRn(config->cntr_idx)); > > > > } > > > > - return ret; > > > > + return sysfs_emit(buf, "%#x\n", val); > > > > } > > > > static ssize_t cntr_val_store(struct device *dev, > > > > > > Reviewed-by: James Clark > > > > > Thanks for the review! > > Is there anything else I need to do for this fix to land? > > Thanks for the patch, I will queue this for the next release (v7.1). > Just a gentle ping. Since the v7.1 merge window is presumably opening in about a week, I noticed this patch isn't in linux-next yet and wanted to send a quick reminder. Thanks. Regards, Kuan-Wei