From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9D7A2D7DC6 for ; Fri, 3 Apr 2026 12:10:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775218221; cv=none; b=DN3WwCO7RjbYOgQbOaT+2ge9NOV3nQZC0193nSx/pjWOnrtjKPx+npaCgj/LV+YEtPGrlzam/X4zU5i8lVhLftViy5vnSN5JFhqhnlpR0iTWQ6bNVc05fSpCD73QJ4vqygMjqRU+Z647zyM9SQomjXJTamg/1VfBp6raIT4hmI4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775218221; c=relaxed/simple; bh=gKuPZPZjAF2bu9KQLK5KUDtBDxAA9ZaVqW9WeXW5oAU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BU0jWg7Nai7hai4K8DkRuzdQ4EGFLlsYpw/JB50tXFd/HxDwLVyWIzEAggf82qkF6DE3oeqFg6/81KpeO2RtQS07/Z96sWnooJ7RnTrg79AGwyz7hw4fGmsGEI9CEoz8NgrsT8tL/BMmpNjh5qACk8nnlKSBqz22C0zpLQQTceA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bVuswBYh; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=KF58d7+n; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bVuswBYh"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="KF58d7+n" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775218219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XT4Axufy1UQO5/IB2/wh8iVy7omBnkBDck5yhzPJ1BM=; b=bVuswBYhuCThhml6Abwk7Ce/Myowt/niNV9haqVC2w57bT6IfY88cuFKBy38gdSw+kiqYI isUbaOzM9AazkUCoYkTohQh8Hk69hmB3yH/iuz/5yV6Tel9wPj/VdPms63FcihTaXTrAjO ZV39lQ/yoo6lwVmovaGnePaJBZVdv8I= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-230-ZfuDRL_wPqWEJ2LFOjehNA-1; Fri, 03 Apr 2026 08:10:17 -0400 X-MC-Unique: ZfuDRL_wPqWEJ2LFOjehNA-1 X-Mimecast-MFC-AGG-ID: ZfuDRL_wPqWEJ2LFOjehNA_1775218217 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-486fa07f2bbso13211395e9.2 for ; Fri, 03 Apr 2026 05:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775218216; x=1775823016; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XT4Axufy1UQO5/IB2/wh8iVy7omBnkBDck5yhzPJ1BM=; b=KF58d7+nhyIaqSg4E0d5wKRbMzZOFvJLFSdfbWm6QgnLH0GhUI87u2s336dDkth5o1 SZRJVQli1rp3hUR4WTFQaPPh86tkwNkpa2HpjtJ1KyuXIip3PTDSlXwrCxTZ3qJd2fr+ UmPJktceXffZyvolQpVnyjFj1TR/g+t3SrRD58gQlUXjzeuTUTJ7btl9ynTJTlgSjsoe cdpaYj906lEXhbhTtuUdlSkN3i0HjWvkSaZOi5Xgbz1biDnjU/bWFgjyes1ePuF1FINs YEQ5OG7iSEODYt/758MT5z4rwz25R6n50TaF3lYte4ih5z0IwdtY7QEn3Z2iUAAjpR0M eaVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775218216; x=1775823016; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XT4Axufy1UQO5/IB2/wh8iVy7omBnkBDck5yhzPJ1BM=; b=MVh3C0xXHdg+hvBbKdoOAmKBiq3cirBj3rmgGgMdEDakGTnd66Er/2+dHdE7pqhj49 TPOPYNGYvGIMtraa5nXx63LkHqiF+puXrv4Iq+ugLFRI9ZjR+G8LOm0lVhXmEHadgoI1 Iabbj4FW3e09tvEVurY3YwOHACz7Ag5tv6tv/MJbZADCZHpYo0N4dduFhl9mUvPtmUf2 WGf+arbb44qLnnBfXYSFlBIcONBujqs3i8xyq4VN+W5YfTwbvzaRQIFCampwsBaYrl4a 2EaUkfUYT4Ub2LU28maE1Lt8EoDtG4JW1rd1iXtPbCitOhR5JZWxWI2NRZfODGoYZvge pM3g== X-Forwarded-Encrypted: i=1; AJvYcCXd/zxuEIwGhKne15AAn1Zb0UfL1q8NMjCvlHs68v8+py1BztsLM2/We9sndhE7YRN6nUvMMkvC5vCfLVo=@vger.kernel.org X-Gm-Message-State: AOJu0YwZrc4ksu5vckWiU1XxHj7nMej7ugzUiuBY53GEpDttbssBXPgE ihWnuDV49JCTOqbrf88DQK1VUnrQ366Uz0n/ldnyxlefqjEJ5EKUezvj8HykPvESpCVg/jpwunA A7f/EYdWanbgjyibtSXr0C35jUOdC2XAdaiequ7pp82rHqidHyoC6FT4gD90AaEdgGw== X-Gm-Gg: ATEYQzwnSLpLZGcsKlww2Wv5mdhSq5//84vSFKfBUxzFQXdt4CM/4ihnJgp+/jFZUqg gON5zJbbxl8v1dvGVoJJ1kV2yGatDjp84C+x7C1BdLFD2mgkNb5dAGShNJDJWGVS24e+3/6s14C ky9Hp4o+6WAQcQO9qdxWJgN9m9ZOOECRUK2a80U3AsxTJtx9yMol/jmlDOJnPfz5SmmpdWLMFB7 DUqAxdQwPhKn+mxUsA30IVxVWj05WYA7PuIXtDw0cV+2oalz/wwFEIbZTMs+8ST/QDCtS1HrA8o +5NBbUbniYzFKGhN9ywtauNAItIoSKdt5R8UlG0lOulwS1PgnOR+KnVmiKJ5q+iqd/nmwXpiT8a 9bAM8klVVPG4W7EoQ3R1WHz/e2UM= X-Received: by 2002:a05:600c:3544:b0:486:fd5c:2b35 with SMTP id 5b1f17b1804b1-48899735bb2mr39169275e9.13.1775218216475; Fri, 03 Apr 2026 05:10:16 -0700 (PDT) X-Received: by 2002:a05:600c:3544:b0:486:fd5c:2b35 with SMTP id 5b1f17b1804b1-48899735bb2mr39168825e9.13.1775218216048; Fri, 03 Apr 2026 05:10:16 -0700 (PDT) Received: from leonardi-redhat ([176.206.19.176]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4889f6843dfsm22557565e9.12.2026.04.03.05.10.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 05:10:15 -0700 (PDT) Date: Fri, 3 Apr 2026 14:10:13 +0200 From: Luigi Leonardi To: Stefano Garzarella Cc: netdev@vger.kernel.org, "David S. Miller" , Arseniy Krasnov , linux-kernel@vger.kernel.org, virtualization@lists.linux.dev Subject: Re: [PATCH net] vsock/test: fix send_buf()/recv_buf() EINTR handling Message-ID: References: <20260403093251.30662-1-sgarzare@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260403093251.30662-1-sgarzare@redhat.com> On Fri, Apr 03, 2026 at 11:32:51AM +0200, Stefano Garzarella wrote: >From: Stefano Garzarella > >When send() or recv() returns -1 with errno == EINTR, the code skips >the break but still adds the return value to nwritten/nread, making it >decrease by 1. This leads to wrong buffer offsets and wrong bytes count. > >Fix it by explicitly continuing the loop on EINTR, so the return value >is only added when it is positive. > >Fixes: a8ed71a27ef5 ("vsock/test: add recv_buf() utility function") >Fixes: 12329bd51fdc ("vsock/test: add send_buf() utility function") >Signed-off-by: Stefano Garzarella >--- > tools/testing/vsock/util.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/tools/testing/vsock/util.c b/tools/testing/vsock/util.c >index 9430ef5b8bc3..1fe1338c79cd 100644 >--- a/tools/testing/vsock/util.c >+++ b/tools/testing/vsock/util.c >@@ -344,7 +344,9 @@ void send_buf(int fd, const void *buf, size_t len, int flags, > ret = send(fd, buf + nwritten, len - nwritten, flags); > timeout_check("send"); > >- if (ret == 0 || (ret < 0 && errno != EINTR)) >+ if (ret < 0 && errno == EINTR) >+ continue; >+ if (ret <= 0) > break; > > nwritten += ret; >@@ -396,7 +398,9 @@ void recv_buf(int fd, void *buf, size_t len, int flags, ssize_t expected_ret) > ret = recv(fd, buf + nread, len - nread, flags); > timeout_check("recv"); > >- if (ret == 0 || (ret < 0 && errno != EINTR)) >+ if (ret < 0 && errno == EINTR) >+ continue; >+ if (ret <= 0) > break; > > nread += ret; >-- >2.53.0 > LGTM! Reviewed-by: Luigi Leonardi