From: Stephen Boyd <sboyd@kernel.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>,
Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, quic_ppratap@quicinc.com,
quic_jackp@quicinc.com,
Udipto Goswami <quic_ugoswami@quicinc.com>
Subject: Re: [RFC 4/8] clk: qcom: gcc-sm8450: Keep usb30 prim gdsc on during runtime suspend
Date: Thu, 19 Oct 2023 17:05:54 -0700 [thread overview]
Message-ID: <ac00b49505e926ac4f3d0d0ba315b366.sboyd@kernel.org> (raw)
In-Reply-To: <b8fa17a7-296e-4e17-9438-a8be04dbd476@quicinc.com>
Quoting Krishna Kurapati PSSNV (2023-10-19 01:37:20)
>
>
> On 10/19/2023 6:28 AM, Stephen Boyd wrote:
> > Quoting Krishna Kurapati (2023-10-17 06:19:44)
> >> When runtime suspend happens in host mode, if cable is removed at this
> >> instant, it triggers a resume where a xhci register access is done when
> >> gdsc is not on leading to a crash. Keep usb30 prim gdsc as on during
> >> runtime suspend to avoid this crash.
> >>
> >> Signed-off-by: Krishna Kurapati <quic_kriskura@quicinc.com>
> >> ---
> >> Note: I am not sure if this is the right way or setting GDSC flags to
> >> PWRSTS_RET_ON is the right approach. So for now made this change to
> >
> > Does using PWRSTS_RET_ON work? Does the GDSC support being turned off or
> > is the lowest power state retention?
>
> I didn't see any issue when I put it as PWRSTS_RET_ON. If the GDSC is
> off, when we remove cable in host mode, we see a crash because of xhci
> register access. But when I try putting PWRSTS_RET_ON /
> CLK_RPM_ALWAYS_ON it doesn't crash.
>
You need to find out if the GDSC only supports retention mode. Otherwise
it sounds like the xhci register access is happening when the genpd is
off, and thus the driver needs to power on the device before accessing
it.
prev parent reply other threads:[~2023-10-20 0:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 13:19 [RFC 4/8] clk: qcom: gcc-sm8450: Keep usb30 prim gdsc on during runtime suspend Krishna Kurapati
2023-10-19 0:58 ` Stephen Boyd
2023-10-19 8:37 ` Krishna Kurapati PSSNV
2023-10-20 0:05 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac00b49505e926ac4f3d0d0ba315b366.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_jackp@quicinc.com \
--cc=quic_kriskura@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_ugoswami@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox