From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751819AbdJXJJL (ORCPT <rfc822;w@1wt.eu>);
        Tue, 24 Oct 2017 05:09:11 -0400
Received: from mout.web.de ([212.227.17.11]:65144 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751323AbdJXJJI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Oct 2017 05:09:08 -0400
Subject: Re: [PATCH 1/3] drm/exynos/dsi: Use common error handling code in
 exynos_dsi_enable()
To: Krzysztof Kozlowski <krzk@kernel.org>, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org
Cc: David Airlie <airlied@linux.ie>, Inki Dae <inki.dae@samsung.com>,
        Joonyoung Shim <jy0922.shim@samsung.com>,
        Kukjin Kim <kgene@kernel.org>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Seung-Woo Kim <sw0312.kim@samsung.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <7d4cdb43-432c-c67a-5d3f-c37bd604f539@users.sourceforge.net>
 <9028478a-a00d-6fcd-0286-b8daefa8c912@users.sourceforge.net>
 <CAJKOXPc_QQ-QKkPWQoxj0LjeJsG2BjhP6X0X9m8YQEo=qTnOvg@mail.gmail.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <ac01b36a-2d5c-6852-2f2c-8aed89acdaba@users.sourceforge.net>
Date: Tue, 24 Oct 2017 11:08:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAJKOXPc_QQ-QKkPWQoxj0LjeJsG2BjhP6X0X9m8YQEo=qTnOvg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:bhUPWcFMVp8JldBl6BroYaPsUMBulXU/MNwdDHZranlmc4HKnHn
 E2PEPAlfyXs31rOJF884HXALGiHiac7ku1XDKiyZL4R0EZs4dsa7h9TaHDYIynU4AocKoSo
 gMreWu4/Ob7lFkVn6RUg4wxbKxpCG57QxsXX90mX3KsjaEWrx+Cb5EkGR/EShfwpUu+iXry
 3Kcvkx0ek+G0tc0pqJrqw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:36Gjhxfzsbo=:WbfR3LZOVeHCidksYsIVgg
 gfBrU+qcO1mua0LNVTXGWbVXjL+IAP4KRNgiQc8k2KfQxMqo80FZn2uVlOQYZqxAdltrQukbZ
 efb6FwjXfilpDJ6X0H6YlJE1s4CWjYbOXjQOGxsxb5gouGRWL8ghNmSG7w4/PMPbLviT3g7hL
 K63u/kZlL69HQzlLamE2ATKggCxuBgdLGHBjNayVdmnjIaU4QzGRFBnPZYmkhQ8n6hiRnUDDT
 RBEdnbOR2pb7ixXlxi2ZnuCeZ6nVlqO6BXaY/8XCv+9Hj/DeutWJ1408fnKFMdxiZNFjwp2sJ
 rrZN5i0v3V3feUmkQHflTqgVyvnFd6UrFzev7+hO1Ga60v9zy1MK8wN3EO818UlgZrRcST2SV
 RbKDoi+dB8iG2fQfGQYcIeCZ0PsIWJoaHYKF2m5v1d0KC3sbmf9IuCLLkh0o6tU1MvS9oHYNR
 cRGyBMKxLe0La3WhM3dsq7eLUiBPItyzpqce/wHnf8C8bRHjR3lX7Y2YJuz2KUFpKSWljvnFa
 myCGzqAmudU3uFJqmHBIr4FE4Q4TOF8BSaYiXzupR5Xs8P6mBxlhsoBtOKl60lWqDIwsbLtB1
 +eXuIB+g54K5ZRP71UJLPT881+Fx8pcyuIHo5fTHN8nOWCQ/O8efFce/oa8BXq49G1IP+6yOP
 mdIgKTBuk+fzfYawoLqb1hGcmOnNhMKv2ZvyPTEZsTjUOgn74Pi7MqD4NlRkuTqdV9uBsTmiC
 ujl0szr3lHsqDwyl4RGHmDVhr2kOVBQX1uI4MnLzZYxELd5x0VSW/3ZqZTglZm0U0ow/hDj6Q
 9I2Kcz7MZgnqf0MTAl2Hz+OhZ8ffQrBJxa3zTx3mMC+EN9I9BE=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -1401,11 +1400,14 @@ static void exynos_dsi_enable(struct drm_encoder *encoder)
>>                 dsi->state &= ~DSIM_STATE_ENABLED;
>>                 exynos_dsi_set_display_enable(dsi, false);
>>                 drm_panel_unprepare(dsi->panel);
>> -               pm_runtime_put_sync(dsi->dev);
>> -               return;
>> +               goto put_sync;
>>         }
>>
>>         dsi->state |= DSIM_STATE_VIDOUT_AVAILABLE;
>> +       return;
>> +
>> +put_sync:
>> +       pm_runtime_put_sync(dsi->dev);
>>  }
> 
> No, this does not simplify the code.

How do you think about to check a bit more if there are desired effects to consider
when the shown function call is stored only once at the end of this function implementation?


> Stop using coccinelle.

This will not happen for a while. - There are so many source code places left over
where you might care more for similar software improvements.

Regards,
Markus