From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B7E02EC083 for ; Wed, 1 Apr 2026 15:10:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775056252; cv=none; b=Pqjcj/zOjtmkQXEFgD9u5Z4oks8OKv0SZQP3PaOiysE5ap+A2pGp6uwfLZXm6R7ornyxNALAYeFbD9fjenQtcy1i1KF4KUrmytr4rDyKG8Vhe4gY8gXCTtC+8KpBd6z30cgF4JdXvkBcS0Jic28wN7EVI8kuRE/6bW2Nnc2K+bU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775056252; c=relaxed/simple; bh=olLNXQNPSNANzm/RqYjvnGKwcWnramj8uM7ajoADoRg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pxf3GoVWdPNDZFHgqQ9AGqq53CNC/D/L7YBeCBdysP3nCwb721y3cbCUwqpD6vZza+q8FS/d6vfv+TlmVBmvcEByak/957dZjsiA+2n5HDmFjPAqm89FfD6KajZZq2j69gvF7HJ0pLCfA87CdzCmfDJkvz9n5E4Tg98XPQpgb/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oGe/ULv2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oGe/ULv2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D18DC4CEF7; Wed, 1 Apr 2026 15:10:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775056252; bh=olLNXQNPSNANzm/RqYjvnGKwcWnramj8uM7ajoADoRg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oGe/ULv2hjYXCL9Z+63Ugi+kE3bHkKWyIG21yK125KIIcvhfKiPqos/3ZNHZuvqJs mW4LNL1CzE+zvMoeGJ9Ide79iokyxq9Eb8HEWmQUM9aU4JNjZCNUZ1HBfBgEZ95HTG tmyzemIMQyzfvR4GcTW+Cz3FbK0SEbxVLMpJU0T4ELm2/XwxE1FguEqT06luE2pQ7S Znn52y8bTzQrhNM0QrXYo59A3a1vvR/WWbEFBfz8L1EaFJH4Vqcg73vO90HpH2st4U 0oaglNsOJhFgPx5MP4O7JSnmaNmpZ5gJB9o5I0TPNmrZf1PJM7mY0WPpxBB8XtZQLI VizLhu7wrrb+g== Date: Wed, 1 Apr 2026 17:10:49 +0200 From: Frederic Weisbecker To: Marcelo Tosatti Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Leonardo Bras , Thomas Gleixner , Waiman Long , Boqun Feun Subject: Re: [PATCH v3 4/4] slub: apply new queue_percpu_work_on() interface Message-ID: References: <20260323175544.807534301@redhat.com> <20260323180150.335869265@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260323180150.335869265@redhat.com> Le Mon, Mar 23, 2026 at 02:55:48PM -0300, Marcelo Tosatti a écrit : > Make use of the new qpw_{un,}lock*() and queue_percpu_work_on() > interface to improve performance & latency. > > For functions that may be scheduled in a different cpu, replace > local_{un,}lock*() by qpw_{un,}lock*(), and replace schedule_work_on() by > queue_percpu_work_on(). The same happens for flush_work() and > flush_percpu_work(). > > This change requires allocation of qpw_structs instead of a work_structs, > and changing parameters of a few functions to include the cpu parameter. > > This should bring no relevant performance impact on non-QPW kernels: > For functions that may be scheduled in a different cpu, the local_*lock's > this_cpu_ptr() becomes a per_cpu_ptr(smp_processor_id()). > > Signed-off-by: Leonardo Bras > Signed-off-by: Marcelo Tosatti Again I can't review the details but I'm fine with the approach once the namespace is fixed. Acked-by: Frederic Weisbecker -- Frederic Weisbecker SUSE Labs