Re: [PATCH 1/3] soc: mediatek: mmsys: Add support for MT8188 VPPSYS

Re: [PATCH 1/3] soc: mediatek: mmsys: Add support for MT8188 VPPSYS

[AngeloGioacchino Del Regno]

Il 09/11/23 09:21, yu-chang.lee ha scritto:
> Add MT8188 VPPSYS0 and VPPSYS1 driver data.
> 
> Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

Re: [PATCH 2/3] dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS

[AngeloGioacchino Del Regno]

Il 09/11/23 09:22, yu-chang.lee ha scritto:
> Remove VPPSYS0, VPPSYS1 compatible on Mediatek MT8188.
> 
> Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>

The mail recipients are wrong/incomplete. This patch cannot ever possibly get
upstream if you don't Cc the right people/lists.

Please use scripts/get_maintainer.pl to get the right list of recipients and
resend.

Thanks,
Angelo

> ---
>   .../devicetree/bindings/clock/mediatek,mt8188-clock.yaml        | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
> index d7214d97b2ba..860570320545 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8188-clock.yaml
> @@ -43,8 +43,6 @@ properties:
>         - mediatek,mt8188-vdecsys
>         - mediatek,mt8188-vdecsys-soc
>         - mediatek,mt8188-vencsys
> -      - mediatek,mt8188-vppsys0
> -      - mediatek,mt8188-vppsys1
>         - mediatek,mt8188-wpesys
>         - mediatek,mt8188-wpesys-vpp0
>   

Re: [PATCH 2/3] dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS

[Yu-chang Lee (李禹璋)]

On Thu, 2023-11-09 at 10:15 +0100, AngeloGioacchino Del Regno wrote:
> Il 09/11/23 09:22, yu-chang.lee ha scritto:
> > Remove VPPSYS0, VPPSYS1 compatible on Mediatek MT8188.
> > 
> > Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>
> 
> The mail recipients are wrong/incomplete. This patch cannot ever
> possibly get
> upstream if you don't Cc the right people/lists.
> 
> Please use scripts/get_maintainer.pl to get the right list of
> recipients and
> resend.
> 
> Thanks,
> Angelo
> 
Thank for your time and patience, I already resend the same series with
list script provided.

Thanks

Best Regards,
Yu Chang

> > ---
> >   .../devicetree/bindings/clock/mediatek,mt8188-clock.yaml        | 
> > 2 --
> >   1 file changed, 2 deletions(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/clock/mediatek,mt8188-
> > clock.yaml
> > b/Documentation/devicetree/bindings/clock/mediatek,mt8188-
> > clock.yaml
> > index d7214d97b2ba..860570320545 100644
> > --- a/Documentation/devicetree/bindings/clock/mediatek,mt8188-
> > clock.yaml
> > +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8188-
> > clock.yaml
> > @@ -43,8 +43,6 @@ properties:
> >         - mediatek,mt8188-vdecsys
> >         - mediatek,mt8188-vdecsys-soc
> >         - mediatek,mt8188-vencsys
> > -      - mediatek,mt8188-vppsys0
> > -      - mediatek,mt8188-vppsys1
> >         - mediatek,mt8188-wpesys
> >         - mediatek,mt8188-wpesys-vpp0
> >   
> 
> 

Re: [PATCH 2/3] dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS

[Krzysztof Kozlowski]

On 09/11/2023 09:22, yu-chang.lee wrote:
> Remove VPPSYS0, VPPSYS1 compatible on Mediatek MT8188.
> 
> Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>
> ---

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Best regards,
Krzysztof

Re: [PATCH 3/3] dt-bindings: arm:mediatek: mmsys: Add VPPSYS compatible for MT8188

[Krzysztof Kozlowski]

On 09/11/2023 09:22, yu-chang.lee wrote:
> Add VPPSYS0, VPPSYS1 compatible on Mediatek MT8188.
> 
> Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>
> ---

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

Best regards,
Krzysztof

Re: [PATCH 2/3] dt-bindings: clock: mediatek: Remove compatible for MT8188 VPPSYS

[Krzysztof Kozlowski]

On 09/11/2023 12:14, Yu-chang Lee (李禹璋) wrote:
> On Thu, 2023-11-09 at 10:15 +0100, AngeloGioacchino Del Regno wrote:
>> Il 09/11/23 09:22, yu-chang.lee ha scritto:
>>> Remove VPPSYS0, VPPSYS1 compatible on Mediatek MT8188.
>>>
>>> Signed-off-by: yu-chang.lee <yu-chang.lee@mediatek.com>
>>
>> The mail recipients are wrong/incomplete. This patch cannot ever
>> possibly get
>> upstream if you don't Cc the right people/lists.
>>
>> Please use scripts/get_maintainer.pl to get the right list of
>> recipients and
>> resend.
>>
>> Thanks,
>> Angelo
>>
> Thank for your time and patience, I already resend the same series with
> list script provided.

Oh, really? Please point me to this submission where you Cc all
maintainers presented by get_maintainer.pl.

Best regards,
Krzysztof