From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0A541A9FA4 for ; Wed, 1 Apr 2026 14:04:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775052276; cv=none; b=n0JsH7O9Gl0u20BvxT74Pl/lVYq2lsP5OeQNVABmbEacZnEIKcGGIN5L+vCXqzvBOuj92YeInA2gRg7pqk5YlIoAb077GXcikkSe6e2HkIakCO4QZsSDROUevDu5NKr9hrq91A82PYB+SeNbcTgHH+hqom+IZiomE5VTGfsNQII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775052276; c=relaxed/simple; bh=ENBbqPvMtgDBrtNY5Maiukm89IlJO8HyVFmraI/eHfM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OF5QZ3hRILBrygjK6CDFSlwr8WX/Wz8b2N6AHtkKihj9aHED6P2zavy0cuzG87d4lqCfrhis2K2rjjmcE5zusxJKiqri4VHAnIz11KnOk2fsM3GEVX5GE6+uGlOZx3CiblmV7TeKB/ajCM7zqRGjyDhfTK1sz8etFqhd3BPcaE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Nkr5504n; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=OsP54f9/; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Nkr5504n"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="OsP54f9/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775052274; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tcMceLtrrOoF9OBObZDKWhIp/2bPn54+SJ2oUftQ6n8=; b=Nkr5504ngENqFL2Wlw7pZdy441zUgmAPxxhUN/PYKeg2kt3EVoUSzl8Iqs7qAz5WRf+Ecd qoUgwXL5pXolCun33oTksENPs4uBmiMANa+yvPH92qOaPliD/Q3Qe9nT4LOzmZ6Hn0ld5H wOowRjadH5XSwh1+dO83atinCxsg7iY= Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-xQxDnphqM8m-LjbmxjFpLw-1; Wed, 01 Apr 2026 10:04:31 -0400 X-MC-Unique: xQxDnphqM8m-LjbmxjFpLw-1 X-Mimecast-MFC-AGG-ID: xQxDnphqM8m-LjbmxjFpLw_1775052270 Received: by mail-oo1-f69.google.com with SMTP id 006d021491bc7-67de3f8988cso28500985eaf.1 for ; Wed, 01 Apr 2026 07:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775052270; x=1775657070; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=tcMceLtrrOoF9OBObZDKWhIp/2bPn54+SJ2oUftQ6n8=; b=OsP54f9/cRkV5KVwx73LS4B/Kq7ktCySUtk9oZFpaM6W0upTXpY19rwVHfRsavgDEp GE4vL7VsNbVNjWJgDf70xKDWQTw/zWkPiX97MtiG+m+YJoGAwmzTqpfjtAA7H+hf/Nw7 0m2Doue+m/Ih9mYhVFugzbeluApxsdcFLLim/E7FBhjdqiUMmUz4hESiZZNywAJ59fYq mnGcwXv3WtDYFdN5L+5rWUn7yC/v6j3XdWWM6xY3RsjxFwl7bDI8p8E2ogWE5jOokpNX 4dNO+7YcSMFQYjQMlYGklsOXKkXPiwGx+Wphq12pjvI0aPqM/xWnfBJ6BgUVHfEnnlJL T7jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775052270; x=1775657070; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tcMceLtrrOoF9OBObZDKWhIp/2bPn54+SJ2oUftQ6n8=; b=nREuscRvVoirjW1dkK/nI4KsDI8CalGp2YzM/2sm6MbaSywCJamQ4ROzbVI/Fv6Yg+ rcWxkzNvS3FBGw+7v+KlcgS+t43roOLi4rJIUvzLnRmcBnulIKDa2EFZMkwod5berCWJ 1GId6CGZ/GFgknLz1GLha8RS/lYASk/T1eH267AWbProgaX2aLUnVoBcotsA4Ad7cmxa MeBZpTFcrneFgr/BbMpF+y4jTfGkCPsoloTolkcbWF6i34MLk4oj2/JEAc50J63AwAke dxi/ADqSIvij/n/4rMtnIOXE5uiwNd13CbHdpMCFrImXg0oVtbuZV3X5BLrdGr/TGlp2 d9fA== X-Forwarded-Encrypted: i=1; AJvYcCUkaArC/4YKoq/Pfre7I/VRuMVVvkzFL3pblhikFWJhyBED4ZMvXcOPZCtlpY4NfVE8ySOqP748auyC4BQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9gEmG5QXAE2PtKXWNm8c1Gt1oSkRmkkJsxfA+9fXo64vHEvOe +oh2HK1U9AtRowMYHic7DTzgig7yJZBMRIj20yT0fjw+aFM5b6evmwZD9bxjU/kRhteoK5UzkZh JVTKty4V2dkDwC/MCJaTgiSRRwRVNNy6Ui6M2myjMmXa81vXZNCDllmcsgwbc97yEfg== X-Gm-Gg: ATEYQzxlBRB976i4vMq7+kO/Bdol+U6w7AxtipCoI8l3O0jugAHlmcQOW9yF6U4EHY/ ZVFUPAhKU9+wch3+QP97Oy3t5iJ88Bo0WHEuRkB3exOj5zS4qBmEA57x08QjB86Jukl530lFIvp ZDkAJbAHwsPpAaV987j2N+rPKt1AvyO0/yZ3qx3Xhb/34FuaoKCLS88qOMjod+qnCM23+v/kXmZ Yf4ceH+CWaCkHHGYWWmHZp34YOwEE9zGQRfslG8uBQmjpDynUdwBtb+qpUXUjVFoTElTY8eC+Wg TXbEgJptTM9sjCo9NiO+SLl1D52159B2kBvqUOn5pGHsq/zCUmntKfGpyBq2w5ZkwNCK5W8xJ7/ C7iEaeB69ZT1P+viy8Y2CPgbBaTc6of/81j1sKyN5kJWSgKZCOaMxOH/x X-Received: by 2002:a05:6820:4b81:b0:67d:e102:da05 with SMTP id 006d021491bc7-67fabd323a0mr1831343eaf.63.1775052269886; Wed, 01 Apr 2026 07:04:29 -0700 (PDT) X-Received: by 2002:a05:6820:4b81:b0:67d:e102:da05 with SMTP id 006d021491bc7-67fabd323a0mr1831271eaf.63.1775052269221; Wed, 01 Apr 2026 07:04:29 -0700 (PDT) Received: from redhat.com (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-89ecf960d2esm117933246d6.34.2026.04.01.07.04.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 07:04:25 -0700 (PDT) Date: Wed, 1 Apr 2026 10:04:23 -0400 From: Brian Masney To: Miquel Raynal Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Gleixner , Olivia Mackall , Herbert Xu , Jayesh Choudhary , "David S. Miller" , Christian Marangi , Antoine Tenart , Geert Uytterhoeven , Magnus Damm , Thomas Petazzoni , Pascal EBERHARD , Wolfram Sang , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Herve Codina Subject: Re: [PATCH 10/16] clk: Add support for clock nexus dt bindings Message-ID: References: <20260327-schneider-v7-0-rc1-crypto-v1-0-5e6ff7853994@bootlin.com> <20260327-schneider-v7-0-rc1-crypto-v1-10-5e6ff7853994@bootlin.com> <87y0j76p8o.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y0j76p8o.fsf@bootlin.com> User-Agent: Mutt/2.3.0 (2026-01-25) Hi Miquel, On Wed, Apr 01, 2026 at 10:47:51AM +0200, Miquel Raynal wrote: > First, thanks for the whole review. > > On 30/03/2026 at 11:16:44 -04, Brian Masney wrote: > >> - ret = of_parse_phandle_with_args(np, "clocks", "#clock-cells", > >> - index, out_args); > >> + ret = of_parse_phandle_with_args_map(np, "clocks", "clock", > >> + index, out_args); > > > > Before I left my Reviewed-by, I should have double checked Sashiko. It > > has several questions about this patch. The first is: > > > > Are there other places in the clock framework that need to transition to the > > new map API to ensure assigned clocks work? > > > > For instance, assigned-clocks and assigned-clock-parents are parsed in > > drivers/clk/clk-conf.c using of_parse_phandle_with_args(). If a device > > specifies an assigned clock that routes through a nexus node, will it fail > > to configure because the map is not traversed? > > The goal of the nexus node is to isolate what is behind. Are > assigned-clocks et al. supposed to traverse a nexus node? I am tempted > to say "no", but I'm open to discussing this ofc. I agree that it's not needed as well, however I want to defer to Stephen's expertise here. I mainly brought this up trying to help him with reviews. > > https://sashiko.dev/#/patchset/20260327-schneider-v7-0-rc1-crypto-v1-0-5e6ff7853994%40bootlin.com?patch=12563 > > I have mixed feelings concerning Sashiko's feedback. I will go through > that page nevertheless, there are interesting comments in there. I have mixed feelings as well about the feedback from Sashiko. It finds issues, however not all of the feedback has been helpful. On the whole, I'm glad that it's available. Brian