From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F87C83F21 for ; Wed, 30 Aug 2023 19:29:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244602AbjH3TZZ (ORCPT ); Wed, 30 Aug 2023 15:25:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343914AbjH3RNX (ORCPT ); Wed, 30 Aug 2023 13:13:23 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B617FF for ; Wed, 30 Aug 2023 10:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693415601; x=1724951601; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ANfXAO5TdW9bfyaLHG5RVf/5RWD0EfUwUeq0Rle47AU=; b=InkAbp2U41YZx7phOLdlUsNjgiG9mKMubhGRImI7bGtemCj3NUlcJ289 DURiHLCsqMgGCWqs5lSAJO1dOhN4T1Zvs+LzQQzjBvOGN6+kRqVpMj9jD lcctLzgk1z/Ys2VNmtc8aTZZWBE6d4ssM26vzsF4mgioYHjY9S1UIWyDj wkQmJhZdDF/wFZY7/jheYSLMytFc4W9LlZ1Gmb8Mzv/5n4HpyQO5N2udp v2FLSiPp07vGSWORUHAXNI9bn/vGyMkDu1QiHsO2Gc2zq2GmTsgK+emAt CqKVfeFIiJVRtgnf33PDBX/kPuBI8B1pPJKD3X7Ybp934gat4oGfL29x0 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10818"; a="356019140" X-IronPort-AV: E=Sophos;i="6.02,214,1688454000"; d="scan'208";a="356019140" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2023 10:13:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10818"; a="774175297" X-IronPort-AV: E=Sophos;i="6.02,214,1688454000"; d="scan'208";a="774175297" Received: from cunningh-mobl.amr.corp.intel.com (HELO [10.212.55.116]) ([10.212.55.116]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2023 10:13:18 -0700 Message-ID: Date: Wed, 30 Aug 2023 12:13:17 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [PATCH v4 01/11] ASoC: SOF: core: add 'no_wq' probe and remove callbacks Content-Language: en-US To: Maarten Lankhorst , alsa-devel@alsa-project.org Cc: Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Daniel Baluta , linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org References: <20230830153652.217855-1-maarten.lankhorst@linux.intel.com> <20230830153652.217855-2-maarten.lankhorst@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: <20230830153652.217855-2-maarten.lankhorst@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static inline int snd_sof_remove_no_wq(struct snd_sof_dev *sdev) > +{ > + if (sof_ops(sdev)->remove_no_wq) > + return sof_ops(sdev)->remove_no_wq(sdev); > + > + return 0; > +} > /* probe/remove/shutdown */ > + int (*probe_no_wq)(struct snd_sof_dev *sof_dev); /* optional */ > + int (*remove_no_wq)(struct snd_sof_dev *sof_dev); /* optional */ My initial PR didn't have this remove_no_wq() callback. For symmetry it could be useful if it is meant to undo what the probe_no_wq() did, but conceptually the first thing we do in the remove is make sure that workqueue is either not scheduled or we wait until it completes. int snd_sof_device_remove(struct device *dev) { struct snd_sof_dev *sdev = dev_get_drvdata(dev); struct snd_sof_pdata *pdata = sdev->pdata; int ret; if (IS_ENABLED(CONFIG_SND_SOC_SOF_PROBE_WORK_QUEUE)) cancel_work_sync(&sdev->probe_work);