From: Andi Kleen <ak@linux.intel.com>
To: Greg KH <greg@kroah.com>
Cc: kan.liang@linux.intel.com, peterz@infradead.org,
mingo@redhat.com, linux-kernel@vger.kernel.org,
eranian@google.com, namhyung@kernel.org, acme@kernel.org,
jolsa@redhat.com
Subject: Re: [PATCH 2/7] perf: Create a symlink for a PMU
Date: Mon, 28 Jun 2021 08:00:05 -0700 [thread overview]
Message-ID: <ac22e112-7748-e47b-c08d-948ffde130bc@linux.intel.com> (raw)
In-Reply-To: <YNlyYJIl5yki0Q+3@kroah.com>
On 6/27/2021 11:55 PM, Greg KH wrote:
> On Sun, Jun 27, 2021 at 09:30:53AM -0700, Andi Kleen wrote:
>>> Then do not break things by renaming the device name, as you all have
>>> now stated that this name is part of the user/kernel api.
>> The renaming comes from the fallback mode on future systems. In the fallback
>> mode the driver doesn't know the true name, so it has to use the numeric
>> name. If you don't use the fallback mode and have the full driver then yes
>> you'll get the same names as always (or at least as they make sense for the
>> hardware).
>>
>> But we would like to have the fallback mode too to allow more people use
>> uncore monitoring, and that's where the need to for the second name comes
>> in.
> So then just always use the "fallback" name if that is going to be the
> name you have for this hardware device. Why would you want it to be
> renamed later on to a "fancier" name if there is only going to be
> one-per-chipset-type anyway?
It's an ugly numeric name, difficult to use
perf stat -e uncore_0_2//
instead of
perf stat -e uncore_cha//
It wouldn't exactly be an improvement for the full driver.
-Andi
next prev parent reply other threads:[~2021-06-28 15:33 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 1:22 [PATCH 0/7] perf: Add Sapphire Rapids server uncore support kan.liang
2021-06-24 1:22 ` [PATCH 1/7] driver core: Add a way to get to bus devices kset kan.liang
2021-06-24 5:41 ` Greg KH
2021-06-24 1:22 ` [PATCH 2/7] perf: Create a symlink for a PMU kan.liang
2021-06-24 5:48 ` Greg KH
2021-06-24 14:24 ` Andi Kleen
2021-06-24 14:29 ` Greg KH
2021-06-24 15:24 ` Andi Kleen
2021-06-24 15:31 ` Greg KH
2021-06-24 17:07 ` Liang, Kan
2021-06-24 17:35 ` Greg KH
2021-06-24 17:49 ` Andi Kleen
2021-06-25 5:18 ` Greg KH
2021-06-25 5:17 ` Greg KH
2021-06-24 17:28 ` Andi Kleen
2021-06-25 5:19 ` Greg KH
2021-06-25 14:22 ` Andi Kleen
2021-06-25 14:38 ` Greg KH
2021-06-25 14:49 ` Andi Kleen
2021-06-25 15:03 ` Liang, Kan
2021-06-25 15:44 ` Andi Kleen
2021-06-25 15:57 ` Liang, Kan
2021-06-25 16:18 ` Liang, Kan
2021-06-27 11:02 ` Greg KH
2021-06-27 16:30 ` Andi Kleen
2021-06-28 6:55 ` Greg KH
2021-06-28 15:00 ` Andi Kleen [this message]
2021-06-24 1:22 ` [PATCH 3/7] perf/x86/intel/uncore: Create a symlink for an uncore PMU kan.liang
2021-06-24 5:44 ` Greg KH
2021-06-24 1:22 ` [PATCH 4/7] perf/x86/intel/uncore: Add Sapphire Rapids server support kan.liang
2021-06-24 1:22 ` [PATCH 5/7] perf/x86/intel/uncore: Factor out snr_uncore_mmio_map() kan.liang
2021-06-24 1:22 ` [PATCH 6/7] perf/x86/intel/uncore: Support free-running counters on Sapphire Rapids server kan.liang
2021-06-24 1:22 ` [PATCH 7/7] perf/x86/intel/uncore: Fix invalid unit check kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac22e112-7748-e47b-c08d-948ffde130bc@linux.intel.com \
--to=ak@linux.intel.com \
--cc=acme@kernel.org \
--cc=eranian@google.com \
--cc=greg@kroah.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox