From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Fix the GCC version check for `__multi3' workaround
Date: Wed, 1 Apr 2026 22:30:28 +0200 [thread overview]
Message-ID: <ac2AZPDScM4Nlft5@alpha.franken.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2603300218310.60268@angie.orcam.me.uk>
On Mon, Mar 30, 2026 at 02:54:09AM +0100, Maciej W. Rozycki wrote:
> It was only GCC 10 that fixed a MIPS64r6 code generation issue with a
> `__multi3' libcall inefficiently produced to perform 64-bit widening
> multiplication while suitable machine instructions exist to do such a
> calculation. The fix went in with GCC commit 48b2123f6336 ("re PR
> target/82981 (unnecessary __multi3 call for mips64r6 linux kernel)").
>
> Adjust our code accordingly, removing build failures such as:
>
> mips64-linux-ld: lib/math/div64.o: in function `mul_u64_add_u64_div_u64':
> div64.c:(.text+0x84): undefined reference to `__multi3'
>
> with the GCC versions affected.
>
> Fixes: ebabcf17bcd7 ("MIPS: Implement __multi3 for GCC7 MIPS64r6 builds")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202601140146.hMLODc6v-lkp@intel.com/
> Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
> Cc: stable@vger.kernel.org # v4.15+
> ---
> arch/mips/lib/multi3.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
applied to mips-fixes
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2026-04-01 20:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 1:54 [PATCH] MIPS: Fix the GCC version check for `__multi3' workaround Maciej W. Rozycki
2026-03-30 9:46 ` David Laight
2026-03-30 10:09 ` Maciej W. Rozycki
2026-03-30 11:52 ` David Laight
2026-04-01 20:30 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac2AZPDScM4Nlft5@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox