From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7C4C91A0B15; Wed, 1 Apr 2026 20:30:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.175.24.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775075456; cv=none; b=VYTdX0p96vYzJ1ypRJLHZPd+ZM9uBXa0dpiy3v31J/ZactO4B+G32+vqJeJuapzk3vSa4z2iMMLH8f9TDLRZ4cH/tZ7nsl9EvVsR8JlP6o08kQW9+djIxpsumYJqwSTVctskLgRsOz3ztAzDWIJHJ/3RkUd7oeL/MLeNTOUagzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775075456; c=relaxed/simple; bh=JpBx18Gt2PrHk2QtesQSNQ4tjuv1KnomDhSxJHrVhKg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CfPQM50+T1jtzAYvutT4d9oIjLVH7FeZrEx0pLmzi9CAfXg8chDrWKf1LwQdUVNJuT8hiIolVmduPEglrNjsYPuQcjZjtjSDBf1n5WSWArWJwE7Ak/eyy2jwd5VugIKkLS76zDi9pz/QZuo/JMJjyGlAUOV9StaTOFdKuC6cy5I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de; spf=pass smtp.mailfrom=alpha.franken.de; arc=none smtp.client-ip=193.175.24.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alpha.franken.de Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1w82D7-0008HD-00; Wed, 01 Apr 2026 22:30:45 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 1D265C0DC9; Wed, 1 Apr 2026 22:30:28 +0200 (CEST) Date: Wed, 1 Apr 2026 22:30:28 +0200 From: Thomas Bogendoerfer To: "Maciej W. Rozycki" Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: Fix the GCC version check for `__multi3' workaround Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Mar 30, 2026 at 02:54:09AM +0100, Maciej W. Rozycki wrote: > It was only GCC 10 that fixed a MIPS64r6 code generation issue with a > `__multi3' libcall inefficiently produced to perform 64-bit widening > multiplication while suitable machine instructions exist to do such a > calculation. The fix went in with GCC commit 48b2123f6336 ("re PR > target/82981 (unnecessary __multi3 call for mips64r6 linux kernel)"). > > Adjust our code accordingly, removing build failures such as: > > mips64-linux-ld: lib/math/div64.o: in function `mul_u64_add_u64_div_u64': > div64.c:(.text+0x84): undefined reference to `__multi3' > > with the GCC versions affected. > > Fixes: ebabcf17bcd7 ("MIPS: Implement __multi3 for GCC7 MIPS64r6 builds") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202601140146.hMLODc6v-lkp@intel.com/ > Signed-off-by: Maciej W. Rozycki > Cc: stable@vger.kernel.org # v4.15+ > --- > arch/mips/lib/multi3.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) applied to mips-fixes Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]