From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 383B73659FD for ; Wed, 1 Apr 2026 21:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775077858; cv=none; b=TOPIbCvuBa78lTUTfmPdVXC5YxALZsha5AXyO/DPuMyMXxAcjuXpXkZLQlLuLr14wpnWOvnpUQlFvPMJ0moMu+B4oG/IU+pJrj3KBpgu7OTU+xe5J8CndrSiXUCApmjFP4ibXNGm34Cea7w0TExYs9Cmk84DNMqMA2mpeCwsbXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775077858; c=relaxed/simple; bh=Vpg1SAbV+OBv9XruLKGqKVEqdfAjpddHK3qKRpVtsw8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=COcjPESYLsVnFZWRBTna2o4YE26n44mw4S1+xdyfhnoOuAyJyAaIgYwt5YhHavpWMWe9FCg0UzlMcJvfDS33L0RcuOVc+bjI/afgfLpxQ5E470DkiuUtFmrK8HSz3/i2t3X2GSyMPVyLfqRTdtza7U3uH8IbQqaxalwPcetc+U0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org; spf=pass smtp.mailfrom=cmpxchg.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b=dJBgLw+B; arc=none smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cmpxchg.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg.org header.i=@cmpxchg.org header.b="dJBgLw+B" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-506a7bbe9d0so1436771cf.0 for ; Wed, 01 Apr 2026 14:10:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg.org; s=google; t=1775077854; x=1775682654; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TMu03LY0qCZzLGL1WuHCBvpS1SQA/t8qDMGzWzp1NCk=; b=dJBgLw+BB3jfBvA8NLrPAYVnQLpuJ3+zTIF6+ymFcgcgMtRDoboXJqGdJnJqaDal4O Mrx160xQBK/ME+ulwgnduBmoyEITw2wU98llFc3XykLXIY0Qo31O71UVa/gAzq1YoIet tt8P4Vt7Ftrym7t7Pdj309GUTza9xPIC1ZFGVN4rKR5dF/yNdNs55IkyUJsA9cJ9YwY/ JywJtrMzgfooRsacQAlzDD+btSfbDqOoVw217wiph9dKmDe1vJvNgopK3brE3d+D3BcP kJIGbxbwvw2NtnVJemBVuQghE4h3beyM7KkFQFNPu/IdqUbl6ohG5fRGT73vEHFfoPhC wB8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775077854; x=1775682654; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TMu03LY0qCZzLGL1WuHCBvpS1SQA/t8qDMGzWzp1NCk=; b=S8K5z2YdzFR6IM3TAvNX1ovPfsw6iTM5Ea6PM3MSqLf7sIof/FBZMXn359O1T2I8dM XazTYKjfJPzJd3AH1pPrERo4dAlk7e3z6QLB3gifm4ppl/KS6TjcrZFoJX47wHnsJMlX 2faMd8OvZgQOrjDl/mtj1BEvqGIXI7LBiz1t+B96JBIhJWxZIWBJ/Cxw6iDMWybhrDy7 0WX26n9rmlwiGhZ3eq6zzjBFLSebRIz+Ia4IZEKirbz9QjWhg5KURZ2ZQaCvNFrBZLz8 bG62M3QtPZLZcW6oA7PWXVaQtkCSw7VrQ5yFNw9s6n5bpQI3hAlBlGKZFuM48AqREF1H +d6A== X-Forwarded-Encrypted: i=1; AJvYcCU48VaxXcCsZMtVNRj2QM/Pz5kclkCXtU/Lee4Ko1Jro8v2UwCRKutPBsb040RkL82YXIjJcEaCfoXrVIM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2DKCFk/P+Si/+IL52CQTY2j3YvdtQiMs0mEq90+9vv09bEqIu kXrNgITpHkVzWAZ7+vEeY4ha5EBQXjH8yZ3tyJqrsuKlBj6LXatHWrQq206nWG+TLkg= X-Gm-Gg: ATEYQzzuuK6ZVPxCvxdm+VfAjDk7FrBTu1HGpuOvYrIkUSGBC0wcEwgfPjzM1wDgvJV VcGC3+3EbceT+ysna6zqBWoK3zI1dEb97jpPqGApE4Np+CatnSzozQ+0rCnOkQST8u/SoiBcVCR lrwOGMx/4ujilZ5MCTQ1k2XKoUh1TNUFSwjZmYCQRYoDshmQPgjYei0wLcRVWG3IN6E+hjMj1Ja gHw/MMyGPXbscXCG9AEVaI/PVdz+pCYZXxoj2zTIELdSjMUWbR02AQF3z5nkduxdlMDGF+UHBSn spHU2QctYzVMvWUJslHRlLVe7Z4QdWRF3HP5uLrzar9fmnhAMCBk7U+MtywLhKiUerERWGoo7/S 9Fi2zRD9tAZ182GwLXYYn/nJgIN9Ec12lmZmNvFdkFG55ji+PNeNTQiSI9LcjH/5S76EmMv9WZR r+f5OEWnhAcPpXyQ/DAHlIn38JF9meIloH X-Received: by 2002:ac8:5781:0:b0:509:14f6:9841 with SMTP id d75a77b69052e-50d4bb2f25cmr17195691cf.31.1775077853897; Wed, 01 Apr 2026 14:10:53 -0700 (PDT) Received: from localhost ([2603:7000:c00:3a00:365a:60ff:fe62:ff29]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8a593331651sm6771496d6.10.2026.04.01.14.10.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 14:10:53 -0700 (PDT) Date: Wed, 1 Apr 2026 17:10:52 -0400 From: Johannes Weiner To: "JP Kobryn (Meta)" Cc: linux-mm@kvack.org, akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, Liam.Howlett@oracle.com, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, kasong@tencent.com, qi.zheng@linux.dev, shakeel.butt@linux.dev, baohua@kernel.org, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, riel@surriel.com, kuba@kernel.org, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH] mm/vmpressure: skip socket pressure for costly order reclaim Message-ID: References: <20260401203752.643259-1-jp.kobryn@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260401203752.643259-1-jp.kobryn@linux.dev> On Wed, Apr 01, 2026 at 01:37:52PM -0700, JP Kobryn (Meta) wrote: > @@ -307,7 +308,7 @@ void vmpressure(gfp_t gfp, struct mem_cgroup *memcg, bool tree, > > level = vmpressure_calc_level(scanned, reclaimed); > > - if (level > VMPRESSURE_LOW) { > + if (level > VMPRESSURE_LOW && order <= PAGE_ALLOC_COSTLY_ORDER) { I think a comment would be in, ahem, order. Once we go above COSTLY_ORDER, reclaim relies heavily on compaction to make progress. Reclaim efficiency was never a great proxy for pressure to begin with, but it's outright misleading with these high orders. Don't throttle sockets because somebody is attempting something crazy like an order-7 and predictably struggling.