From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0CB63264E0 for ; Thu, 2 Apr 2026 05:17:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775107057; cv=none; b=luMgIEtuiOPN3q7eJZWHhWMQyNvAS1V5sN3EBNQ6PIkoKVF/XrHzBZA8DsjPm7MF8ws/8Zg+h4nTaQ+ZMejjWouNlFLM0ZI5pKKR7yNpYxJPa6GQGY2mZYE2Lq+EylxDGeu3jm367VLnX5/niN+Em4NwB2YxDInfkE+DcAfw7eQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775107057; c=relaxed/simple; bh=ZCXnOByptGSWhtsn3L5uQ7eNiLXMPx1Bs9taTz+3lqA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LoD2KSFmJjsU8wUVFScYoDI+K8zU69nudAHhibe+sqXTO4fLJTKo3H+HYlxfsThCF6eAwrtzUDLLI7PkBmu5cERAlkXblGZ7vNy3hcDd76Pjnqysu94PCUSLB1km8r4CRWsMveJrsDtYdr7y9QWvKDFDPZxuwMisoWvwDzFSsUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Li3ixfUZ; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Li3ixfUZ" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2c5b3d8eab1so1448104eec.1 for ; Wed, 01 Apr 2026 22:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775107056; x=1775711856; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SxnWxLrLSCSrbUl5981R8JEjXR3s+V1Z+NsBygeyHN4=; b=Li3ixfUZVbNU1R2SA2VwEv8mp14Ybvk2/HY36pLyIDHhBntaUwRSVcLGgJr2qpFfCk rNn0RRjGIrSHyMoqh1gQrk9J8NsnoShLwmqsRanO8BvFVMmMn9p1TcF3YhVkdC0/2cRN dIWCWlzE5+tbp8FGm2JjJt93gBHm5Yf5HAAknQkex6u5luWEu1j+7kPK0mU/gFRvN+qi JCF01ihtvrDQx32g6CKjqLX/hsArHnQRWZsEUmGdncG7etplnGbZREIf+FGb2d+TZIhs ccKbtas9oRQLB/se4BAvm7K0WUTazBp7tpYyRkl9h9Fln0LRKVNAa9Y9Tb3Sg1ocY18S ytIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775107056; x=1775711856; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SxnWxLrLSCSrbUl5981R8JEjXR3s+V1Z+NsBygeyHN4=; b=cR+CqurPgUkkmRoQ9mDM2rh7NdzGPCIbJvPC+C/4mg2Md/nuB0ZaDf5VQanalnUDbC lAKruwJ6mrO8smgn3C+ZdrFeLwvmtoUihKh2rUCjhz2fyD+i4rcV1EnUNEpbyGag0kQU DaXCWNLml8pYnv71737RNj2Bs26iRxCSv/VsZUJPAMgmK9a6HPOBqgFF0aMyzevpOEop Hh2SNdO2NjxsbzbNhwvvcO2k9Om4ZyZ4LtMSk1qRpv/JpTPWgKTelxAkkaOZCix9LfeJ QxGlXv+dhUPgyT+RSVPJxWrTIgXppECs7VNKT3rA+er8/q8EKTUeEThG/y197JtcBqkg 9QJA== X-Forwarded-Encrypted: i=1; AJvYcCWWGkTleAefwrhCc9dYcP+J9wOSJo9Si3OJ1zloJuohOsJSbbOyAsJogxuMAKpBZpTGu/lY/ymlxC2JRH4=@vger.kernel.org X-Gm-Message-State: AOJu0YzPPLiSj99T4CEO8SwXK9+PRiFrMEbByolWILl3sE+Eumz+Zd+v xcXVOUvaUpNdZXBFO90n0KNnF0Fyr4v3QYMvNc6zFej+HUKnRNF24VPk X-Gm-Gg: ATEYQzxQVgQXnMOvW0+bcYB+D4ACTXdaryvUP9GyiqMM3uRG8BJVVd8hbLl/kykA/ns oB6nOXhrtVUwf5pvKGbcvraztzCPzQNXaGw3V9Hu7p91pRwVh+PSVP+XqM2Ncd57+iYshhZkAqn tKEDZFBAUxCk3ueiYOvaReu4XO3KYSPkHZybP+6gyFWFSsFcmocD+q1iZ14cfKNLr3pGnNrHLDh bTd4q0FCpbiuCqGEq+ndK3DXQmEIc9fkaMrUwD8E2wsbVaSEvSk6OZKkG4X5Vru24yYoo5bu9Ag O0i95rrX3PvXEIdtagfeoRwZcXeYB/PT25uLXD46kFuoR3nw3kWXHDjPM8TSVNS7w6aC9eJyK/O w68B1CP3wsQtIlkBs8FyYsZZoDuTQ8c4s2OMOt4hcAj9kkQfOoDjoBcdGYR2lGF8I6CjiQDhR15 SRG+tT7EVzeUmAoADN7duW5/qkf8ArfmYNKToIkL/eLlLlxcfAAn+f9iRh4Grf9RHO X-Received: by 2002:a05:7301:fa0d:b0:2c1:6676:5ebd with SMTP id 5a478bee46e88-2c930e6b1fbmr3332040eec.10.1775107055635; Wed, 01 Apr 2026 22:17:35 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:5f38:4c97:ec41:caa0]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ca7c20c151sm1701575eec.19.2026.04.01.22.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 22:17:34 -0700 (PDT) Date: Wed, 1 Apr 2026 22:17:31 -0700 From: Dmitry Torokhov To: phucduc.bui@gmail.com Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Wolfram Sang , Jeff LaBundy , Bastian Hecht , Javier Carrasco , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] input: touchscreen: st1232: add system wakeup support Message-ID: References: <20260306104025.43970-1-phucduc.bui@gmail.com> <20260306111912.58388-1-phucduc.bui@gmail.com> <20260306111912.58388-4-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260306111912.58388-4-phucduc.bui@gmail.com> On Fri, Mar 06, 2026 at 06:19:12PM +0700, phucduc.bui@gmail.com wrote: > From: bui duc phuc > > The ST1232 touchscreen controller can generate an interrupt when the > panel is touched, which may be used as a wakeup source for the system. > > Add support for system wakeup by initializing the device wakeup > capability in probe() based on the "wakeup-source" device property. > When wakeup is enabled, the driver enables IRQ wake during suspend > so that touch events can wake the system. > > If wakeup is not enabled, the driver retains the existing behavior of > disabling the IRQ and powering down the controller during suspend. I do not believe this patch is needed: i2c core already handles "wakeup-source" property and manages wakeup IRQ. Thanks. -- Dmitry