The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Madhavan Srinivasan <maddy@linux.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] KVM: PPC: remove unnecessary #ifdef
Date: Sun, 22 Nov 2026 09:38:20 +0530	[thread overview]
Message-ID: <ac3d60d5-1bd3-4f60-9933-e03af7323162@linux.ibm.com> (raw)
In-Reply-To: <20261120133413.475489-1-pbonzini@redhat.com>

++linuxppc-dev

On 11/20/26 7:04 PM, Paolo Bonzini wrote:
> booke.o is only built as part of kvm-e500-objs (which is conditional
> on $(CONFIG_KVM_E500V2)) or kvm-e500mc-objs (likewise conditional
> on $(CONFIG_KVM_E500MC)).  Thus, the #ifdef in kvmppc_core_check_requests
> is always true.  Remove it.
yes kvmppc_core_flush_tlb() is defined in e500_mmu.c which is 
unconditionally linked in
both e500 config (kvm-e500mc-objs and kvm-e500-objs)
Nice catch. Thanks for the patch

Queued via PPC tree.

Maddy


> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   arch/powerpc/kvm/booke.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
> index fd7f24a68b31..ba762ac1fb56 100644
> --- a/arch/powerpc/kvm/booke.c
> +++ b/arch/powerpc/kvm/booke.c
> @@ -738,10 +738,8 @@ int kvmppc_core_check_requests(struct kvm_vcpu *vcpu)
>   
>   	if (kvm_check_request(KVM_REQ_PENDING_TIMER, vcpu))
>   		update_timer_ints(vcpu);
> -#if defined(CONFIG_KVM_E500V2) || defined(CONFIG_KVM_E500MC)
>   	if (kvm_check_request(KVM_REQ_TLB_FLUSH, vcpu))
>   		kvmppc_core_flush_tlb(vcpu);
> -#endif
>   
>   	if (kvm_check_request(KVM_REQ_WATCHDOG, vcpu)) {
>   		vcpu->run->exit_reason = KVM_EXIT_WATCHDOG;

      parent reply	other threads:[~2026-11-22  4:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 13:34 [PATCH] KVM: PPC: remove unnecessary #ifdef Paolo Bonzini
2026-11-22  3:43 ` Ritesh Harjani
2026-11-22  4:08 ` Madhavan Srinivasan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac3d60d5-1bd3-4f60-9933-e03af7323162@linux.ibm.com \
    --to=maddy@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox