From: Kay Sievers <kay.sievers@vrfy.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
dbrownell@users.sourceforge.net, bjorn.helgaas@hp.com,
Alessandro Zummo <a.zummo@towertech.it>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg KH <greg@kroah.com>
Subject: Re: [PATCH] RTC: mark if rtc-cmos drivers were successfully registered.
Date: Mon, 20 Jul 2009 22:32:06 +0200 [thread overview]
Message-ID: <ac3eb2510907201332i25ea109t981425451eafd4e1@mail.gmail.com> (raw)
In-Reply-To: <20090720131959.3b157627.akpm@linux-foundation.org>
On Mon, Jul 20, 2009 at 22:19, Andrew Morton<akpm@linux-foundation.org> wrote:
> On Sun, 5 Jul 2009 01:07:59 -0300
> Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com> wrote:
>
>> rtc-cmos has two drivers, one PNP and one platform. When PNP has not
>> succeeded probing, platform is registered. However, it tries to
>> unregister both drivers unconditionally, instead of only unregistering
>> those that were successfully registered. Fix that with a boolean
>> variable for each driver indicating whether registering was successful.
> This came up a few weeks ago - the kernel was actually crashing deep
> down in the driver core, when a not-registered device was unregistered.
>
> I believe Kay was planning on making the driver core more robust, so
> that crash shouldn't be happening any more. Kay, can you please confirm
> that thsi got fixed?
This is supposed to fix it:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=5c8563d773c0e9f0ac2a552e84806decd98ce732
Thanks,
Kay
next prev parent reply other threads:[~2009-07-20 20:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-05 4:07 [PATCH] RTC: mark if rtc-cmos drivers were successfully registered Thadeu Lima de Souza Cascardo
2009-07-20 20:19 ` Andrew Morton
2009-07-20 20:32 ` Kay Sievers [this message]
2009-07-20 20:57 ` Thadeu Lima de Souza Cascardo
2009-07-20 21:07 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac3eb2510907201332i25ea109t981425451eafd4e1@mail.gmail.com \
--to=kay.sievers@vrfy.org \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=cascardo@holoscopio.com \
--cc=dbrownell@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox