From: Jiri Slaby <jirislaby@kernel.org>
To: Yenchia Chen <yenchia.chen@mediatek.com>,
gregkh@linuxfoundation.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com
Cc: yj.chiang@mediatek.com, tbergstrom@nvidia.com,
yujiaoliang@vivo.com, u.kleine-koenig@baylibre.com,
treapking@chromium.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] serial: 8250_mtk: Add ACPI support
Date: Tue, 14 Jan 2025 08:35:56 +0100 [thread overview]
Message-ID: <ac3f0efe-c197-4279-9b73-5d7dd3f300fc@kernel.org> (raw)
In-Reply-To: <79ad2e41-3d27-4dfd-9136-cb0867cb1a36@kernel.org>
On 14. 01. 25, 8:31, Jiri Slaby wrote:
>> @@ -560,16 +566,22 @@ static int mtk8250_probe(struct platform_device
>> *pdev)
>> uart.port.private_data = data;
>> uart.port.shutdown = mtk8250_shutdown;
>> uart.port.startup = mtk8250_startup;
>> - uart.port.set_termios = mtk8250_set_termios;
Wait, ::set_termios() is NOT optional.
--
js
suse labs
next prev parent reply other threads:[~2025-01-14 7:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 3:33 [PATCH] serial: 8250_mtk: Add ACPI support Yenchia Chen
2025-01-14 7:31 ` Jiri Slaby
2025-01-14 7:35 ` Jiri Slaby [this message]
2025-01-16 3:53 ` Yenchia Chen
2025-01-15 19:45 ` kernel test robot
2025-01-16 12:16 ` Jonathan Cameron
2025-01-15 20:48 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac3f0efe-c197-4279-9b73-5d7dd3f300fc@kernel.org \
--to=jirislaby@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=tbergstrom@nvidia.com \
--cc=treapking@chromium.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=yenchia.chen@mediatek.com \
--cc=yj.chiang@mediatek.com \
--cc=yujiaoliang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox