Re: [PATCH v2 1/2] lib/vsprintf: always advance args in bstr_printf() pointer path

[Kuan-Wei Chiu <visitorckw@gmail.com>]

Hi Steven,

On Tue, Mar 31, 2026 at 10:47:08AM -0400, Steven Rostedt wrote:
> On Tue, 31 Mar 2026 09:26:46 +0200
> Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
> > On 30/03/2026 21:34, Josh Law wrote:
> > > When the output buffer is full (str >= end), bstr_printf() skips
> > > advancing the args pointer past the pre-rendered pointer string in
> > > bin_buf. This causes all subsequent format specifiers to read from
> > > the wrong position, corrupting the rest of the output.
> > > 
> > > Always compute the string length and advance args regardless of
> > > whether there is space to copy into the output buffer.
> > > 
> > > Signed-off-by: Josh Law <objecting@objecting.org>  
> > 
> > NAK
> > 
> > Questionably origin (multiple identities used), questionable content.
> 
> Can you expand further on this complaint?
>
You can check out the related discussion in this email thread [1]. It's
mainly about a recent controversy regarding AI-generated kernel
contributions.

[1]: https://lore.kernel.org/lkml/cbd0aafa-bd45-4f4d-a2dd-440473657dba@lucifer.local/

Regards,
Kuan-Wei