From: sonofagun@openmailbox.org
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, Nikos Barkas <levelwol@gmail.com>
Subject: Re: [PATCH] x86/AMD: Apply erratum 688 on machines without a BIOS fix
Date: Sat, 22 Oct 2016 00:51:32 +0300 [thread overview]
Message-ID: <ac4f6408af04006ed7b6aa6c91582847@openmailbox.org> (raw)
In-Reply-To: <20161021164723.c5rh7kgulba2aq6i@pd.tnic>
Thank you for your time! I have chosen reply to list and all recipients,
it must work now.
My brother rejected the proposed patch because it does not provide
equivalent functionality with the original.
Our initial patch would fix 3 broken models and 1 working model. Your
patch will only work for 1 model. Only machines having our APU will be
fixed. All B0 APUs will be unpatched. This is not right. Check the
revision guide to verify that.
To avoid unneeded complexity we propose this patch as V2, do you agree?
+#define MSR_AMD64_IC_CFG 0xC0011021
+
+static void init_amd_on(struct cpuinfo_x86 *c)
+{
+ /*
+ * Apply erratum 688 fix so machines without a BIOS
+ * fix work.
+ */
+
+ u32 val = pci_read_config(0, 0x18, 0x4, 0x164);
+
+ if (!(val & BIT(2))) {
+ msr_set_bit(MSR_AMD64_IC_CFG, 3);
+ msr_set_bit(MSR_AMD64_IC_CFG, 14);
+}
static void init_amd_bd(struct cpuinfo_x86 *c)
{
u64 value;
@@ -738,6 +750,7 @@ static void init_amd(struct cpuinfo_x86
case 0xf: init_amd_k8(c); break;
case 0x10: init_amd_gh(c); break;
case 0x12: init_amd_ln(c); break;
+ case 0x14: init_amd_on(c); break;
case 0x15: init_amd_bd(c); break;
}
Please advice to proceed!
> Why, what's wrong with that one? That one should be all fixed! :-)
>
> I have such box too and it runs fine.
erratum 721 :-(
next prev parent reply other threads:[~2016-10-21 21:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 16:19 [PATCH] x86/AMD: Apply erratum 688 on machines without a BIOS fix sonofagun
2016-10-21 16:47 ` Borislav Petkov
2016-10-21 21:51 ` sonofagun [this message]
2016-10-21 23:01 ` Borislav Petkov
2016-10-22 11:16 ` sonofagun
2016-10-22 14:12 ` Borislav Petkov
2016-10-23 9:39 ` sonofagun
2016-10-23 9:57 ` Borislav Petkov
2016-10-23 17:06 ` sonofagun
2016-10-23 17:25 ` Borislav Petkov
2016-10-23 21:02 ` sonofagun
2016-10-23 21:39 ` Borislav Petkov
2016-10-24 11:38 ` sonofagun
2016-10-24 9:35 ` Borislav Petkov
2016-10-24 13:13 ` sonofagun
2016-10-24 17:14 ` Borislav Petkov
2016-10-24 20:39 ` sonofagun
2016-10-25 9:29 ` Borislav Petkov
2016-10-25 13:16 ` sonofagun
2016-10-28 16:21 ` Borislav Petkov
2016-10-31 21:54 ` sonofagun
2016-10-31 22:59 ` Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2016-10-19 13:58 sonofagun
2016-10-19 15:00 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac4f6408af04006ed7b6aa6c91582847@openmailbox.org \
--to=sonofagun@openmailbox.org \
--cc=bp@alien8.de \
--cc=levelwol@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox