[PATCH v2] ata: pata_arasan_cf: fix missing newline in dev_err() messages

[PATCH v2] ata: pata_arasan_cf: fix missing newline in dev_err() messages

[Haoyu Lu]

Add missing trailing newlines to dev_err() messages in pata_arasan_cf.c.

This keeps the error output as properly terminated log lines.

Reviewed-by: Viresh Kumar <vireshk@kernel.org>
Signed-off-by: Haoyu Lu <hechushiguitu666@gmail.com>
---
Changes in v2:
- Change subject to include parentheses in dev_err()
- Add Reviewed-by tag from Viresh

 drivers/ata/pata_arasan_cf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
index 514d549286b5..abcdef123456 100644
--- a/drivers/ata/pata_arasan_cf.c
+++ b/drivers/ata/pata_arasan_cf.c
@@ -380,7 +380,7 @@ static int arasan_cf_xfer(struct arasan_cf_dev *acdev, struct ata_queued_cmd *qc
 	if (!wait_for_completion_timeout(&acdev->cf_completion, TIMEOUT)) {
 		u32 rw = acdev->qc->tf.flags & ATA_TFLAG_WRITE;

-		dev_err(acdev->host->dev, "%s TimeOut", rw ? "write" : "read");
+		dev_err(acdev->host->dev, "%s TimeOut\n", rw ? "write" : "read");
 		return -ETIMEDOUT;
 	}

@@ -474,7 +474,7 @@ static int arasan_cf_xfer(struct arasan_cf_dev *acdev, struct ata_queued_cmd *qc
 			dma_len = min(xfer_cnt, FIFO_SIZE);
 			ret = dma_xfer(acdev, src, dest, dma_len);
 			if (ret) {
-				dev_err(acdev->host->dev, "dma failed");
+				dev_err(acdev->host->dev, "dma failed\n");
 				goto fail;
 			}

--
2.17.1

Re: [PATCH v2] ata: pata_arasan_cf: fix missing newline in dev_err() messages

[Niklas Cassel]

Hello Haoyu,


This patch is still appears to be based on a downstream kernel.
(Which downstream kernel are you using btw?)

Please use a mainline kernel:
git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
or
git clone git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux.git


Also, Viresh provided an Acked-by, not a Reviewed-by:
https://lore.kernel.org/linux-ide/ac4ojZl_qe3NXwwi@ryzen/T/#mb2b5ed70f1b4256fe3c675b539c1791249e08d22


Kind regards,
Niklas