From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A5C13DA5AF for ; Thu, 2 Apr 2026 10:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775125206; cv=none; b=e+e5VCFFs7Cw8iINKIgBy7PwuGXXZj20O9/CVd2dmqxh5nZQOnTixrSh10pE+9Klc5/owTnyKavv8/8B7C8AbyyZ9UPg7XwYu0Q3418Gg/3AwHpK2EDWH/dbA5Vwrb3eE+XdQqsScFyAvl/C7plNlwFcyH9OICLYWvoQffVoXac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775125206; c=relaxed/simple; bh=C97VEa+NVtr1a+zTAOjF7qbw7z5ErHahekcY3LMMzjQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fEADotXGOE+b7Ejxl8LIY5cA3HD8lNnISbeNIplisIKNrCR9WvpXHtYvvRzEoTZAexlwH2hbSlPklMX65w6U4YN5O/bZWjMkyw46Z6CrAZQVrih4CeaYCOIpUiMMSbMZgnC+FXjGOCfuSCoxKF9uYCB+dRthj3yObP3NXYr09mo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UrT0u4aJ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=kNRjvj9y; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UrT0u4aJ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="kNRjvj9y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775125203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R9FNAq6JXxyYmLFJe3V/l1GPxm6IdqNxZH3xpVlwE3k=; b=UrT0u4aJcIEPHUOf9domdQgQG91IqHo2qLmEA3CoKX8d12wCdO0bxHz8OnvSxU/HF60B6H evRU6gJsHS7haYKMymEiXceMM4bsJcQQIerYf6gAMXL/rTS3oEe+uReMvCqfBTEZDlDNex dsl8e8CZqqcBXhoCOPuqoaT1L0XYSVA= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-34-cX_83Q-wMci_nbIWVmQL0Q-1; Thu, 02 Apr 2026 06:20:02 -0400 X-MC-Unique: cX_83Q-wMci_nbIWVmQL0Q-1 X-Mimecast-MFC-AGG-ID: cX_83Q-wMci_nbIWVmQL0Q_1775125201 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b2523e0299so19858965ad.3 for ; Thu, 02 Apr 2026 03:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1775125201; x=1775730001; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=R9FNAq6JXxyYmLFJe3V/l1GPxm6IdqNxZH3xpVlwE3k=; b=kNRjvj9yiFQWTmwG/KTDnmcx/HtqjW+9dc4qKa4IlbqCLf+aiE9HAjybGN73a2yHhK XZGJK8vjmWwqrTR7i5eWXlTYyY2U9b1IcS6f0poGK7V6y4acTVgXuYLY/PWn21DfjgQe rWJQ6Cfk5cEzrQ9KlPtwVqAsmuCJG1RFZPe9807+6fWPcwC/e5J+vWX7XfimdhAIQSIS SVzKgcaMXPJKNMU1X8WQIOIAlpu5eSzju1J/7d0ze55pN+4c2QDsN9I8Dy4rUtBuYicz 8hUkKEcapI6muqdHNI6E6zxRDZUJ6y0oVxmRjzbtifttYaCV8vhHXTSdQEeeKeciFFO2 weGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775125201; x=1775730001; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R9FNAq6JXxyYmLFJe3V/l1GPxm6IdqNxZH3xpVlwE3k=; b=ddjGIjKHdP0hIaWk0vQjGN/nlXsBr7AflYtKpMOKJ76Gh913thMK4CVZMNAJxjAgcC qJerpchh38TPElutCSmazw3Vp98R63FUny858GQgP3gsAkUPQsFVUWSaXEQ2Td78iJxR uAGyUf1TsGE3gVH0thqncsd7XKu2LWSfqDA85Jf8o1Z/PqiNcjKZ2Gfc3latXoMiA3Sh AhASNHg1kNCJtlNPJP2lzt+/3kjZVyauTjxMMSVBCW/2b8fvqswyJoAhRkDaqYUHfzc8 cLle6LlpjPeETkS3OSzGpDiEIkqK0Lax8cH+msDu1yP5K59KL7IW7c8rI7GiY7zijYck IjRg== X-Forwarded-Encrypted: i=1; AJvYcCVBFh2s4ZlITNLgdVw/DCjZAEvTPPKq0yJNBGrZz8dmOU+a/pjObct0nd+GOqgleTNv7KICKG5TFsWSyoc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3FHYBtJjJreFXmVHBnlGj/MhjT8/+GdqVmgedLfwZ0mGIHayX 3BTTkWZMbrSZlRqZjQlAfIOEB3Z17NDsgPcCpl0km4A5LDGsNgWZrV/8ktKuG1NmFufO4s1/Fqw TfM5eI1FER9bjWkfaI0Ia/bXME+n01WdAbSxIxXpYzcGTCmVcDwZam9HpLq+QNv7eaw== X-Gm-Gg: AeBDieuFMP50we4eeLQlKLdLAi1A/uUiAGmpUHj1lY7begNn7t4ITu0aH/aE6FEG6oS +gynTYGs5Lo/HBQWxUNzvLFUYGp3eozZCBcukZcP2yg2zgm9YavyD9xHtL1ih1KUosPUc8G05VW KUKh9Zd52ZQadrGanqBKOl/031rW1TjU9sUDnm+wo/dCkSn95mWefKeP9+URqa2sQsrCaF1dOn+ +RKtOpcIawreckWcMpiy5AbpxVjlOJfUOXHSHlEIs5QvJO1wFgFTggvS6fMugrQUAbWYZvm4aUx upkih1Tg0d+/V91bs/3M0EsmSRVg9+bSVkJI4vmqO31ivYEo+mqzNrrLlOo1LMZSSlEb2wUaiCs tAfYO5qpBsfwzpWuaVw== X-Received: by 2002:a17:903:248:b0:2b0:af2f:b26a with SMTP id d9443c01a7336-2b269ce75dfmr68411175ad.48.1775125200946; Thu, 02 Apr 2026 03:20:00 -0700 (PDT) X-Received: by 2002:a17:903:248:b0:2b0:af2f:b26a with SMTP id d9443c01a7336-2b269ce75dfmr68410865ad.48.1775125200433; Thu, 02 Apr 2026 03:20:00 -0700 (PDT) Received: from redhat.com ([209.132.188.88]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2749cada2sm22687075ad.71.2026.04.02.03.19.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 03:19:59 -0700 (PDT) Date: Thu, 2 Apr 2026 18:19:56 +0800 From: Li Wang To: Michal =?utf-8?Q?Koutn=C3=BD?= Cc: Waiman Long , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Shuah Khan , Mike Rapoport , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Sean Christopherson , James Houghton , Sebastian Chlad , Guopeng Zhang , Li Wang Subject: Re: [PATCH v2 1/7] memcg: Scale up vmstats flush threshold with int_sqrt(nr_cpus+2) Message-ID: References: <20260320204241.1613861-1-longman@redhat.com> <20260320204241.1613861-2-longman@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: > > with kernel functions: > > var1 = 65536*nr_cpus / (45426 * ilog2(nr_cpus) + 65536) > > var2 = DIV_ROUND_UP(65536*nr_cpus, 45426 * ilog2(nr_cpus) + 65536) > > var3 = roundup_pow_of_two(var2) Consider a 1024-CPU machine with a cpuset-constrained cgroup using only 2 CPUs. Its unavoidable batching error is just 2MB, yet the global threshold imposes 256MB (harmonic-mean) or 32MB (sqrt) of additional error — 128x and 16x overprovisioning respectively. Both overshoot, but sqrt stays bit closer to the ideal. -- Regards, Li Wang