From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A84C7285C8B for ; Thu, 2 Apr 2026 13:00:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775134860; cv=none; b=jnJX5K/G0LGdA8shZZ1uBgIy373DjMzu4aZYjdbyZq373rW77CYCgCogGHj1ibvzAdsqs7CS75HlkI8cCsCs/lOzeh9sTgUSm+fwu3166oKC7MrnHbovWAecKP1QHG9sZbt8qayoqRoGM7HE9XOgBXPAYfxVQ6sJnZXgPYYuNH4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775134860; c=relaxed/simple; bh=P4aQMbaBnnxQLePUnINQzLxACT0pK5SmCXI4vlruYo4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=khQ42ZoWeu/oLqUpSMj8A+M5PfoVZ7qMFssbe3gD6PII8IkqJWjTq1gxhKcKMszncAq0voGRVEDmP7UZZmxkRcE5m+B8yy7i6d+ZnLvSyuYcd12OR0PA8Pftm3cYqTTlZXgsVTfpi4SMfV8u78wrQMaUuK2uoZcS3hE73JAIT0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=owh4RlT6; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="owh4RlT6" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-486507134e4so11002685e9.0 for ; Thu, 02 Apr 2026 06:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775134847; x=1775739647; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WBUUN37+QBAzPQbNHxZUZ/UPJ9R3fSHJHiwX6qvjBAA=; b=owh4RlT651N0dj+rzq30VAAY7uDxLaCs37qBXB0Tx9MQ2yu/+7AKWlJA1ojW3xvTty 4S3dOoKcMdnYP07j7I/70tqDdnxNkWhVLQYSYGfZ6XizJYWIVd0L0QSeVUPwtRCjg7a6 P4IFTwJwt1Vast/6b8XfkqgMyRV83/Z3U/WaPMhYK6AHWSnXlRLcEKq1RlckOwa02SM7 p7HHPPDRt83oZ+8MHLixGiEkrOLmkqJc3vpOg3yG7XjctZM5HrIx4fqm5Q/6S40fJ41g 7cjTTT0LcqnSuzemJnDNoXforqzgBslA4BJMw5A+ccZvBkgDjRnoW4HJqqdtvB29VoBM aMbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775134847; x=1775739647; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WBUUN37+QBAzPQbNHxZUZ/UPJ9R3fSHJHiwX6qvjBAA=; b=DnJm8lIOWX+q9DYf6FDc2Wx3sZjCIV8Gvd/krTG9FFD1bxgKlibM+OucaqG36h/Pa9 ewpD4dReD8fMxKp5cHtkSjssrLjifxcwitkCN7r4+S5cQAPVZXg3+zWbCjDpM+sY8C+I iwFQ2ki1SuwQwiWRhrL3WxiuLJiUeEpPYkV8cUzw2t1EKlloBkr5qJXb5JX61195AdoD 7uNLHZseII4xaIXVX8GL/7KAInhX7nUMY2zctGrhruvvtcIVQr2xHaQUyQuAuize6UvA sZyiibBqkIv3HIYtWNRaSIjYMWG7VtpQtwVFUMudVT8kseyKydRyyI98/6ioUdR53gQi V1VQ== X-Forwarded-Encrypted: i=1; AJvYcCVyrqxWVzfTs1468747MLWqNhlJ+xxTUZgyy+bmYUD53oQEEosGg75NHaHXMT/FG62JjjlMbjxePZI/plw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+CcmXmZe9vP3Dz4K/9e838jpyIdEhH2TtqnYaux4ifX0EPe8G V+8NWUwPsh1Tk7eScD/4yXzVIX0d13mEpOdJFk92LVztcKc6hr8YjRLs X-Gm-Gg: ATEYQzy7sZNPMT0wL2IKK9/5nW0rwL4aqL1rTekbGiuRn1e5GepqurtxEiMAtII8pUf 1a85rkk21PT2oVuQfeEO7uUvQsfpkOnB3FpFFjoEoDiRg0ieN56dDstv1AD8kNwmLKZ1J1r8pgB d5P93KXqcXpVbjUhnKC9xF/qWmyZThfWfy+OAN/kU9UdH1JEkw1Ic2E9tQMnKKL+NpMWPJZeZIo zL7P1oZU6EP3Lv5pJdV6OPCAEV8UEZ3941Uiz/1WDuPRvZhkhSLfbWh1UuETHLVxsD82GntBSBk Ej5scbRrgE04anshXpYfDSqKYATokWGoxv/tj47Y4lJUcuRwXI/A/qIWTffd63ephDaMTn0Y5TX LDtAmUj/hkX/mEnjQk7IeWTboZYphXFi40rKv1Szwv0b5SKf5OUcymyi+T1hkpSL2q1jBtFLqtc JeW8oj07uDiEAgxpSSkZw= X-Received: by 2002:a05:600c:8b83:b0:488:90ac:8f71 with SMTP id 5b1f17b1804b1-48890ac91bbmr39369785e9.5.1775134847181; Thu, 02 Apr 2026 06:00:47 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4888a626100sm121462725e9.1.2026.04.02.06.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 06:00:44 -0700 (PDT) Date: Thu, 2 Apr 2026 16:00:41 +0300 From: Dan Carpenter To: Andrey Skvortsov Cc: Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] media: cedrus: Fix failure to clean up hardware on probe failure Message-ID: References: <20260401191441.1217646-1-andrej.skvortzov@gmail.com> <20260401191441.1217646-2-andrej.skvortzov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260401191441.1217646-2-andrej.skvortzov@gmail.com> On Wed, Apr 01, 2026 at 10:14:41PM +0300, Andrey Skvortsov wrote: > From: Samuel Holland > > From: Samuel Holland > git am isn't set up to deal with two From: headers. > cedrus_hw_remove undoes, that was done by cedrus_hw_probe previously, > like disabling runtime power management, releasing claimed sram. The first part of this sentence is missing. Otherwise, the patch itself looks okay. regards, dan carpenter