From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CEC13E556E for ; Thu, 2 Apr 2026 13:09:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775135377; cv=none; b=urI/DarSD/G+kUSuEy5c6mljyPIUvJzFVSqd7o+MgC8DSBiv71CIvZGGKnOnz61ubrLb6lvkR/V0uB4NdCestZAlEotuu2mP16cDnVKkXb5EGl6IQN6phG65PaYytJyRcTOamcYZNqFWb6M8gj6iNccdhQ8VXsRmPZDU8mb2jko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775135377; c=relaxed/simple; bh=YzIB4Lu+zX+IE4ZJ+/9khtZjX6XzKpii2qvc0U32c3o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VzxWmASfBXPuUfobj/evLmBCUeOmLBGe5z03lQUPws3g0/6r2OqTOzDWXgfMcKUuyGx9C7tNNZh0+jpIODCgQOZJco0oeu5d7pQpTgwTODLn6nqY1Sydk/GQyx6lcIeUf0I6ZkHXkXixf03xzJ8q0SAewsxnVi+NW2foiflgYnk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AnLpZxwr; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AnLpZxwr" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488879b2e6aso7627445e9.1 for ; Thu, 02 Apr 2026 06:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775135371; x=1775740171; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LBHNBVUFUCJBpW5DUWaq2VhnmG86vXoZK/pVSYZwtz0=; b=AnLpZxwrjiqmFLRDhowyOQnBkDRGV/B22U38khe9b+VZPd/cDkJCxbdRTR99yATtp/ kWq/j07BIS9VlVrDEmPf2fydfsuhrFcBjYxfga7/rYx+f9A7PWRCFlt244QVtEwj/FbS zCwrB89GVXhW59uahfuM81bz5I7kiAmtXNP6o3jvFz4/sUwy6MbFPEsHBZ6EYJA18r06 OPlXthDKyeZ7PSECTGYK8BQxmt/6Pq8SWSIzU+FzfbGoch4wlzSoLqyJj9ARJfskyyYP ilu5hu2BVv/0rQ3JMpZI7OjU3cgcLIl1WY+i2HEQiIWF494/in8m4RTRTO2RWn6MJ3xO mgig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775135371; x=1775740171; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LBHNBVUFUCJBpW5DUWaq2VhnmG86vXoZK/pVSYZwtz0=; b=NvCdtFPd3z8CW0SJ3FfZHNmQZF0h7WJJOmkokB3U2aI51Dxgn99KDdNYEFNXff4E6C 3UnVhXCGb2lowGIKgbbdFiKn+tZT1JiY6H5nnzJsbLEURp3ee9jQuPkzsTxxPnww4YnJ +RrXp7g7p5dP8ScYmQ5swbJogbMjOh76aRUR2oik77w3y4NhwNsR2EhtF/hfPXyiBXX8 +XHozYU/gPvabC6/u2YZEDPC5MGMD3vawYnAD0+VO+L/q9mgHJKIYn/JD40ToKD0yGpl YXZSL6hMTLAtMxEd84/9PVleEY+2eZG1x6Dl36poT0PVjCAJc4MaVBVegFl0k8PA9IsT OlXQ== X-Forwarded-Encrypted: i=1; AJvYcCW94Jxtek3Qtt+daeQLSZBuLm5fi6DAhfH82h4VHD7n4YeHxtQ30v9VUsOkQDsgZT6icMLQ1M6KHUwIYu0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywz6lncVimXxs+JguyXo0R6ItQCTveOgM7CdWTpC+LTyoZUji8O 0JV4ajN/cmVWtJzqJrG67ncVr/xjFPET74MCm+gN6P4FUtYJv3rYkwQI X-Gm-Gg: ATEYQzzoJekTXzPh7DPIPgUVpwnoWzi60TQhLI6qGmHC/1otACKxiOfffKxu7ByB/tv UGVoTZc3KSbL6AhnZ+eiHx239LWAsNjTQnU98eaTKgUC4uKAhjyqcofV1kvERuJDcvitQ6H0has XcTIQlvTWZ+z9bCAyi9gIw/UXAkFFRX5DHjA2AsoRt1Eg31USrexOylUqKRl1M5EKbG0brE2Y4U BnBtZNC+LKGb87nu/bmbUbq4IYgsfi94ym2QRK+C5k0SzC+8iJbZ/0sqeB0105D7E7s2GAmaoKF PICTX4Z+H1Ztvmv/ATvPvIXCssIWNySRgWCpUlx584XJiW/tugBVbRZROkAiafLbDrxQGyy32sI YiTXKtYl6bWm5v4HNDJZri6RjRhtpvOVrEzEuiWbSVNe/Ia9mWFf/WAbZW9drr03gogdeBQqe6R BQ/Fr+5CYNfDiEFosVTj8= X-Received: by 2002:a05:600d:11:b0:485:3ff1:d5ed with SMTP id 5b1f17b1804b1-4888355df72mr134713795e9.1.1775135371137; Thu, 02 Apr 2026 06:09:31 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e829c43sm175553955e9.5.2026.04.02.06.09.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 06:09:30 -0700 (PDT) Date: Thu, 2 Apr 2026 16:09:27 +0300 From: Dan Carpenter To: Andrey Skvortsov Cc: Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] media: cedrus: Fix missing cleanup in error path Message-ID: References: <20260401191441.1217646-1-andrej.skvortzov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260401191441.1217646-1-andrej.skvortzov@gmail.com> On Wed, Apr 01, 2026 at 10:14:40PM +0300, Andrey Skvortsov wrote: > From: Samuel Holland > > From: Samuel Holland > > According to the documentation struct v4l2_fh has to be cleaned up with > v4l2_fh_exit() before being freed. [1] > > 1. https://docs.kernel.org/driver-api/media/v4l2-fh.html > I wish the commit message would say what the use visible effect of the bug is. I looked at it and I don't think this patch hurts but I also didn't necessarily see a that the original code had a user visible bug. I read the documentation but it wasn't as unambiguous as I'd prefer. But I'm not a subsystem expert. regards, dan carpenter