From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90C21303A0D for ; Thu, 2 Apr 2026 15:34:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775144050; cv=none; b=Syso6/II3UtUPyyDSWvWTfjZNWW/dp+e/UmgeiADuZJnpjn4c8U3wozfDqHA3i5OmAdK+Lr45RoKMU3k8f808TdS8zA0SB3bK9puD1MFzgdnW/538X24QUq8pWY8aj4JCpk6H31/BgG0JUvdtj2YdJ6VKpAFK/CTifVSUZcUmhU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775144050; c=relaxed/simple; bh=VL4lBHVu6zmGUU9nz+PN/SJ7XueMUbcbTQXKq9IeTYY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Rzjoa1x39PJsR5K6LbaudDjoAMqZNHE8EbcvaZw4nt1SsdT/CfLzTRziAQxpCOiLFMe7Ta0zBlAknlBn5mI2DWXY2UGHsVVgs87u9CMaeCCoexE44vfQfd55zhj2HYSPmbpUDwidptaoeEAccMHAJe1TITuD2TqahiYIpMgN+o0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=FDDFR6OF; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FDDFR6OF" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2b2591757fbso120365ad.0 for ; Thu, 02 Apr 2026 08:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775144049; x=1775748849; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ktk7xptOhNTCBPMKzgE2ARifOuymzl3kcaYnuA/xXMc=; b=FDDFR6OFNce6Iddws3/Dt00EL/gx4rN5tVSAXjCF18GV8w1xcfo9NSCeg4sLkT0+YE I48wKaH4dY1nmQHbaqBlNtCIDLOxHSOowdOi0dfUVTyONsuD1tk+VLP1SAI5aAQqF4Qd su9c2dfszjo4ycpoSctih73hI6qVx46PTRYzheLP4HVrXN2QO27LN4hxpBxE0o4HPyMe /ZaMFswAXZ+Yfk+h8vebFMiGRIAaHf9MOQuTYBl9z3P2yqVKfb48o+F6yreIWsa9rYcc hcEGzx1dvsbYHyI2dZ/n2BSdFApb5BWV6PzQUUF5YrTNWZKuZdCk7rPp3FgfrxX7b0nR d7ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775144049; x=1775748849; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ktk7xptOhNTCBPMKzgE2ARifOuymzl3kcaYnuA/xXMc=; b=iZd48qi8sD08UfQ2hRskXnS5Oe2WT1Ey6Rcw6Mj/33oZ9RmBqzmL1O/0GPYC9j3u4a x6j5FS9reg42foQ7y6jyqOY026nO8ABl4UOuMkEgunvz849yjLg3Qu0RSbEGtnBviTxf 3L06rbzggCE3xXl7kyg8YPKn514coWbTOrXSr39QmOIP6Jr6UdN59CJooZbA1mL7eA9x OcKbSFjniM2rJtjkcPe462VnjTqsZA6FRINb/fRTI5mJEMJqsnCjYDrRACcdr7Net9XR F+EpntXhydtOSIxAdyfHfLnGUwc0jwSR4j+JvF5z33Qz0GTpDdJ4c2r0s1i3QpPqq3X3 1Y3Q== X-Forwarded-Encrypted: i=1; AJvYcCWYx0bDA2LouB7H1P59qMwb+tYFGD4gF6pDChbzC+yC06lScdYl3HouFELfX9b+j2OEKXvJjfuPQF8qtLU=@vger.kernel.org X-Gm-Message-State: AOJu0YwHXtCH4B2p+EMUeG61XJm2r8JEG1v8/eRZklwzeQ7yo1QbDmo7 /9qwB0HvliQNb6GRVwWrRvBW+Xblra3MRy4xoMchDoOdLshPatoGHAaslloPdK6aKA== X-Gm-Gg: AeBDievAXYSFBgO+Z5gqbAD/5jJ2ribBuin9uKQFKRknOkKx0kxfoppiwplzmLAqoe9 kaY4e4O9rN3xy+ZjfsIwacOjSzAsbCVwm86Dxk/uHyLuweHNVM9naOqT+tNRtXB/aLO38GLMQLr 3YmJWf0EhqKA2XgWpXVqZ051q1YiInS66nMIVlnZ6S6IbLeoBTgKReWI3NF20QKM2TbGjglIHAD Uvs5840MGitvyqy52RNLRIsZqvraLsF9hHe2MYNu06NguoaVPtcfVx+EKi/9kGhworQk5YLFTsD s1Wx/KaMWrpTia3wwXh1chq+eDIpW9y3/aeCrWc25IUZrvLRhEdZBdNYsubvlWF4dessLEQjCik 522YGMsN5CgMZxeHYCnNSqxNNRJ1EZhRELRSVF8tOTqcGewwbvpbftDzTGO+MRG5GpMsoSffEjT TFVIjcY7houNfxFlpLHrlqkSq0tFS8vqpQGRWjmYJo9APNMZQiOgv4ljbmYlcNMQ== X-Received: by 2002:a17:903:1ace:b0:2b0:4d40:ce18 with SMTP id d9443c01a7336-2b27858a844mr2358385ad.14.1775144048316; Thu, 02 Apr 2026 08:34:08 -0700 (PDT) Received: from google.com (91.195.168.34.bc.googleusercontent.com. [34.168.195.91]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9ca75dfsm3398012b3a.60.2026.04.02.08.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 08:34:07 -0700 (PDT) Date: Thu, 2 Apr 2026 08:34:03 -0700 From: Igor Pylypiv To: Niklas Cassel Cc: Damien Le Moal , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ata: libata-eh: Do not retry reset if the device is gone Message-ID: References: <20260402011101.676267-1-ipylypiv@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Apr 02, 2026 at 10:55:41AM +0200, Niklas Cassel wrote: > On Wed, Apr 01, 2026 at 06:11:01PM -0700, Igor Pylypiv wrote: > > If a device is hot-unplugged or otherwise disappears during error handling, > > ata_eh_reset() may fail with -ENODEV. Currently, the error handler will > > continue to retry the reset operation up to max_tries times. > > > > Prevent unnecessary reset retries by exiting the loop early when > > ata_eh_reset() returns -ENODEV. > > ata_do_reset() ? > > The loop is inside ata_eh_reset(), so it sounds a bit weird to exit > the loop early if the function itself returns -ENODEV. > Thank you for catching this, Niklas! Yes, it should be ata_do_reset(). I'll send a V2 to fix the function name. Thanks, Igor > > I guess you could also write it like: > Prevent unnecessary reset retries by exiting the loop early when > a callee in ata_eh_reset() returns -ENODEV. > > > Kind regards, > Niklas