From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E30131079B for ; Thu, 2 Apr 2026 17:32:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775151144; cv=none; b=aHpFprhjhtvCenpdlXmE4jmg5Oh7yJ+R7xOjXZrQLEb4KWjl0y1l8uJpu6pq9NtAycxf4u/d+guVBryphcIKci78YBoDVKCYIx958H0EVgqGFxqNS2XzVVB8BN+wDk4ACdxvt3JdoLoEGrnpwZ7riEclSt1F8Zc8tWGu4QKoZ7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775151144; c=relaxed/simple; bh=zdBBr15vHbzzK+y/RTD6lEdsU2YY966kOlrvNECGXvA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oNobhOXmEwh7Q5kcGwj8/n+H6dZ1bNi1v6uvx9chnddwVDTkrsA4BfeRDzeV+nRkvlrPDCA1JYKyA2mrbr4IKGHXhm4PET8VyKCrvV2o5EMY+r5DuZ8EYGaDzsYHltZ86dGLVrizPiM6BouNEfiz6wa2lGurZNxx4BTJ1KiIc6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M7XJXmio; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M7XJXmio" Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-2b4520f6b32so1358254eec.0 for ; Thu, 02 Apr 2026 10:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775151143; x=1775755943; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Zz8YcwWkdWOvxMK3RVth/0rCZCw77MdxTEXEAAB58s4=; b=M7XJXmioN8DtSRvQFuJzekcXon7Z5sPBAnc5ZyVWObahwDggIllT80d/KrE+zeHKQD Ro74QkgBm80nH0dWvU+hGMjEy/uouG0GvBjjNeC8MoLhYUqPTPby4BQ0R01oDh6SqK/p gOgFX1Ot4+k+Lfeh8Oqvj+mwL6m8YTFI2eS+Q/2RMeh2bh9dWOkte20/23AKV65Dlpw7 VtlTZLMsowxMpzzE+iOXnsiriQb1AC3WnmLAEQmaTKMrmgTvgZwVN5Yx54C4Bv/sx9q3 stgI/FibEHpuBMoaWTq9xByz5QiotpdT0BFwEdla/oN7tViWzqQDbUGT6D7UEUSsPQde 0wCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775151143; x=1775755943; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zz8YcwWkdWOvxMK3RVth/0rCZCw77MdxTEXEAAB58s4=; b=noBecrR/pUfTxrUpjfIOIq9shNm8UiO4vMcSMcUsLaRccZkmV8uf4A2mZINlXxDuxo MUc3Tz3Jn1R64AmZN2/xSQEp15ecQtPQYW5HbvHnTdflfSWkY0X1yFPkMbJ95KTzRslR fCDlaYOqq+wLhQSW2AT1lRT/QIzJ7cQp+KGW1NWIE5c5GO45INEQNCrUD5JYpmyS2OCI CxHF/bPWzRK0NmOsZLxHAYjiKi8hg/vFCn3A+0DhbSl7Gils5Dm5hY5OnvLxSOkqiKLP bYz7sD6WWMcXDGZM+krOTMqvQlBXUv7x0hMcJvzlsi5IJf/gS0MTi0lkN21DmJVtjqSH SXWA== X-Forwarded-Encrypted: i=1; AJvYcCWZyb+gxpKxzuCEPGpZrPCrOirofUF8WOAvKdDdcikbWXQ42qk5NdMRUnmDekFAP4y26qpY1Ow8OXrmSYE=@vger.kernel.org X-Gm-Message-State: AOJu0YxK5MuhTA3N7Xolz9hjXv0C/pLtVAeT3Q5Tuey6G0k79h26VFhU cMA+zvoSuYqYh5XuAgpdRKHjGiN5JOeArwB84qb3k/YgZjezQeUETLYj X-Gm-Gg: AeBDies0y5gj/VISGpyDVLbBl9BAi7AE1T0FVcjBf/p4mEwyrMY/YGSNkXo4ifZFpBT DwwUVghFsN2sJFO6THUKXSE6xi2uBwNwBhR+SnBCzt34oCqPIBbRhoOZO9OfwWl3gkx0OX/jb8j l0DTGSo6XsMVh4bKQHiJT1QvTPfQ0V4sabSU83f8SxziB6zvoGcx2BpRkdpU7VSZUak20y0cqZj /9t1zMIOHPSxeO4PgBPPq+EM6uMapiNJI5l53sWGX7joNN1VAbR2aY+Z7zrVizUkGdmTSM0UF3J GpzCweS8hc6O+GNJBpcyjrCFNai9/pWb3d9qYnxKteGRNKcii8Vifu8xwLVMCs7pMb3oVG5j0nj 3nvZBEVqv+5WDjLwOAVf+62e6bnXNljeeu/2wJ7S7qPaRxN57zQ1xY27bz8oJ8FLscokZkgg6x8 /zyLMkMm2fm1zc1kTNEpE8To7ljvPdQ8xipkGqZykaB4cVkb1yT8krk6GB5V4Zq0Dt X-Received: by 2002:a05:7300:6da8:b0:2c0:ba91:48b6 with SMTP id 5a478bee46e88-2cbfc073927mr1038eec.26.1775151142569; Thu, 02 Apr 2026 10:32:22 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:902a:cd8d:1c0d:8926]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ca760b0518sm3001257eec.0.2026.04.02.10.32.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 10:32:21 -0700 (PDT) Date: Thu, 2 Apr 2026 10:32:18 -0700 From: Dmitry Torokhov To: Bartosz Golaszewski Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Kevin Hilman , Arnd Bergmann , brgl@kernel.org, driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v5 4/4] ARM: omap1: enable real software node lookup of GPIOs on Nokia 770 Message-ID: References: <20260402-nokia770-gpio-swnodes-v5-0-d730db3dd299@oss.qualcomm.com> <20260402-nokia770-gpio-swnodes-v5-4-d730db3dd299@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260402-nokia770-gpio-swnodes-v5-4-d730db3dd299@oss.qualcomm.com> On Thu, Apr 02, 2026 at 04:15:05PM +0200, Bartosz Golaszewski wrote: > @@ -244,6 +263,13 @@ static int __init omap16xx_gpio_init(void) > iounmap(base); > > platform_device_register(omap16xx_gpio_dev[i]); > + > + ret = device_add_software_node(&omap16xx_gpio_dev[i]->dev, > + omap16xx_gpio_swnodes[i]); > + if (ret) { > + dev_err(&pdev->dev, "Failed to add software node.\n"); > + return ret; > + } I think the best and safest way is to convert to using platform_driver_register_full() and set swnode in the relevant "info" instance. Thanks. -- Dmitry