From: Sean Christopherson <seanjc@google.com>
To: Roman Gushchin <roman.gushchin@linux.dev>
Cc: "Lorenzo Stoakes (Oracle)" <ljs@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Guenter Roeck <linux@roeck-us.net>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Chris Mason <clm@meta.com>, SeongJae Park <sj@kernel.org>,
elkin@google.com, Christian Brauner <brauner@kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
Sasha Levin <sashal@kernel.org>,
Shakeel Butt <shakeel.butt@linux.dev>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Ian Rogers <irogers@google.com>,
Venkatesh Srinivas <venkateshs@chromium.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: Introduce Sashiko (agentic review of Linux kernel changes)
Date: Thu, 2 Apr 2026 15:57:14 -0700 [thread overview]
Message-ID: <ac70Sl4PGF_6A21I@google.com> (raw)
In-Reply-To: <87jyv7a1q5.fsf@linux.dev>
+Venkatesh and Paolo
On Thu, Mar 19, 2026, Roman Gushchin wrote:
> "Lorenzo Stoakes (Oracle)" <ljs@kernel.org> writes:
> > On Wed, Mar 18, 2026 at 11:33:22AM -0700, Roman Gushchin wrote:
> >> >> Finally, some subsystems have a good prompts coverage and some don't. It
> >> >> doesn't have to be lengthy documentation (and it might actually be
> >> >> counter-productive), but having a small list of things to look at - some
> >> >> high-level concepts which are hard to grasp from the code, etc. - can
> >> >> help a lot with both bug discovery and false positives.
> >> >
> >> > I guess best contributed to Chris's review-prompts repo right?
> >>
> >> Both works for me now, we'll figure out with Chris how to sync our
> >> prompts. The small problem is that we're using various models, tools and
> >> review protocols and barely can test each other's setup. And it's all
> >> very fragile, so it's not exactly trivial.
> >> But we'll figure out something soon.
> > Yeah, part of the fun I guess :)
> >
> >> In general we need to carefully separate instructions (like which tools
> >> to use, which prompts to load etc) from factual data. Then we can easily
> >> use the factual data with various tooling around.
In an offline conversation, Venkatesh had a very (IMO) insightful observation
regarding the factual data of the prompts: the information is also very useful
documentation for *humans*. And in response to me lamenting about having to
potentially review an external repo, Venkatesh also suggested putting the gory
details about subsystem behavior in the kernel's Documentation/.
To me, that suggestion seems like a no brainer. The existing subject matter
experts are already in place to review and help maintain the documentation, the
documentation can be updated in lockstep with the code, those of us that like
email-based review don't need to change our ways, etc. :-)
And irrespective of AI domination, I'd love to have detailed documenation of some
of KVM's gnarlier internals. If AI review is what gets us the staffing/motivation
to write and maintain that documentation, then so be it. It would be a shame if
some of the most comprehensive documentation for the kernel is buried in AI
specific prompts.
Naively, synchronizing from Documentation to model-specific bots doesn't seem
like it'd be a hard problem to solve.
next prev parent reply other threads:[~2026-04-02 22:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 15:31 Introduce Sashiko (agentic review of Linux kernel changes) Roman Gushchin
2026-03-18 12:03 ` Lorenzo Stoakes (Oracle)
2026-03-18 18:33 ` Roman Gushchin
2026-03-18 18:50 ` Lorenzo Stoakes (Oracle)
2026-03-19 22:33 ` Roman Gushchin
2026-04-02 22:57 ` Sean Christopherson [this message]
2026-04-03 1:48 ` Roman Gushchin
2026-04-03 7:47 ` Lorenzo Stoakes (Oracle)
2026-04-03 12:11 ` Theodore Tso
2026-04-03 12:23 ` Lorenzo Stoakes (Oracle)
2026-04-03 12:34 ` Chris Mason
2026-04-03 14:02 ` Lorenzo Stoakes (Oracle)
2026-04-03 16:58 ` Chris Mason
2026-03-18 18:50 ` Chris Mason
2026-03-18 15:00 ` SeongJae Park
2026-03-18 18:43 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac70Sl4PGF_6A21I@google.com \
--to=seanjc@google.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=clm@meta.com \
--cc=dvyukov@google.com \
--cc=elkin@google.com \
--cc=irogers@google.com \
--cc=konstantin@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ljs@kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=pbonzini@redhat.com \
--cc=roman.gushchin@linux.dev \
--cc=sashal@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=sj@kernel.org \
--cc=tytso@mit.edu \
--cc=venkateshs@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox