From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15E9F3A256C for ; Thu, 2 Apr 2026 22:57:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775170639; cv=none; b=uSkd2EfhqVGR2UnJlkM67ksqSHG2HE67aZBSvDM8SKEt1GiLhAY11whwITep/A7wqtL1tFKj4DdH+l/+9P4Z05VOO6mrLNZDUXYQCJjE6KRpopUaOeAUJyQyI9cIn8jz0QykQ7qAmlX37OWAoyExEWU967IJWYo21KM8v6biRD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775170639; c=relaxed/simple; bh=b/5/sfpUtWav2g8Ck0AWE8lDZuAwf1YOfkAi5kKbwEs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=NllBeEEfpztfaVDYebJbKnfZcWSckFtSHsgJxBOYf2xe9gLBB50yuoXzy9XDGhZMftk9Pbpg/bQsKfIYqlWxSKetEDxq4XgD0v6OO5LgRbxSKnizHN3aHXlEXdtZFFJh34ULyhpC9NFd0olKzMJKignYAfSJc4jaKgswDEDMt8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=M4h0yK5b; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="M4h0yK5b" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-82ce1c395ccso1887164b3a.2 for ; Thu, 02 Apr 2026 15:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775170636; x=1775775436; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=0+i86ACx1u1KJaLwv1nY/pm0WViWGhcx1+/5vtsJtTU=; b=M4h0yK5bnzwmwItVFVaFdj8wNid/3h7Yw9sPV9BXwUMq+F4fZfwB+1YaHdrGn5Oo4v DYt9nVBySK0UI725jpiXqVC5NB71Wi1ItBPm2QLfDnds1ECLsnFAp/vgLQ2lLWiPOq4U KpYkVlO9l79BJOYyi6+nJsoTpKYgWFDTvtVDyUyVnPVceST3ukATvVvkxzJsh22L5P29 55Ao0tEHbbZtPjHzX3Q//gV9DBIstjGO0T+gUVTZn6WqIstoIWILX5cwYO3DJ0Tf/IsF teVzBMkM/WqQhtEZVFtQEMh3UedRj0Xxf/xW4xbzbmticdQtmJsqsIFK8ltIHdkqWQ57 116A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775170636; x=1775775436; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0+i86ACx1u1KJaLwv1nY/pm0WViWGhcx1+/5vtsJtTU=; b=tDpigxVnKu6xlgsXOLpkFdSQ6XyY2zHU83bWC3ExctAVmDt29oEZwjhUMxs6wbJ21i UVTPvs9ckjKKAyJcoCrhpAMfNzZVVLB66Apya5xfZvT1vA70hN9wfwe3FHxUhbv8OWi1 AxLfhabzKJSGXX9CwpOcW+EfGtyVjtAyXw3kWy9cUIZx9CsEebboX+Y6683wlzplS/MD icuRgju+B/zhexqQJ8fsyCe5hAEdkkqUtFdSoX7uM2Pma2Xmq/VUJlVhbY7CUTeceUee hFd+/hQekb8z/KunyHQfX9t1+y6R6p0oKwKAbPqxW3sdGuT5Jq9Tp2rsX07JEtnOP6F7 Rbuw== X-Forwarded-Encrypted: i=1; AJvYcCWeOlFQRYmOm8MyReByeJT55DAKmKMU2OjH6ynnDMnU7hpIyv3tYeb9hQaM6cGuQ0Ci++C6LQw0DhcxmFs=@vger.kernel.org X-Gm-Message-State: AOJu0YxAdzmCXQA0lb+kpLCpXQZQlNXmlm8L64udYQmPnBr81r9BWwe2 nfSAHrXbH7Ek1xZvZ3BCXvqUi+r9rx++Xbmxd4Wr3nqGnS33dekf5JjfoNA7V4fUe1/+upclnfO Ruq1Jqw== X-Received: from pfoo19.prod.google.com ([2002:a05:6a00:1a13:b0:82c:e328:c2f4]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:301f:b0:81f:3fa0:8c38 with SMTP id d2e1a72fcca58-82d0da90c83mr870316b3a.20.1775170635928; Thu, 02 Apr 2026 15:57:15 -0700 (PDT) Date: Thu, 2 Apr 2026 15:57:14 -0700 In-Reply-To: <87jyv7a1q5.fsf@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <7ia4o6kmpj5s.fsf@castle.c.googlers.com> <39e6b4d2-8a30-4eaa-908d-5d11b746f8d5@lucifer.local> <87v7etugwd.fsf@linux.dev> <34630bb5-840b-4a99-8e19-51fd4fc8ba96@lucifer.local> <87jyv7a1q5.fsf@linux.dev> Message-ID: Subject: Re: Introduce Sashiko (agentic review of Linux kernel changes) From: Sean Christopherson To: Roman Gushchin Cc: "Lorenzo Stoakes (Oracle)" , linux-kernel , Andrew Morton , "Theodore Ts'o" , Guenter Roeck , Konstantin Ryabitsev , Chris Mason , SeongJae Park , elkin@google.com, Christian Brauner , Dmitry Vyukov , Sasha Levin , Shakeel Butt , Lorenzo Stoakes , Ian Rogers , Venkatesh Srinivas , Paolo Bonzini Content-Type: text/plain; charset="us-ascii" +Venkatesh and Paolo On Thu, Mar 19, 2026, Roman Gushchin wrote: > "Lorenzo Stoakes (Oracle)" writes: > > On Wed, Mar 18, 2026 at 11:33:22AM -0700, Roman Gushchin wrote: > >> >> Finally, some subsystems have a good prompts coverage and some don't. It > >> >> doesn't have to be lengthy documentation (and it might actually be > >> >> counter-productive), but having a small list of things to look at - some > >> >> high-level concepts which are hard to grasp from the code, etc. - can > >> >> help a lot with both bug discovery and false positives. > >> > > >> > I guess best contributed to Chris's review-prompts repo right? > >> > >> Both works for me now, we'll figure out with Chris how to sync our > >> prompts. The small problem is that we're using various models, tools and > >> review protocols and barely can test each other's setup. And it's all > >> very fragile, so it's not exactly trivial. > >> But we'll figure out something soon. > > Yeah, part of the fun I guess :) > > > >> In general we need to carefully separate instructions (like which tools > >> to use, which prompts to load etc) from factual data. Then we can easily > >> use the factual data with various tooling around. In an offline conversation, Venkatesh had a very (IMO) insightful observation regarding the factual data of the prompts: the information is also very useful documentation for *humans*. And in response to me lamenting about having to potentially review an external repo, Venkatesh also suggested putting the gory details about subsystem behavior in the kernel's Documentation/. To me, that suggestion seems like a no brainer. The existing subject matter experts are already in place to review and help maintain the documentation, the documentation can be updated in lockstep with the code, those of us that like email-based review don't need to change our ways, etc. :-) And irrespective of AI domination, I'd love to have detailed documenation of some of KVM's gnarlier internals. If AI review is what gets us the staffing/motivation to write and maintain that documentation, then so be it. It would be a shame if some of the most comprehensive documentation for the kernel is buried in AI specific prompts. Naively, synchronizing from Documentation to model-specific bots doesn't seem like it'd be a hard problem to solve.