* [PATCH] remoteproc: dead code cleanup in Kconfig for STM32_RPROC
@ 2026-03-30 22:45 Julian Braha
2026-03-31 6:50 ` Arnaud POULIQUEN
2026-04-02 19:19 ` Mathieu Poirier
0 siblings, 2 replies; 4+ messages in thread
From: Julian Braha @ 2026-03-30 22:45 UTC (permalink / raw)
To: mathieu.poirier, andersson, fabien.dessenne
Cc: ludovic.barre, loic.pallardy, arnaud.pouliquen, linux-kernel,
linux-remoteproc, Julian Braha
There is already an 'if REMOTEPROC' condition wrapping this config option,
making the 'depends on PCI' statement a duplicate dependency (dead code).
I propose leaving the outer 'if REMOTEPROC...endif' and removing the
individual 'depends on REMOTEPROC' statement.
This dead code was found by kconfirm, a static analysis tool for Kconfig.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
drivers/remoteproc/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
index ee54436fea5a..c78e431b7b2d 100644
--- a/drivers/remoteproc/Kconfig
+++ b/drivers/remoteproc/Kconfig
@@ -316,7 +316,6 @@ config ST_SLIM_REMOTEPROC
config STM32_RPROC
tristate "STM32 remoteproc support"
depends on ARCH_STM32 || COMPILE_TEST
- depends on REMOTEPROC
select MAILBOX
help
Say y here to support STM32 MCU processors via the
--
2.51.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] remoteproc: dead code cleanup in Kconfig for STM32_RPROC
2026-03-30 22:45 [PATCH] remoteproc: dead code cleanup in Kconfig for STM32_RPROC Julian Braha
@ 2026-03-31 6:50 ` Arnaud POULIQUEN
2026-04-02 19:19 ` Mathieu Poirier
1 sibling, 0 replies; 4+ messages in thread
From: Arnaud POULIQUEN @ 2026-03-31 6:50 UTC (permalink / raw)
To: Julian Braha, mathieu.poirier, andersson, fabien.dessenne
Cc: ludovic.barre, loic.pallardy, arnaud.pouliquen, linux-kernel,
linux-remoteproc
Hello,
On 3/31/26 00:45, Julian Braha wrote:
> There is already an 'if REMOTEPROC' condition wrapping this config option,
> making the 'depends on PCI' statement a duplicate dependency (dead code).
>
> I propose leaving the outer 'if REMOTEPROC...endif' and removing the
> individual 'depends on REMOTEPROC' statement.
>
> This dead code was found by kconfirm, a static analysis tool for Kconfig.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
> drivers/remoteproc/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index ee54436fea5a..c78e431b7b2d 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -316,7 +316,6 @@ config ST_SLIM_REMOTEPROC
> config STM32_RPROC
> tristate "STM32 remoteproc support"
> depends on ARCH_STM32 || COMPILE_TEST
> - depends on REMOTEPROC
> select MAILBOX
> help
> Say y here to support STM32 MCU processors via the
Acked-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Thanks,
Arnaud
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] remoteproc: dead code cleanup in Kconfig for STM32_RPROC
2026-03-30 22:45 [PATCH] remoteproc: dead code cleanup in Kconfig for STM32_RPROC Julian Braha
2026-03-31 6:50 ` Arnaud POULIQUEN
@ 2026-04-02 19:19 ` Mathieu Poirier
2026-04-02 23:59 ` Julian Braha
1 sibling, 1 reply; 4+ messages in thread
From: Mathieu Poirier @ 2026-04-02 19:19 UTC (permalink / raw)
To: Julian Braha
Cc: andersson, fabien.dessenne, ludovic.barre, loic.pallardy,
arnaud.pouliquen, linux-kernel, linux-remoteproc
On Mon, Mar 30, 2026 at 11:45:45PM +0100, Julian Braha wrote:
> There is already an 'if REMOTEPROC' condition wrapping this config option,
> making the 'depends on PCI' statement a duplicate dependency (dead code).
You likely meant "REMOTEPROC".
>
> I propose leaving the outer 'if REMOTEPROC...endif' and removing the
> individual 'depends on REMOTEPROC' statement.
>
> This dead code was found by kconfirm, a static analysis tool for Kconfig.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
> drivers/remoteproc/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index ee54436fea5a..c78e431b7b2d 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -316,7 +316,6 @@ config ST_SLIM_REMOTEPROC
> config STM32_RPROC
> tristate "STM32 remoteproc support"
> depends on ARCH_STM32 || COMPILE_TEST
> - depends on REMOTEPROC
> select MAILBOX
> help
> Say y here to support STM32 MCU processors via the
> --
> 2.51.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-04-02 23:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-30 22:45 [PATCH] remoteproc: dead code cleanup in Kconfig for STM32_RPROC Julian Braha
2026-03-31 6:50 ` Arnaud POULIQUEN
2026-04-02 19:19 ` Mathieu Poirier
2026-04-02 23:59 ` Julian Braha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox