The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: Mike Snitzer <snitzer@kernel.org>
Cc: hch@lst.de, kbusch@kernel.org, sagi@grimberg.me, axboe@fb.com,
	martin.petersen@oracle.com,
	james.bottomley@hansenpartnership.com, hare@suse.com,
	bmarzins@redhat.com, nilay@linux.ibm.com, jmeneghi@redhat.com,
	linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org,
	michael.christie@oracle.com, dm-devel@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 00/13] libmultipath: a generic multipath lib for block drivers
Date: Fri, 15 May 2026 09:45:43 +0100	[thread overview]
Message-ID: <ac95f746-7215-47f9-b307-b0aacfc04d2b@oracle.com> (raw)
In-Reply-To: <agZnwW64PHRew_5l@kernel.org>

On 15/05/2026 01:24, Mike Snitzer wrote:
> On Tue, Apr 28, 2026 at 11:10:52AM +0000, John Garry wrote:
>> libmultipath: a generic multipath lib for block drivers
>>
>> This series introduces libmultipath. It is essentially a refactoring of
>> NVME multipath support, so we can have a common library to also support
>> native SCSI multipath.
>>
>> Much of the code is taken directly from the NVMe multipath code. However,
>> NVMe specifics are removed. A template structure is provided so the driver
>> may provide callbacks for driver specifics, like ANA support for NVMe.
>>
>> Important new structures introduced include:
>>
>> - mpath_head
>> These contain much of the multipath-specific functionality from
>> nvme_ns_head, including a pointer to the gendisk structure and
>> a path SRCU-based array.
>>
>> - mpath_device
>> This is the per-path structure, and contains much the same
>> multipath-specific functionality in nvme_ns
>>
>> libmultipath provides functionality for path management, path selection,
>> data path, and failover handling.
>>
>> Since the NVMe driver has some code in the sysfs and ioctl handling
>> which iterate all multipath NSes, functions like mpath_call_for_device()
>> are added to do the same per-path iteration.
> To get upstream this library needs an in-tree consumer. So at the end
> of the series, it'd makes sense to include the NVMe and/or SCSI
> changes that uses it.

I just sent the SCSI and NVMe series separately. Many devs would find it 
off putting to review a series with so patches.


      reply	other threads:[~2026-05-15  8:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260428111105.1778008-1-john.g.garry@oracle.com>
2026-05-10 22:03 ` [PATCH v2 00/13] libmultipath: a generic multipath lib for block drivers Sagi Grimberg
2026-05-11  7:30   ` John Garry
2026-05-15  0:24 ` Mike Snitzer
2026-05-15  8:45   ` John Garry [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac95f746-7215-47f9-b307-b0aacfc04d2b@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=axboe@fb.com \
    --cc=bmarzins@redhat.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=hare@suse.com \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=jmeneghi@redhat.com \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=michael.christie@oracle.com \
    --cc=nilay@linux.ibm.com \
    --cc=sagi@grimberg.me \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox