From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57280353EDF for ; Fri, 3 Apr 2026 09:02:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775206943; cv=none; b=iTifh0ft64Tq5fdVR+spxS9Fhxc4iwLjV8Gl6sywu/M9YdPro6qNXrNzKSlyQUCiULM6kYXQzWLyZQ1ENfXN9XTIMC3KzA0oCoAbMb90/LEj51BOExJDRJJv57iL3edUdurQ5L6Oi1zDgbP3+B0NSjGoRcVszc0ldWFSlqg9VFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775206943; c=relaxed/simple; bh=7XGrSCNrN5uhRtsxuhz5xVWLn597vTSmrRo+qSOXmXQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hvL3zrjolyI52UeIC8yxptENT37MFUotos1lnB0hKrhmrRVxas+opgExXJ7GTfCnnia4K7QG2PdUdgKtydK0ZCvhXsh2q50VyyIKc8WttDAOf4DUbHQY2o0sbyocxxVHf60A8ZNsjkb3wE0vbYrNpDDrSLimlgGCrHleMpZKcqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Js8Z/Q4R; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Js8Z/Q4R" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4887f49ec5aso23333235e9.1 for ; Fri, 03 Apr 2026 02:02:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775206941; x=1775811741; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NSuDIoeoytZjS9lz1nCHQAgnrLXZ7nvk4L/rgRFQaoQ=; b=Js8Z/Q4R4fQLHS8DnI0JMDgTj/BwVhI/MUKBgyp+756JiKZIjYFC/Uj0KikdKWdAFi 0WP4ju61hfmkNj0aMbCXIXsPvBY3Kiwo0/77ZYces+fO4K+WN1P4zgOxKW6mgFNwTwdc SF9rNf+10PP0GzexcLx/xdR3zRRdhHrVGH/RmM96y9PVyL26Fj50FYRBxm5O+6rNKiCA yYZ1H/tSQNpy5ZmsFbw8b88gxI4109cliJYhLjK/aabaliW3x5PzJUsgkXEgPubnDhrn FCOhTGwmWUcghBh3KGasOK4bYPCElsL1gmchiIKKccdkLbWxXL1Nfkkhr2tXZX1sAExk 3qjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775206941; x=1775811741; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NSuDIoeoytZjS9lz1nCHQAgnrLXZ7nvk4L/rgRFQaoQ=; b=Wpj7yiaPlHTFNLrHmbGNrvSEggDBqh0tPDK3whPtQ4dghTPEfB6aC11gHxlEJgc0hY NKppgiCKTNu7juHNzyMEbLPr7+MC0HiutNYJZ+KDE8W9+xeUgosxYscpf6ledtEMELPr nJUNXJVs9wiJ274HVxJ6ZWy8tW2H/Q4VLlvj0bINp1JPZl3KPLoFAz+h9iTfduS6kpwz ylW7MjGAlQFtRbiTLAxIbN/BKq+dhqh6vPRvrA7664kr0pWup8zaQI/DCh84VwobKQdf HpiidySKMrd9lu7+HkQWJBelpUryN0KtXR3sp1fmuUpP3nLlvb/hjGoytCpB7w2Je71h qayg== X-Forwarded-Encrypted: i=1; AJvYcCXs8qIbQRiYKo5QNi6pq3jxG9uAbrZz9vpbxzxBgBXrF/AEIzAstvvk2FrOxa5vHJsTEPwh8oSvH3nTRLo=@vger.kernel.org X-Gm-Message-State: AOJu0YyEKjwqtNouYKARPRAv96jrY6CtPS43eGjgZhF+MeKGV8rNLcnS C3anmKP1ScXSLu0YOUSTEF8+xnkj0tZTYzynkEo9YUnbV4aDEojglf9b X-Gm-Gg: ATEYQzx1BCqFSQJSzuta8Wl6/Ne78XWsrGD37uQ13JYaI27xZKUsRXvLe0HC3L/Jsm5 Ebc0vNGIFyr2AEY4et4PqhtjqpHK4XXf9P8uGMBJj0OlOSmf+nbUWN9pDWYPQziggUXfomCLNBB egfhOBqTpWe9B68lfNPiTkVnF59aCttdb5q97otvvbXuZOVqOgwVh8T01RpujM+oAMpYI2NUcPv s4aOOjU166ea16beZLRuRrRw5a+kZrjz+70CQQtQ1Gv+BgkU0yKs8xSIdr9JSCMEbp0I9Rf4Aqe W/eB57mxYP8XWHJNI65DcK/fBbI+qw025kJJFGlfUAjfWHNX3BLSiG9MW4oXaZkOp0krYENDOTm oZmqnOv60Uzbj1l24ClFxVtu1v1A/Zsn8uyrzMonN6DwYZqLiTHIaIZIMJIrYr0vEYht1eb81KW v+ijEsJnz7E2dtSroQqFoyUuOY4NWt X-Received: by 2002:a05:600c:8b52:b0:486:f9d0:aac8 with SMTP id 5b1f17b1804b1-4889978140bmr38999785e9.18.1775206940413; Fri, 03 Apr 2026 02:02:20 -0700 (PDT) Received: from gmail.com ([2a00:f41:1cc5:ab9:2a0c:50ff:fe2f:36f4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4888a626100sm218963985e9.1.2026.04.03.02.02.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 02:02:19 -0700 (PDT) Date: Fri, 3 Apr 2026 11:02:17 +0200 From: "Jose A. Perez de Azpillaga" To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, Andy Shevchenko , Hans de Goede , Mauro Carvalho Chehab , Sakari Ailus , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH v3 2/2] media: atomisp: remove redundant call to ia_css_output0_configure() Message-ID: References: <20260402183402.444630-1-azpijr@gmail.com> <20260402183402.444630-3-azpijr@gmail.com> <2026040336-humvee-throwback-72cf@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2026040336-humvee-throwback-72cf@gregkh> On Fri, Apr 03, 2026 at 08:42:11AM +0200, Greg Kroah-Hartman wrote: > On Thu, Apr 02, 2026 at 08:33:45PM +0200, Jose A. Perez de Azpillaga wrote: > > The function configure_isp_from_args() contained a duplicate call to > > ia_css_output0_configure() using the same output frame index. Remove the > > redundant call to simplify the configuration path. > > Are you sure the hardware doesn't actually need this called twice? Lots > of devices need to be told multiple times what to do in order for it to > "stick", hardware is "fun" that way :( > The concern is valid in general, but ia_css_output0_configure() does not write to a hardware register. ia_css_configure_output0() writes into binary->mem_params.params[], a software-side DMEM parameter buffer in kernel memory. the ISP firmware receives these parameters later as a batch, not at the time of the call. calling a pure memory write twice with the same pointer and same value simply overwrites the same location with identical data, there is no hardware interaction that could require repetition. > Have you tested this? > as noted in the cover letter, I don't have the hardware to test this. -- regards, jose a. p-a