From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14CA630B50F for ; Sun, 22 Mar 2026 22:30:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774218628; cv=none; b=SB2epdL4bLu+W19qs+eUZKP63YZY/llheAC6Vdq606X1iuuCJd/8yuLRQP904de4eQtNQ05djbZYijyhGkM5HtVvpRobhhImHoIg0jiOQsaREjoSsIwW/AcgrkwT4YEEeqkcZfTLvs/J/8Jv+remwwUUjQhz9Osj/9EDsLDDAfo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774218628; c=relaxed/simple; bh=NJZZRr6u7AK+2zjoYjxWMsNR4fFjykW2ztLeAXUoaiM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Kp2NbzuwfUrpgavryUQEZcrjKTmF+5ClTYy2yJIQaDzHqgel0OHObtfdkZrsTeK0lX4XpQDEf8VJveq/8NQCvRiQ7dyrfXJLf5hdRa8p9rob+ho6aGM4TpNHfv9vMWhjWJg8DFz9kSwPfrPsPYZ39yJHXEtpxHtuIVMajFk8zYU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=epjURxeg; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="epjURxeg" Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-2c0c955a481so1318892eec.1 for ; Sun, 22 Mar 2026 15:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1774218626; x=1774823426; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v8/snDZPO6XeO4hSNMbxl+x8zM51kjYVWzx4jFJ4eVs=; b=epjURxegdfxhbUotuR3zifm+ylcqb+nD3QBCrTB05jxUOfkE3CF4umIhowaajO2gqy L+LyMf20YsJm0qJDlvcbJYciDRt7NXQxKyEWRETYxjZeResFC6VwapjhlBe8CU4Qift3 xfzgTTAEf44+qxJ2qGiJzl9u1TfKazLD4bAu/zxBX12t76n3h5k65iyhDe3i0G6cMV2b wN3tgiWeAGNdPcp3S36uH0AmAvoM9ufaJGIiZvtiPtl0YjdKGLwbvwNERTh9JlXbz1Sf X2/9j1L6YoJWKa8N1QMCtMhdeVjrvDqsVEhMrluQbAXrNXliHC31Sqg5Pdx3UjtLBLAP i0tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774218626; x=1774823426; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v8/snDZPO6XeO4hSNMbxl+x8zM51kjYVWzx4jFJ4eVs=; b=splKVMDyrgHTh6UUZvQJ5FWWsoJllurgAXLZqchN4z5Ob3FjGikxTwpTkTqcBZ97Rd cHKEmbTjhgJqmfD8FxMG5jPCyBUN0S3Pc8MyBmzk4x3O3/kG3P5JvALa4kmq15npld3H Yw8Oui+vu7ldHbO3VOr4pt5sIwWQZwLghElhtSgJh3jcCQA7vh2s3fThsjHZ+bep6kCP x75QstX4uP7TLoN98JeRJmlLBV1ENTOup3qR3cZ7L1GdPTSsx2n9fIkWsv/CIb5AS3cw U2aP7LxBIF58MuPeozZZuLWLmJp+PF5yGD0joT6rhnNUFn1BQqmQQyLXdPtqLy/49mud yyIA== X-Forwarded-Encrypted: i=1; AJvYcCVZR6kJRpjO43/fdLJYi+2S3bo10aoGSMJveFeq7n1rbv0V2//IA7YHm1SsUZtERfSBy9Jn/g6hVAuvDkA=@vger.kernel.org X-Gm-Message-State: AOJu0Yze/dGB1Gu+67B1E5VAt9WOe4ZrXyq99nRTVlQtmHoT7Wf5TSkr 3A+qbnTYANvAw0Xgi3wCkSuoMsBXB7yBeCsORT5admzyhKM2WreP3z4E X-Gm-Gg: ATEYQzxIHIpaZgY8i+sPP4oFkTaD5lCHWcGcVwcUzaRumfGonyOHXw7633vZR6Sr8kF t4O1p4ytZDYG6XlOwZg6jqgrS1o7ULIWIb1DzVSAa5+sAI0h4KL6nfpUsvP6p26zDnKPgKY94TF JTiAReR39CqJBhkZP5MaJVZpx1g+dWnmYrA+v5iu1mdZGcqTpbxSbn7AYMUB65l2XalK39mnmzR aCxN1oujo0Wp9Xlwlnhz0oQ9wVJKIT+2ECJtX4p7MXq5bbWesMC6iYNZRHF5XdXXfA0Zk88OYJ1 IiJSW68+xj3fso9epTJLKIsbjtuYri7YD/UDLBERXdywNvB39HPf9dtlBl7LyA1tBEdn9wbR7Mx 5gAFi807xJy0BxXiKCyIEB35YxDWRhzpVdmQ+gcltGa76zKQqW457b9W2/RJOmQuCChisCxw0rj hZKWGM0NFpg3Ejedp5TqY1St2a4umuNVZFC7l3wJtMrQsEY/tFcK6P0bTy6qzL1ASZoTcWGkyZO 3c= X-Received: by 2002:a05:7300:d945:b0:2c1:1aad:61ad with SMTP id 5a478bee46e88-2c11aad9c45mr1952031eec.8.1774218625893; Sun, 22 Mar 2026 15:30:25 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:b768:22ed:3eba:aeb3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c10b17b8f2sm15091997eec.9.2026.03.22.15.30.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Mar 2026 15:30:24 -0700 (PDT) Date: Sun, 22 Mar 2026 15:30:21 -0700 From: Dmitry Torokhov To: Jonathan Cameron Cc: David Lechner , Nuno =?utf-8?B?U8Oh?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iio: adc: ti-ads7950: use iio_push_to_buffers_with_ts_unaligned() Message-ID: References: <20260314-iio-adc-ti-ads7950-declare-dma-buffer-v2-1-2087fc18b077@baylibre.com> <20260321210539.2de04bc0@jic23-huawei> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260321210539.2de04bc0@jic23-huawei> On Sat, Mar 21, 2026 at 09:05:39PM +0000, Jonathan Cameron wrote: > On Sat, 14 Mar 2026 16:12:24 -0500 > David Lechner wrote: > > > Use iio_push_to_buffers_with_ts_unaligned() to avoid unaligned access > > when writing the timestamp in the rx_buf. > > > > The previous implementation would have been fine on architectures that > > support 4-byte alignment of 64-bit integers but could cause issues on > > architectures that require 8-byte alignment. > > > > Fixes: 902c4b2446d4 ("iio: adc: New driver for TI ADS7950 chips") > > Signed-off-by: David Lechner > > --- > > Since we were looking at this driver, I was going to convert this to use > > IIO_DECLARE_DMA_BUFFER_WITH_TS() but then I noticed that we actually > > have an unaligned access problem with the timestamp since we are > > ignoring the first two elements in the rx_buf when pushing the data to > > the buffer. > > > > Unfortunately, this will cause a merge conflict with the series Dmitry > > is working on. I don't think there is any rush to get this backported > > since no one has reported a crash from unaligned access. Since fixes > > should go before improvements, we could apply this to iio/togreg then > > Dmitry can rebase his series on top of it. > I've done that. Applied to the togreg branch of iio.git pushed out as > testing etc. I've also marked it for stable so it gets picked up in the long > run. Cool, I'll rebase and send out my patches as soon as this hits linux-next. Thanks. -- Dmitry